[INFO] updating cached repository tirr-c/ilmeria [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tirr-c/ilmeria [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tirr-c/ilmeria" "work/ex/clippy-test-run/sources/stable/gh/tirr-c/ilmeria"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tirr-c/ilmeria'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tirr-c/ilmeria" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tirr-c/ilmeria"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tirr-c/ilmeria'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 96fd68a362fe738e6a231eefc1339f9ee3c1bd52 [INFO] sha for GitHub repo tirr-c/ilmeria: 96fd68a362fe738e6a231eefc1339f9ee3c1bd52 [INFO] validating manifest of tirr-c/ilmeria on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tirr-c/ilmeria on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tirr-c/ilmeria [INFO] finished frobbing tirr-c/ilmeria [INFO] frobbed toml for tirr-c/ilmeria written to work/ex/clippy-test-run/sources/stable/gh/tirr-c/ilmeria/Cargo.toml [INFO] started frobbing tirr-c/ilmeria [INFO] finished frobbing tirr-c/ilmeria [INFO] frobbed toml for tirr-c/ilmeria written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tirr-c/ilmeria/Cargo.toml [INFO] crate tirr-c/ilmeria has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tirr-c/ilmeria against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tirr-c/ilmeria:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 599c2963602bb2604e9c745f5fb9c63eb48afb9da3b5c4e5b295ed7262a0f65a [INFO] running `"docker" "start" "-a" "599c2963602bb2604e9c745f5fb9c63eb48afb9da3b5c4e5b295ed7262a0f65a"` [INFO] [stderr] Checking crossbeam v0.3.2 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking ilmeria v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `ProcessedShape` [INFO] [stderr] --> src/ingredient/shape.rs:134:27 [INFO] [stderr] | [INFO] [stderr] 134 | use super::{RawShape, ProcessedShape}; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/ingredient/shape.rs:50:22 [INFO] [stderr] | [INFO] [stderr] 50 | for c in corner_c..3 { [INFO] [stderr] | ^^^^^^^^^^^ help: try replacing the loop by: `ret[r - corner_r][0..(3 - corner_c)].clone_from_slice(&self.0[r][corner_c..3])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `r` is used to index `ret` [INFO] [stderr] --> src/ingredient/shape.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | for r in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 59 | for (r, ) in ret.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/ingredient/shape.rs:50:22 [INFO] [stderr] | [INFO] [stderr] 50 | for c in corner_c..3 { [INFO] [stderr] | ^^^^^^^^^^^ help: try replacing the loop by: `ret[r - corner_r][0..(3 - corner_c)].clone_from_slice(&self.0[r][corner_c..3])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `r` is used to index `ret` [INFO] [stderr] --> src/ingredient/shape.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | for r in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 59 | for (r, ) in ret.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.46s [INFO] running `"docker" "inspect" "599c2963602bb2604e9c745f5fb9c63eb48afb9da3b5c4e5b295ed7262a0f65a"` [INFO] running `"docker" "rm" "-f" "599c2963602bb2604e9c745f5fb9c63eb48afb9da3b5c4e5b295ed7262a0f65a"` [INFO] [stdout] 599c2963602bb2604e9c745f5fb9c63eb48afb9da3b5c4e5b295ed7262a0f65a