[INFO] updating cached repository ticki/damn-small-calc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ticki/damn-small-calc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ticki/damn-small-calc" "work/ex/clippy-test-run/sources/stable/gh/ticki/damn-small-calc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ticki/damn-small-calc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ticki/damn-small-calc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ticki/damn-small-calc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ticki/damn-small-calc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bae431059bdcc1411d41ecac5b141b212410d3e2 [INFO] sha for GitHub repo ticki/damn-small-calc: bae431059bdcc1411d41ecac5b141b212410d3e2 [INFO] validating manifest of ticki/damn-small-calc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ticki/damn-small-calc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ticki/damn-small-calc [INFO] finished frobbing ticki/damn-small-calc [INFO] frobbed toml for ticki/damn-small-calc written to work/ex/clippy-test-run/sources/stable/gh/ticki/damn-small-calc/Cargo.toml [INFO] started frobbing ticki/damn-small-calc [INFO] finished frobbing ticki/damn-small-calc [INFO] frobbed toml for ticki/damn-small-calc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ticki/damn-small-calc/Cargo.toml [INFO] crate ticki/damn-small-calc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ticki/damn-small-calc against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ticki/damn-small-calc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0d91082a60a9c5237998290de622fa2f96a8344ae8dc199910b71fef30f7d6fc [INFO] running `"docker" "start" "-a" "0d91082a60a9c5237998290de622fa2f96a8344ae8dc199910b71fef30f7d6fc"` [INFO] [stderr] Checking damn-small-calc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / io::stdin().read_line(&mut input).ok() [INFO] [stderr] 15 | | .expect("Couldn't read."); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | register[0] = register[0] + register[1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `register[0] += register[1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:71:21 [INFO] [stderr] | [INFO] [stderr] 71 | register[0] = register[0] - register[1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `register[0] -= register[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:76:21 [INFO] [stderr] | [INFO] [stderr] 76 | register[0] = register[0] * register[1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `register[0] *= register[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | / match ptr { [INFO] [stderr] 105 | | true => 0, [INFO] [stderr] 106 | | false => 1, [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if ptr { 0 } else { 1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / io::stdin().read_line(&mut input).ok() [INFO] [stderr] 15 | | .expect("Couldn't read."); [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | register[0] = register[0] + register[1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `register[0] += register[1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:71:21 [INFO] [stderr] | [INFO] [stderr] 71 | register[0] = register[0] - register[1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `register[0] -= register[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:76:21 [INFO] [stderr] | [INFO] [stderr] 76 | register[0] = register[0] * register[1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `register[0] *= register[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | / match ptr { [INFO] [stderr] 105 | | true => 0, [INFO] [stderr] 106 | | false => 1, [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if ptr { 0 } else { 1 }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.47s [INFO] running `"docker" "inspect" "0d91082a60a9c5237998290de622fa2f96a8344ae8dc199910b71fef30f7d6fc"` [INFO] running `"docker" "rm" "-f" "0d91082a60a9c5237998290de622fa2f96a8344ae8dc199910b71fef30f7d6fc"` [INFO] [stdout] 0d91082a60a9c5237998290de622fa2f96a8344ae8dc199910b71fef30f7d6fc