[INFO] updating cached repository thelink2012/tupi
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/thelink2012/tupi
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/thelink2012/tupi" "work/ex/clippy-test-run/sources/stable/gh/thelink2012/tupi"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/thelink2012/tupi'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/thelink2012/tupi" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/thelink2012/tupi"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/thelink2012/tupi'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 390b67fcc04324d98156223e0b391f6c8436f6ed
[INFO] sha for GitHub repo thelink2012/tupi: 390b67fcc04324d98156223e0b391f6c8436f6ed
[INFO] validating manifest of thelink2012/tupi on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of thelink2012/tupi on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing thelink2012/tupi
[INFO] finished frobbing thelink2012/tupi
[INFO] frobbed toml for thelink2012/tupi written to work/ex/clippy-test-run/sources/stable/gh/thelink2012/tupi/Cargo.toml
[INFO] started frobbing thelink2012/tupi
[INFO] finished frobbing thelink2012/tupi
[INFO] frobbed toml for thelink2012/tupi written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/thelink2012/tupi/Cargo.toml
[INFO] crate thelink2012/tupi has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting thelink2012/tupi against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/thelink2012/tupi:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 75ba1de93157b1fb7b966183334309635d26a45d946e13fc4a7ff97467561907
[INFO] running `"docker" "start" "-a" "75ba1de93157b1fb7b966183334309635d26a45d946e13fc4a7ff97467561907"`
[INFO] [stderr]     Checking libc v0.2.33
[INFO] [stderr]     Checking tupi v0.1.0 (/opt/crater/workdir)
[INFO] [stderr]     Checking thread_local v0.3.4
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/http.rs:91:17
[INFO] [stderr]    |
[INFO] [stderr] 91 |                 write!(f, "{} {} {}\n", status, message, boxed.as_ref())
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/http.rs:93:50
[INFO] [stderr]    |
[INFO] [stderr] 93 |             HttpError::BadRequest(ref detail) => write!(f, "{} {} {}\n", status, message, detail),
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/http.rs:94:18
[INFO] [stderr]    |
[INFO] [stderr] 94 |             _ => write!(f, "{} {}\n", status, message),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:115:13
[INFO] [stderr]     |
[INFO] [stderr] 115 |             httpver: httpver,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `httpver`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:131:5
[INFO] [stderr]     |
[INFO] [stderr] 131 | /     write!(
[INFO] [stderr] 132 | |         writer,
[INFO] [stderr] 133 | |         "HTTP/{}.{} {} TODO\r\n",
[INFO] [stderr] 134 | |         start_line.httpver.0,
[INFO] [stderr] 135 | |         start_line.httpver.1,
[INFO] [stderr] 136 | |         start_line.status
[INFO] [stderr] 137 | |     )?;
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:138:5
[INFO] [stderr]     |
[INFO] [stderr] 138 | /     write!(
[INFO] [stderr] 139 | |         writer,
[INFO] [stderr] 140 | |         "Content-Length: {}\r\n",
[INFO] [stderr] 141 | |         str::from_utf8(&response.headers.get("Content-Length").unwrap()).unwrap()
[INFO] [stderr] 142 | |     )?;
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:143:5
[INFO] [stderr]     |
[INFO] [stderr] 143 |     write!(writer, "\r\n")?;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:160:17
[INFO] [stderr]     |
[INFO] [stderr] 160 |                 httpver: httpver,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^ help: replace it with: `httpver`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `reader`
[INFO] [stderr]    --> src/lib.rs:104:5
[INFO] [stderr]     |
[INFO] [stderr] 104 |     reader: &mut R,
[INFO] [stderr]     |     ^^^^^^ help: consider using `_reader` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `writer`
[INFO] [stderr]    --> src/lib.rs:105:5
[INFO] [stderr]     |
[INFO] [stderr] 105 |     writer: &mut W,
[INFO] [stderr]     |     ^^^^^^ help: consider using `_writer` instead
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/parser.rs:30:39
[INFO] [stderr]    |
[INFO] [stderr] 30 | pub fn parse_request_line<R: BufRead>(mut reader: &mut R) -> HttpResult<HttpRequestLine> {
[INFO] [stderr]    |                                       ----^^^^^^
[INFO] [stderr]    |                                       |
[INFO] [stderr]    |                                       help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `query_raw`
[INFO] [stderr]   --> src/http.rs:56:5
[INFO] [stderr]    |
[INFO] [stderr] 56 |     fn query_raw(&self, key: &str) -> Option<&[u8]> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `headers`
[INFO] [stderr]   --> src/lib.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 |     headers: HttpHeaders,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/parser.rs:124:12
[INFO] [stderr]     |
[INFO] [stderr] 124 |         if line.len() > 0 && (line[0] == b' ' || line[0] == b'\t') {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/parser.rs:227:44
[INFO] [stderr]     |
[INFO] [stderr] 227 |         (Some(begin), Some(end)) => &slice[begin..end + 1],
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^ help: use: `begin..=end`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `speak_http` doesn't need a mutable reference
[INFO] [stderr]   --> src/lib.rs:45:16
[INFO] [stderr]    |
[INFO] [stderr] 45 |     speak_http(&mut stream)?;
[INFO] [stderr]    |                ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/lib.rs:98:18
[INFO] [stderr]    |
[INFO] [stderr] 98 |         .map_err(|err| Box::<Error>::from(err)) // still could not reply a error page
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Box::<Error>::from`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:155:10
[INFO] [stderr]     |
[INFO] [stderr] 155 |         .unwrap_or(http_version());
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| http_version())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:178:5
[INFO] [stderr]     |
[INFO] [stderr] 178 | /     match ver {
[INFO] [stderr] 179 | |         Some(ver) => {
[INFO] [stderr] 180 | |             // We are not ready yet to support HTTP/0.9.
[INFO] [stderr] 181 | |             if ver.0 < 1 {
[INFO] [stderr] ...   |
[INFO] [stderr] 190 | |         None => (),
[INFO] [stderr] 191 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 178 |     if let Some(ver) = ver {
[INFO] [stderr] 179 |     // We are not ready yet to support HTTP/0.9.
[INFO] [stderr] 180 |     if ver.0 < 1 {
[INFO] [stderr] 181 |         return Err(HttpError::HttpVersionNotSupported);
[INFO] [stderr] 182 |     }
[INFO] [stderr] 183 | 
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:9:9
[INFO] [stderr]    |
[INFO] [stderr] 9  | /         match stream {
[INFO] [stderr] 10 | |             Ok(stream) => {
[INFO] [stderr] 11 | |                 // TODO pooling, green threads, or something alike.
[INFO] [stderr] 12 | |                 // TODO handle unwrap
[INFO] [stderr] ...  |
[INFO] [stderr] 17 | |             }
[INFO] [stderr] 18 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 9  |         if let Ok(stream) = stream {
[INFO] [stderr] 10 |     // TODO pooling, green threads, or something alike.
[INFO] [stderr] 11 |     // TODO handle unwrap
[INFO] [stderr] 12 |     thread::spawn(move || tupi::handle_connection(stream).unwrap());
[INFO] [stderr] 13 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Checking memchr v1.0.2
[INFO] [stderr]     Checking aho-corasick v0.6.3
[INFO] [stderr]     Checking regex v0.2.2
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> tests/test.rs:128:9
[INFO] [stderr]     |
[INFO] [stderr] 128 |         status: status,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: replace it with: `status`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> tests/test.rs:130:9
[INFO] [stderr]     |
[INFO] [stderr] 130 |         message: message,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^ help: replace it with: `message`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> tests/test.rs:131:9
[INFO] [stderr]     |
[INFO] [stderr] 131 |         pos_body: pos_body,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `pos_body`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> tests/test.rs:128:9
[INFO] [stderr]     |
[INFO] [stderr] 128 |         status: status,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: replace it with: `status`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> tests/test.rs:130:9
[INFO] [stderr]     |
[INFO] [stderr] 130 |         message: message,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^ help: replace it with: `message`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> tests/test.rs:131:9
[INFO] [stderr]     |
[INFO] [stderr] 131 |         pos_body: pos_body,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `pos_body`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/http.rs:91:17
[INFO] [stderr]    |
[INFO] [stderr] 91 |                 write!(f, "{} {} {}\n", status, message, boxed.as_ref())
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/http.rs:93:50
[INFO] [stderr]    |
[INFO] [stderr] 93 |             HttpError::BadRequest(ref detail) => write!(f, "{} {} {}\n", status, message, detail),
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/http.rs:94:18
[INFO] [stderr]    |
[INFO] [stderr] 94 |             _ => write!(f, "{} {}\n", status, message),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:115:13
[INFO] [stderr]     |
[INFO] [stderr] 115 |             httpver: httpver,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `httpver`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:131:5
[INFO] [stderr]     |
[INFO] [stderr] 131 | /     write!(
[INFO] [stderr] 132 | |         writer,
[INFO] [stderr] 133 | |         "HTTP/{}.{} {} TODO\r\n",
[INFO] [stderr] 134 | |         start_line.httpver.0,
[INFO] [stderr] 135 | |         start_line.httpver.1,
[INFO] [stderr] 136 | |         start_line.status
[INFO] [stderr] 137 | |     )?;
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:138:5
[INFO] [stderr]     |
[INFO] [stderr] 138 | /     write!(
[INFO] [stderr] 139 | |         writer,
[INFO] [stderr] 140 | |         "Content-Length: {}\r\n",
[INFO] [stderr] 141 | |         str::from_utf8(&response.headers.get("Content-Length").unwrap()).unwrap()
[INFO] [stderr] 142 | |     )?;
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/lib.rs:143:5
[INFO] [stderr]     |
[INFO] [stderr] 143 |     write!(writer, "\r\n")?;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:160:17
[INFO] [stderr]     |
[INFO] [stderr] 160 |                 httpver: httpver,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^ help: replace it with: `httpver`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> tests/test.rs:128:9
[INFO] [stderr]     |
[INFO] [stderr] 128 |         status: status,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: replace it with: `status`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> tests/test.rs:130:9
[INFO] [stderr]     |
[INFO] [stderr] 130 |         message: message,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^ help: replace it with: `message`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> tests/test.rs:131:9
[INFO] [stderr]     |
[INFO] [stderr] 131 |         pos_body: pos_body,
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: replace it with: `pos_body`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]  --> tests/length.rs:7:23
[INFO] [stderr]   |
[INFO] [stderr] 7 | const BIG_SIZE: u64 = 10485760; // 10MiB
[INFO] [stderr]   |                       ^^^^^^^^ help: consider: `10_485_760`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `for` head expression
[INFO] [stderr]    --> tests/length.rs:102:18
[INFO] [stderr]     |
[INFO] [stderr] 102 |         for _ in (1..3000) {
[INFO] [stderr]     |                  ^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> tests/test.rs:47:9
[INFO] [stderr]    |
[INFO] [stderr] 47 |     let mut payload = {
[INFO] [stderr]    |         ----^^^^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this call to `as_ref` does nothing
[INFO] [stderr]   --> tests/test.rs:88:41
[INFO] [stderr]    |
[INFO] [stderr] 88 |         let mut reader = BufReader::new(mut_slice.as_ref());
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^ help: try this: `mut_slice`
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/main.rs:9:9
[INFO] [stderr]    |
[INFO] [stderr] 9  | /         match stream {
[INFO] [stderr] 10 | |             Ok(stream) => {
[INFO] [stderr] 11 | |                 // TODO pooling, green threads, or something alike.
[INFO] [stderr] 12 | |                 // TODO handle unwrap
[INFO] [stderr] ...  |
[INFO] [stderr] 17 | |             }
[INFO] [stderr] 18 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 9  |         if let Ok(stream) = stream {
[INFO] [stderr] 10 |     // TODO pooling, green threads, or something alike.
[INFO] [stderr] 11 |     // TODO handle unwrap
[INFO] [stderr] 12 |     thread::spawn(move || tupi::handle_connection(stream).unwrap());
[INFO] [stderr] 13 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_asref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
[INFO] [stderr] 
[INFO] [stderr] warning: this call to `as_ref` does nothing
[INFO] [stderr]    --> tests/length.rs:99:25
[INFO] [stderr]     |
[INFO] [stderr] 99  |       resp = request(&mut {
[INFO] [stderr]     |  _________________________^
[INFO] [stderr] 100 | |         let mut v = Vec::with_capacity(2000);
[INFO] [stderr] 101 | |         v.extend_from_slice(b"GET /test.txt HTTP/1.1\r\n");
[INFO] [stderr] 102 | |         for _ in (1..3000) {
[INFO] [stderr] ...   |
[INFO] [stderr] 108 | |     }.as_slice()
[INFO] [stderr] 109 | |         .as_ref()).unwrap();
[INFO] [stderr]     | |_________________^
[INFO] [stderr] warning: unused import: `std::io::BufRead`
[INFO] [stderr]  --> tests/version.rs:4:5
[INFO] [stderr]   |
[INFO] [stderr] 4 | use std::io::BufRead;
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 99  |     resp = request(&mut {
[INFO] [stderr] 100 |         let mut v = Vec::with_capacity(2000);
[INFO] [stderr] 101 |         v.extend_from_slice(b"GET /test.txt HTTP/1.1\r\n");
[INFO] [stderr] 102 |         for _ in (1..3000) {
[INFO] [stderr] 103 |             v.extend_from_slice(&[b'a'; 1000]);
[INFO] [stderr] 104 |             v.extend_from_slice(b": value\r\n");
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> tests/test.rs:47:9
[INFO] [stderr]    |
[INFO] [stderr] 47 |     let mut payload = {
[INFO] [stderr]    |         ----^^^^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this call to `as_ref` does nothing
[INFO] [stderr]   --> tests/test.rs:88:41
[INFO] [stderr]    |
[INFO] [stderr] 88 |         let mut reader = BufReader::new(mut_slice.as_ref());
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^ help: try this: `mut_slice`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_asref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> tests/test.rs:47:9
[INFO] [stderr]    |
[INFO] [stderr] 47 |     let mut payload = {
[INFO] [stderr]    |         ----^^^^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this call to `as_ref` does nothing
[INFO] [stderr]   --> tests/test.rs:88:41
[INFO] [stderr]    |
[INFO] [stderr] 88 |         let mut reader = BufReader::new(mut_slice.as_ref());
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^^^^^ help: try this: `mut_slice`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_asref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `reader`
[INFO] [stderr]    --> src/lib.rs:104:5
[INFO] [stderr]     |
[INFO] [stderr] 104 |     reader: &mut R,
[INFO] [stderr]     |     ^^^^^^ help: consider using `_reader` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `writer`
[INFO] [stderr]    --> src/lib.rs:105:5
[INFO] [stderr]     |
[INFO] [stderr] 105 |     writer: &mut W,
[INFO] [stderr]     |     ^^^^^^ help: consider using `_writer` instead
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/parser.rs:30:39
[INFO] [stderr]    |
[INFO] [stderr] 30 | pub fn parse_request_line<R: BufRead>(mut reader: &mut R) -> HttpResult<HttpRequestLine> {
[INFO] [stderr]    |                                       ----^^^^^^
[INFO] [stderr]    |                                       |
[INFO] [stderr]    |                                       help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `query_raw`
[INFO] [stderr]   --> src/http.rs:56:5
[INFO] [stderr]    |
[INFO] [stderr] 56 |     fn query_raw(&self, key: &str) -> Option<&[u8]> {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `headers`
[INFO] [stderr]   --> src/lib.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 |     headers: HttpHeaders,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/parser.rs:124:12
[INFO] [stderr]     |
[INFO] [stderr] 124 |         if line.len() > 0 && (line[0] == b' ' || line[0] == b'\t') {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!line.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/parser.rs:227:44
[INFO] [stderr]     |
[INFO] [stderr] 227 |         (Some(begin), Some(end)) => &slice[begin..end + 1],
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^ help: use: `begin..=end`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `speak_http` doesn't need a mutable reference
[INFO] [stderr]   --> src/lib.rs:45:16
[INFO] [stderr]    |
[INFO] [stderr] 45 |     speak_http(&mut stream)?;
[INFO] [stderr]    |                ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/lib.rs:98:18
[INFO] [stderr]    |
[INFO] [stderr] 98 |         .map_err(|err| Box::<Error>::from(err)) // still could not reply a error page
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Box::<Error>::from`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:155:10
[INFO] [stderr]     |
[INFO] [stderr] 155 |         .unwrap_or(http_version());
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| http_version())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:178:5
[INFO] [stderr]     |
[INFO] [stderr] 178 | /     match ver {
[INFO] [stderr] 179 | |         Some(ver) => {
[INFO] [stderr] 180 | |             // We are not ready yet to support HTTP/0.9.
[INFO] [stderr] 181 | |             if ver.0 < 1 {
[INFO] [stderr] ...   |
[INFO] [stderr] 190 | |         None => (),
[INFO] [stderr] 191 | |     };
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 178 |     if let Some(ver) = ver {
[INFO] [stderr] 179 |     // We are not ready yet to support HTTP/0.9.
[INFO] [stderr] 180 |     if ver.0 < 1 {
[INFO] [stderr] 181 |         return Err(HttpError::HttpVersionNotSupported);
[INFO] [stderr] 182 |     }
[INFO] [stderr] 183 | 
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 7.04s
[INFO] running `"docker" "inspect" "75ba1de93157b1fb7b966183334309635d26a45d946e13fc4a7ff97467561907"`
[INFO] running `"docker" "rm" "-f" "75ba1de93157b1fb7b966183334309635d26a45d946e13fc4a7ff97467561907"`
[INFO] [stdout] 75ba1de93157b1fb7b966183334309635d26a45d946e13fc4a7ff97467561907