[INFO] updating cached repository theboginator/drink-bleach [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/theboginator/drink-bleach [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/theboginator/drink-bleach" "work/ex/clippy-test-run/sources/stable/gh/theboginator/drink-bleach"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/theboginator/drink-bleach'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/theboginator/drink-bleach" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/theboginator/drink-bleach"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/theboginator/drink-bleach'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5a66c869b6ad6b8cf4ca4b988b7977d4dd40d561 [INFO] sha for GitHub repo theboginator/drink-bleach: 5a66c869b6ad6b8cf4ca4b988b7977d4dd40d561 [INFO] validating manifest of theboginator/drink-bleach on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of theboginator/drink-bleach on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing theboginator/drink-bleach [INFO] finished frobbing theboginator/drink-bleach [INFO] frobbed toml for theboginator/drink-bleach written to work/ex/clippy-test-run/sources/stable/gh/theboginator/drink-bleach/Cargo.toml [INFO] started frobbing theboginator/drink-bleach [INFO] finished frobbing theboginator/drink-bleach [INFO] frobbed toml for theboginator/drink-bleach written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/theboginator/drink-bleach/Cargo.toml [INFO] crate theboginator/drink-bleach has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting theboginator/drink-bleach against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/theboginator/drink-bleach:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3fe4d2a088036a5429b3a6cb008a625a1eeaf3810119ee05c72fde4b41b60cc9 [INFO] running `"docker" "start" "-a" "3fe4d2a088036a5429b3a6cb008a625a1eeaf3810119ee05c72fde4b41b60cc9"` [INFO] [stderr] Checking drinkbleach v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | return word_map; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `word_map` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | return word_map; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `word_map` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `word_map` [INFO] [stderr] --> src/main.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | fn writeResults(mut word_map: HashMap, filename: &str) { [INFO] [stderr] | ^^^^^^^^ help: consider using `_word_map` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `filename` [INFO] [stderr] --> src/main.rs:54:53 [INFO] [stderr] | [INFO] [stderr] 54 | fn writeResults(mut word_map: HashMap, filename: &str) { [INFO] [stderr] | ^^^^^^^^ help: consider using `_filename` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | let mut word_count = word_count(&contents); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | let mut word_map = word_string.split(|c: char| !c.is_alphanumeric()) [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | fn writeResults(mut word_map: HashMap, filename: &str) { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: function is never used: `writeResults` [INFO] [stderr] --> src/main.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | fn writeResults(mut word_map: HashMap, filename: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:46:28 [INFO] [stderr] | [INFO] [stderr] 46 | fn word_count(word_string: &String) -> HashMap { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: function `writeResults` should have a snake case name such as `write_results` [INFO] [stderr] --> src/main.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | / fn writeResults(mut word_map: HashMap, filename: &str) { [INFO] [stderr] 55 | | // let mut output_directory = format!("assets/indexed_text/counted_{}", filename); [INFO] [stderr] 56 | | // let mut output_file = File::create(output_directory); [INFO] [stderr] 57 | | [INFO] [stderr] ... | [INFO] [stderr] 60 | | // } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `word_map` [INFO] [stderr] --> src/main.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | fn writeResults(mut word_map: HashMap, filename: &str) { [INFO] [stderr] | ^^^^^^^^ help: consider using `_word_map` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `filename` [INFO] [stderr] --> src/main.rs:54:53 [INFO] [stderr] | [INFO] [stderr] 54 | fn writeResults(mut word_map: HashMap, filename: &str) { [INFO] [stderr] | ^^^^^^^^ help: consider using `_filename` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | let mut word_count = word_count(&contents); [INFO] [stderr] | ----^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | let mut word_map = word_string.split(|c: char| !c.is_alphanumeric()) [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/main.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | fn writeResults(mut word_map: HashMap, filename: &str) { [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: function is never used: `writeResults` [INFO] [stderr] --> src/main.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | fn writeResults(mut word_map: HashMap, filename: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:46:28 [INFO] [stderr] | [INFO] [stderr] 46 | fn word_count(word_string: &String) -> HashMap { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: function `writeResults` should have a snake case name such as `write_results` [INFO] [stderr] --> src/main.rs:54:1 [INFO] [stderr] | [INFO] [stderr] 54 | / fn writeResults(mut word_map: HashMap, filename: &str) { [INFO] [stderr] 55 | | // let mut output_directory = format!("assets/indexed_text/counted_{}", filename); [INFO] [stderr] 56 | | // let mut output_file = File::create(output_directory); [INFO] [stderr] 57 | | [INFO] [stderr] ... | [INFO] [stderr] 60 | | // } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.63s [INFO] running `"docker" "inspect" "3fe4d2a088036a5429b3a6cb008a625a1eeaf3810119ee05c72fde4b41b60cc9"` [INFO] running `"docker" "rm" "-f" "3fe4d2a088036a5429b3a6cb008a625a1eeaf3810119ee05c72fde4b41b60cc9"` [INFO] [stdout] 3fe4d2a088036a5429b3a6cb008a625a1eeaf3810119ee05c72fde4b41b60cc9