[INFO] updating cached repository theProgrammerJack/onwards [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/theProgrammerJack/onwards [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/theProgrammerJack/onwards" "work/ex/clippy-test-run/sources/stable/gh/theProgrammerJack/onwards"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/theProgrammerJack/onwards'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/theProgrammerJack/onwards" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/theProgrammerJack/onwards"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/theProgrammerJack/onwards'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 26f43c798051f79a25b8c3ab585e90ffebbbb478 [INFO] sha for GitHub repo theProgrammerJack/onwards: 26f43c798051f79a25b8c3ab585e90ffebbbb478 [INFO] validating manifest of theProgrammerJack/onwards on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of theProgrammerJack/onwards on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing theProgrammerJack/onwards [INFO] finished frobbing theProgrammerJack/onwards [INFO] frobbed toml for theProgrammerJack/onwards written to work/ex/clippy-test-run/sources/stable/gh/theProgrammerJack/onwards/Cargo.toml [INFO] started frobbing theProgrammerJack/onwards [INFO] finished frobbing theProgrammerJack/onwards [INFO] frobbed toml for theProgrammerJack/onwards written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/theProgrammerJack/onwards/Cargo.toml [INFO] crate theProgrammerJack/onwards has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting theProgrammerJack/onwards against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/theProgrammerJack/onwards:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a6538d35d6772682fe7b0d4ee5ad3bbf3d0bdfe444ae96765f4a60c52b60daa0 [INFO] running `"docker" "start" "-a" "a6538d35d6772682fe7b0d4ee5ad3bbf3d0bdfe444ae96765f4a60c52b60daa0"` [INFO] [stderr] Checking onwards v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/player.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/player.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `Wandering` [INFO] [stderr] --> src/main.rs:8:31 [INFO] [stderr] | [INFO] [stderr] 8 | use state::{Event, GameState, Wandering, Battle, Enemy}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Event` [INFO] [stderr] --> src/main.rs:8:13 [INFO] [stderr] | [INFO] [stderr] 8 | use state::{Event, GameState, Wandering, Battle, Enemy}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `trim` [INFO] [stderr] --> src/util.rs:9:6 [INFO] [stderr] | [INFO] [stderr] 9 | let trim: &[_] = &['\n', '\r']; [INFO] [stderr] | ^^^^ help: consider using `_trim` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `player` [INFO] [stderr] --> src/state/mod.rs:39:30 [INFO] [stderr] | [INFO] [stderr] 39 | fn next(self: Box, player: &mut Player, cmd: &str) -> GameState { [INFO] [stderr] | ^^^^^^ help: consider using `_player` instead [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `InventoryItem` [INFO] [stderr] --> src/item/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub enum InventoryItem { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/state/mod.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn new>(health: u32, strength: u32, name: S) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/state/mod.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | format!("Wandering help: type 'move' to move") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Wandering help: type 'move' to move".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/state/mod.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | / format!( [INFO] [stderr] 136 | | "Battle help:\n [INFO] [stderr] 137 | | attack => Perform a simple attack [INFO] [stderr] 138 | | " [INFO] [stderr] 139 | | ) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 135 | "Battle help:\n [INFO] [stderr] 136 | attack => Perform a simple attack [INFO] [stderr] 137 | ".to_string() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `Wandering` [INFO] [stderr] --> src/main.rs:8:31 [INFO] [stderr] | [INFO] [stderr] 8 | use state::{Event, GameState, Wandering, Battle, Enemy}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Event` [INFO] [stderr] --> src/main.rs:8:13 [INFO] [stderr] | [INFO] [stderr] 8 | use state::{Event, GameState, Wandering, Battle, Enemy}; [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `trim` [INFO] [stderr] --> src/util.rs:9:6 [INFO] [stderr] | [INFO] [stderr] 9 | let trim: &[_] = &['\n', '\r']; [INFO] [stderr] | ^^^^ help: consider using `_trim` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `player` [INFO] [stderr] --> src/state/mod.rs:39:30 [INFO] [stderr] | [INFO] [stderr] 39 | fn next(self: Box, player: &mut Player, cmd: &str) -> GameState { [INFO] [stderr] | ^^^^^^ help: consider using `_player` instead [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `InventoryItem` [INFO] [stderr] --> src/item/mod.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub enum InventoryItem { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/state/mod.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | pub fn new>(health: u32, strength: u32, name: S) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/state/mod.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | format!("Wandering help: type 'move' to move") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Wandering help: type 'move' to move".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/state/mod.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | / format!( [INFO] [stderr] 136 | | "Battle help:\n [INFO] [stderr] 137 | | attack => Perform a simple attack [INFO] [stderr] 138 | | " [INFO] [stderr] 139 | | ) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 135 | "Battle help:\n [INFO] [stderr] 136 | attack => Perform a simple attack [INFO] [stderr] 137 | ".to_string() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.85s [INFO] running `"docker" "inspect" "a6538d35d6772682fe7b0d4ee5ad3bbf3d0bdfe444ae96765f4a60c52b60daa0"` [INFO] running `"docker" "rm" "-f" "a6538d35d6772682fe7b0d4ee5ad3bbf3d0bdfe444ae96765f4a60c52b60daa0"` [INFO] [stdout] a6538d35d6772682fe7b0d4ee5ad3bbf3d0bdfe444ae96765f4a60c52b60daa0