[INFO] updating cached repository thbar/rust-playground [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/thbar/rust-playground [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/thbar/rust-playground" "work/ex/clippy-test-run/sources/stable/gh/thbar/rust-playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/thbar/rust-playground'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/thbar/rust-playground" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/thbar/rust-playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/thbar/rust-playground'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6d43660e5c89705273ed0cf0ddb43c431f6dfbb6 [INFO] sha for GitHub repo thbar/rust-playground: 6d43660e5c89705273ed0cf0ddb43c431f6dfbb6 [INFO] validating manifest of thbar/rust-playground on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of thbar/rust-playground on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing thbar/rust-playground [INFO] finished frobbing thbar/rust-playground [INFO] frobbed toml for thbar/rust-playground written to work/ex/clippy-test-run/sources/stable/gh/thbar/rust-playground/Cargo.toml [INFO] started frobbing thbar/rust-playground [INFO] finished frobbing thbar/rust-playground [INFO] frobbed toml for thbar/rust-playground written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/thbar/rust-playground/Cargo.toml [INFO] crate thbar/rust-playground has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting thbar/rust-playground against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/thbar/rust-playground:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7d3bf0aff87344688e3e6406a44061ed308eb09b8cd5f336114eaeedb0ec9d5e [INFO] running `"docker" "start" "-a" "7d3bf0aff87344688e3e6406a44061ed308eb09b8cd5f336114eaeedb0ec9d5e"` [INFO] [stderr] Checking rust-playground v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:110:9 [INFO] [stderr] | [INFO] [stderr] 110 | return Matrix(matrix.0, matrix.2, matrix.1, matrix.3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Matrix(matrix.0, matrix.2, matrix.1, matrix.3)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | return ((x2 - x1) * (y2 - y1)).abs(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((x2 - x1) * (y2 - y1)).abs()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | / return Rectangle { [INFO] [stderr] 195 | | // NOTE: cannot reuse "point" here apparently [INFO] [stderr] 196 | | a: Point { x: point.x, y: point.y }, [INFO] [stderr] 197 | | b: Point { x: point.x + size, y: point.y + size } [INFO] [stderr] 198 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 194 | Rectangle { [INFO] [stderr] 195 | // NOTE: cannot reuse "point" here apparently [INFO] [stderr] 196 | a: Point { x: point.x, y: point.y }, [INFO] [stderr] 197 | b: Point { x: point.x + size, y: point.y + size } [INFO] [stderr] 198 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Point` [INFO] [stderr] --> src/lib.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | struct Point { x: f32, y: f32 }; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Rectangle` [INFO] [stderr] --> src/lib.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | struct Rectangle { a: Point, b: Point }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `square` [INFO] [stderr] --> src/lib.rs:193:9 [INFO] [stderr] | [INFO] [stderr] 193 | fn square(point: Point, size: f32) -> Rectangle { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | assert_eq!(temp_x, 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | assert_eq!(temp_x, 1.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | assert_eq!(temp_y, 5.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | assert_eq!(temp_y, 5.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | / assert_eq!(50.0, rect_area( [INFO] [stderr] 181 | | Rectangle { [INFO] [stderr] 182 | | a: Point { x: 5.0, y: 0.0 }, [INFO] [stderr] 183 | | b: Point { x: 0.0, y: 10.0 } [INFO] [stderr] 184 | | } [INFO] [stderr] 185 | | )); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | / assert_eq!(50.0, rect_area( [INFO] [stderr] 181 | | Rectangle { [INFO] [stderr] 182 | | a: Point { x: 5.0, y: 0.0 }, [INFO] [stderr] 183 | | b: Point { x: 0.0, y: 10.0 } [INFO] [stderr] 184 | | } [INFO] [stderr] 185 | | )); [INFO] [stderr] | |___________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rust-playground`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7d3bf0aff87344688e3e6406a44061ed308eb09b8cd5f336114eaeedb0ec9d5e"` [INFO] running `"docker" "rm" "-f" "7d3bf0aff87344688e3e6406a44061ed308eb09b8cd5f336114eaeedb0ec9d5e"` [INFO] [stdout] 7d3bf0aff87344688e3e6406a44061ed308eb09b8cd5f336114eaeedb0ec9d5e