[INFO] updating cached repository tgandrews/xoof [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tgandrews/xoof [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tgandrews/xoof" "work/ex/clippy-test-run/sources/stable/gh/tgandrews/xoof"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tgandrews/xoof'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tgandrews/xoof" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tgandrews/xoof"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tgandrews/xoof'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1ede8d8b2b6ec556841a8ac8ca82fbfba7a772dc [INFO] sha for GitHub repo tgandrews/xoof: 1ede8d8b2b6ec556841a8ac8ca82fbfba7a772dc [INFO] validating manifest of tgandrews/xoof on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tgandrews/xoof on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tgandrews/xoof [INFO] finished frobbing tgandrews/xoof [INFO] frobbed toml for tgandrews/xoof written to work/ex/clippy-test-run/sources/stable/gh/tgandrews/xoof/Cargo.toml [INFO] started frobbing tgandrews/xoof [INFO] finished frobbing tgandrews/xoof [INFO] frobbed toml for tgandrews/xoof written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tgandrews/xoof/Cargo.toml [INFO] crate tgandrews/xoof has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tgandrews/xoof against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tgandrews/xoof:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0eaf65b9880ad68f0d5c4bd8e42200410147b62af7d58ac3ee87f83cda5e6717 [INFO] running `"docker" "start" "-a" "0eaf65b9880ad68f0d5c4bd8e42200410147b62af7d58ac3ee87f83cda5e6717"` [INFO] [stderr] Checking xoof v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dom.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | version: version [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dom.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dom.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | version: version [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dom.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dom.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | return indent + tag.as_str() + "\n" + children_output.as_str(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `indent + tag.as_str() + "\n" + children_output.as_str()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/html_parser.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return nodes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `nodes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/html_parser.rs:268:9 [INFO] [stderr] | [INFO] [stderr] 268 | return value; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/html_parser.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/html_parser.rs:299:9 [INFO] [stderr] | [INFO] [stderr] 299 | return cur_char; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cur_char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dom.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | return indent + tag.as_str() + "\n" + children_output.as_str(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `indent + tag.as_str() + "\n" + children_output.as_str()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/html_parser.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return nodes; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `nodes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/html_parser.rs:268:9 [INFO] [stderr] | [INFO] [stderr] 268 | return value; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/html_parser.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/html_parser.rs:299:9 [INFO] [stderr] | [INFO] [stderr] 299 | return cur_char; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cur_char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/html_parser_test.rs:177:5 [INFO] [stderr] | [INFO] [stderr] 177 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/html_parser_test.rs:199:5 [INFO] [stderr] | [INFO] [stderr] 199 | return paths; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `paths` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/html_parser.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / match self.consume_expected_text(" return Err(e), [INFO] [stderr] 59 | | _ => {} [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = self.consume_expected_text(" src/html_parser.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / match self.consume_expected_text(">") { [INFO] [stderr] 65 | | Err(e) => return Err(e), [INFO] [stderr] 66 | | _ => {} [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = self.consume_expected_text(">") { return Err(e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/html_parser.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / match self.consume_expected_text(" src/html_parser.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / match self.consume_expected_text("-->") { [INFO] [stderr] 90 | | Err(e) => return Err(e), [INFO] [stderr] 91 | | _ => {} [INFO] [stderr] 92 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = self.consume_expected_text("-->") { return Err(e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/html_parser.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / match self.consume_expected_text(" return Err(e), [INFO] [stderr] 99 | | _ => {} [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = self.consume_expected_text(" src/html_parser.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | / match self.consume_expected_text("]]>") { [INFO] [stderr] 115 | | Err(e) => return Err(e), [INFO] [stderr] 116 | | _ => {} [INFO] [stderr] 117 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = self.consume_expected_text("]]>") { return Err(e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/html_parser.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | / match self.consume_expected_text("<") { [INFO] [stderr] 123 | | Err(e) => return Err(e), [INFO] [stderr] 124 | | _ => {} [INFO] [stderr] 125 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = self.consume_expected_text("<") { return Err(e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/html_parser.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | / match self.consume_closing_tag(tag_name.as_str()) { [INFO] [stderr] 137 | | Err(e) => return Err(e), [INFO] [stderr] 138 | | _ => {} [INFO] [stderr] 139 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Err(e) = self.consume_closing_tag(tag_name.as_str()) { return Err(e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/html_parser.rs:155:29 [INFO] [stderr] | [INFO] [stderr] 155 | if ending.ends_with(">") { [INFO] [stderr] | ^^^ help: try using a char instead: `'>'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/html_parser.rs:207:28 [INFO] [stderr] | [INFO] [stderr] 207 | let starting_pos = self.pos.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/html_parser.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | / match self.consume_expected_text(" return Err(e), [INFO] [stderr] 210 | | _ => {} [INFO] [stderr] 211 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = self.consume_expected_text(" src/html_parser.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | / match self.consume_expected_text(">") { [INFO] [stderr] 215 | | Err(e) => return Err(e), [INFO] [stderr] 216 | | _ => {} [INFO] [stderr] 217 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = self.consume_expected_text(">") { return Err(e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/html_parser.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / match self.consume_expected_text(" return Err(e), [INFO] [stderr] 59 | | _ => {} [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = self.consume_expected_text(" src/html_parser.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | / match self.consume_expected_text(">") { [INFO] [stderr] 65 | | Err(e) => return Err(e), [INFO] [stderr] 66 | | _ => {} [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = self.consume_expected_text(">") { return Err(e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/html_parser.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | / match self.consume_expected_text(" src/html_parser.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | / match self.consume_expected_text("-->") { [INFO] [stderr] 90 | | Err(e) => return Err(e), [INFO] [stderr] 91 | | _ => {} [INFO] [stderr] 92 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = self.consume_expected_text("-->") { return Err(e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/html_parser.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | / match self.consume_expected_text(" return Err(e), [INFO] [stderr] 99 | | _ => {} [INFO] [stderr] 100 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = self.consume_expected_text(" src/html_parser.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | / match self.consume_expected_text("]]>") { [INFO] [stderr] 115 | | Err(e) => return Err(e), [INFO] [stderr] 116 | | _ => {} [INFO] [stderr] 117 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = self.consume_expected_text("]]>") { return Err(e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/html_parser.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | / match self.consume_expected_text("<") { [INFO] [stderr] 123 | | Err(e) => return Err(e), [INFO] [stderr] 124 | | _ => {} [INFO] [stderr] 125 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = self.consume_expected_text("<") { return Err(e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/html_parser.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | / match self.consume_closing_tag(tag_name.as_str()) { [INFO] [stderr] 137 | | Err(e) => return Err(e), [INFO] [stderr] 138 | | _ => {} [INFO] [stderr] 139 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Err(e) = self.consume_closing_tag(tag_name.as_str()) { return Err(e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/html_parser.rs:155:29 [INFO] [stderr] | [INFO] [stderr] 155 | if ending.ends_with(">") { [INFO] [stderr] | ^^^ help: try using a char instead: `'>'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/html_parser.rs:207:28 [INFO] [stderr] | [INFO] [stderr] 207 | let starting_pos = self.pos.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/html_parser.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | / match self.consume_expected_text(" return Err(e), [INFO] [stderr] 210 | | _ => {} [INFO] [stderr] 211 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = self.consume_expected_text(" src/html_parser.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | / match self.consume_expected_text(">") { [INFO] [stderr] 215 | | Err(e) => return Err(e), [INFO] [stderr] 216 | | _ => {} [INFO] [stderr] 217 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = self.consume_expected_text(">") { return Err(e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/html_parser_test.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | let ref first_child = node.children[0]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^-------------------- help: try: `let first_child = &node.children[0];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/html_parser_test.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / match &first_child.node_type { [INFO] [stderr] 22 | | &NodeType::Element(ref e) => assert_eq!(e.tag_name, "child"), [INFO] [stderr] 23 | | _ => assert!(false, "Wrong node type") [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 21 | match first_child.node_type { [INFO] [stderr] 22 | NodeType::Element(ref e) => assert_eq!(e.tag_name, "child"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/html_parser_test.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | let ref second_child = node.children[1]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^-------------------- help: try: `let second_child = &node.children[1];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/html_parser_test.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / match &second_child.node_type { [INFO] [stderr] 32 | | &NodeType::Element(ref e) => assert_eq!(e.tag_name, "child2"), [INFO] [stderr] 33 | | _ => assert!(false, "Wrong node type") [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 31 | match second_child.node_type { [INFO] [stderr] 32 | NodeType::Element(ref e) => assert_eq!(e.tag_name, "child2"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/html_parser_test.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | let ref first_child = node.children[0]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^-------------------- help: try: `let first_child = &node.children[0];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/html_parser_test.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / match &first_child.node_type { [INFO] [stderr] 42 | | &NodeType::Text(ref c) => assert_eq!(c, "hello world"), [INFO] [stderr] 43 | | _ => assert!(false, "Wrong node type") [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 41 | match first_child.node_type { [INFO] [stderr] 42 | NodeType::Text(ref c) => assert_eq!(c, "hello world"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/html_parser_test.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | let ref link = node.children[0]; [INFO] [stderr] | ----^^^^^^^^-------------------- help: try: `let link = &node.children[0];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/html_parser_test.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / match &link.node_type { [INFO] [stderr] 99 | | &NodeType::Element(ref e) => assert_eq!(e.tag_name, "link"), [INFO] [stderr] 100 | | _ => assert!(false, "Wrong node type") [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 98 | match link.node_type { [INFO] [stderr] 99 | NodeType::Element(ref e) => assert_eq!(e.tag_name, "link"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/html_parser_test.rs:107:9 [INFO] [stderr] | [INFO] [stderr] 107 | let ref link = node.children[0]; [INFO] [stderr] | ----^^^^^^^^-------------------- help: try: `let link = &node.children[0];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/html_parser_test.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | / match &link.node_type { [INFO] [stderr] 109 | | &NodeType::Element(ref e) => assert_eq!(e.tag_name, "meta"), [INFO] [stderr] 110 | | _ => assert!(false, "Wrong node type") [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 108 | match link.node_type { [INFO] [stderr] 109 | NodeType::Element(ref e) => assert_eq!(e.tag_name, "meta"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/html_parser_test.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | let ref child = node.children[0]; [INFO] [stderr] | ----^^^^^^^^^-------------------- help: try: `let child = &node.children[0];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/html_parser_test.rs:163:5 [INFO] [stderr] | [INFO] [stderr] 163 | / match &child.node_type { [INFO] [stderr] 164 | | &NodeType::Element(ref e) => assert_eq!(e.tag_name, "li"), [INFO] [stderr] 165 | | _ => assert!(false, "Wrong node type") [INFO] [stderr] 166 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 163 | match child.node_type { [INFO] [stderr] 164 | NodeType::Element(ref e) => assert_eq!(e.tag_name, "li"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.92s [INFO] running `"docker" "inspect" "0eaf65b9880ad68f0d5c4bd8e42200410147b62af7d58ac3ee87f83cda5e6717"` [INFO] running `"docker" "rm" "-f" "0eaf65b9880ad68f0d5c4bd8e42200410147b62af7d58ac3ee87f83cda5e6717"` [INFO] [stdout] 0eaf65b9880ad68f0d5c4bd8e42200410147b62af7d58ac3ee87f83cda5e6717