[INFO] updating cached repository terakun/spanning_tree_maze [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/terakun/spanning_tree_maze [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/terakun/spanning_tree_maze" "work/ex/clippy-test-run/sources/stable/gh/terakun/spanning_tree_maze"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/terakun/spanning_tree_maze'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/terakun/spanning_tree_maze" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/terakun/spanning_tree_maze"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/terakun/spanning_tree_maze'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7d76ea3667cf2b8d531d7634fb620d8387038961 [INFO] sha for GitHub repo terakun/spanning_tree_maze: 7d76ea3667cf2b8d531d7634fb620d8387038961 [INFO] validating manifest of terakun/spanning_tree_maze on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of terakun/spanning_tree_maze on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing terakun/spanning_tree_maze [INFO] finished frobbing terakun/spanning_tree_maze [INFO] frobbed toml for terakun/spanning_tree_maze written to work/ex/clippy-test-run/sources/stable/gh/terakun/spanning_tree_maze/Cargo.toml [INFO] started frobbing terakun/spanning_tree_maze [INFO] finished frobbing terakun/spanning_tree_maze [INFO] frobbed toml for terakun/spanning_tree_maze written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/terakun/spanning_tree_maze/Cargo.toml [INFO] crate terakun/spanning_tree_maze has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting terakun/spanning_tree_maze against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/terakun/spanning_tree_maze:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7ca164b9858828cbabfe244abb680134f8e599e434ecaaea484b4fa78c4c308e [INFO] running `"docker" "start" "-a" "7ca164b9858828cbabfe244abb680134f8e599e434ecaaea484b4fa78c4c308e"` [INFO] [stderr] Checking spanning_tree_maze v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/maze/mod.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | rows: rows, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rows` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/maze/mod.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | cols: cols, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/maze/mod.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | map: map, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/maze/mod.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/maze/mod.rs:75:13 [INFO] [stderr] | [INFO] [stderr] 75 | rows: rows, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rows` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/maze/mod.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | cols: cols, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/maze/mod.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | map: map, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/maze/mod.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/maze/mod.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | *pass = *pass | d as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*pass |= d as usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/maze/mod.rs:30:49 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn new(rows: usize, cols: usize, edges: &Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Edge]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `map`. [INFO] [stderr] --> src/maze/mod.rs:48:18 [INFO] [stderr] | [INFO] [stderr] 48 | for i in 0..rows * 2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 48 | for in map.iter_mut().take(rows * 2 + 1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/maze/mod.rs:48:18 [INFO] [stderr] | [INFO] [stderr] 48 | for i in 0..rows * 2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=rows * 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/maze/mod.rs:82:18 [INFO] [stderr] | [INFO] [stderr] 82 | for r in 0..self.rows * 2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0..=self.rows * 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/maze/mod.rs:83:22 [INFO] [stderr] | [INFO] [stderr] 83 | for c in 0..self.cols * 2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0..=self.cols * 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/maze/mod.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | *pass = *pass | d as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*pass |= d as usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/maze/mod.rs:30:49 [INFO] [stderr] | [INFO] [stderr] 30 | pub fn new(rows: usize, cols: usize, edges: &Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Edge]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `map`. [INFO] [stderr] --> src/maze/mod.rs:48:18 [INFO] [stderr] | [INFO] [stderr] 48 | for i in 0..rows * 2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 48 | for in map.iter_mut().take(rows * 2 + 1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/maze/mod.rs:48:18 [INFO] [stderr] | [INFO] [stderr] 48 | for i in 0..rows * 2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=rows * 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/maze/mod.rs:82:18 [INFO] [stderr] | [INFO] [stderr] 82 | for r in 0..self.rows * 2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0..=self.rows * 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/maze/mod.rs:83:22 [INFO] [stderr] | [INFO] [stderr] 83 | for c in 0..self.cols * 2 + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `0..=self.cols * 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.74s [INFO] running `"docker" "inspect" "7ca164b9858828cbabfe244abb680134f8e599e434ecaaea484b4fa78c4c308e"` [INFO] running `"docker" "rm" "-f" "7ca164b9858828cbabfe244abb680134f8e599e434ecaaea484b4fa78c4c308e"` [INFO] [stdout] 7ca164b9858828cbabfe244abb680134f8e599e434ecaaea484b4fa78c4c308e