[INFO] updating cached repository terakun/minmips-assembler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/terakun/minmips-assembler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/terakun/minmips-assembler" "work/ex/clippy-test-run/sources/stable/gh/terakun/minmips-assembler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/terakun/minmips-assembler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/terakun/minmips-assembler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/terakun/minmips-assembler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/terakun/minmips-assembler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1ffa06cab0bf4ccaa8f4eeee198991e3e7c0813b [INFO] sha for GitHub repo terakun/minmips-assembler: 1ffa06cab0bf4ccaa8f4eeee198991e3e7c0813b [INFO] validating manifest of terakun/minmips-assembler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of terakun/minmips-assembler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing terakun/minmips-assembler [INFO] finished frobbing terakun/minmips-assembler [INFO] frobbed toml for terakun/minmips-assembler written to work/ex/clippy-test-run/sources/stable/gh/terakun/minmips-assembler/Cargo.toml [INFO] started frobbing terakun/minmips-assembler [INFO] finished frobbing terakun/minmips-assembler [INFO] frobbed toml for terakun/minmips-assembler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/terakun/minmips-assembler/Cargo.toml [INFO] crate terakun/minmips-assembler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting terakun/minmips-assembler against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/terakun/minmips-assembler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f8923ec1df2eb0084c4084be055b362b6774faac00593009181131d1716d1a45 [INFO] running `"docker" "start" "-a" "f8923ec1df2eb0084c4084be055b362b6774faac00593009181131d1716d1a45"` [INFO] [stderr] Checking minmips-assembler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | label: label, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | mnemonic: mnemonic, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mnemonic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | operands: operands, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `operands` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | label: label, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | mnemonic: mnemonic, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `mnemonic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | operands: operands, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `operands` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | fn str2instr(s: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:55:55 [INFO] [stderr] | [INFO] [stderr] 55 | let mut split_space: Vec<_> = operation_str.split(" ").filter(|&s| s != "").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:96:18 [INFO] [stderr] | [INFO] [stderr] 96 | fn str2regidx(s: &String) -> u32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | fn str2instr(s: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:220:32 [INFO] [stderr] | [INFO] [stderr] 220 | let operands = match &operands[0] { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 221 | | &Operand::Label(ref label) => { [INFO] [stderr] 222 | | if let Some(&pos) = labelmap.get(label) { [INFO] [stderr] 223 | | pos as u32 [INFO] [stderr] ... | [INFO] [stderr] 230 | | } [INFO] [stderr] 231 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 220 | let operands = match operands[0] { [INFO] [stderr] 221 | Operand::Label(ref label) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:55:55 [INFO] [stderr] | [INFO] [stderr] 55 | let mut split_space: Vec<_> = operation_str.split(" ").filter(|&s| s != "").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:96:18 [INFO] [stderr] | [INFO] [stderr] 96 | fn str2regidx(s: &String) -> u32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/main.rs:220:32 [INFO] [stderr] | [INFO] [stderr] 220 | let operands = match &operands[0] { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 221 | | &Operand::Label(ref label) => { [INFO] [stderr] 222 | | if let Some(&pos) = labelmap.get(label) { [INFO] [stderr] 223 | | pos as u32 [INFO] [stderr] ... | [INFO] [stderr] 230 | | } [INFO] [stderr] 231 | | }; [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 220 | let operands = match operands[0] { [INFO] [stderr] 221 | Operand::Label(ref label) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.80s [INFO] running `"docker" "inspect" "f8923ec1df2eb0084c4084be055b362b6774faac00593009181131d1716d1a45"` [INFO] running `"docker" "rm" "-f" "f8923ec1df2eb0084c4084be055b362b6774faac00593009181131d1716d1a45"` [INFO] [stdout] f8923ec1df2eb0084c4084be055b362b6774faac00593009181131d1716d1a45