[INFO] updating cached repository terakoya76/puresql [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/terakoya76/puresql [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/terakoya76/puresql" "work/ex/clippy-test-run/sources/stable/gh/terakoya76/puresql"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/terakoya76/puresql'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/terakoya76/puresql" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/terakoya76/puresql"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/terakoya76/puresql'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7e321e1914c41b1804f39c169dfc2a07e8c8f025 [INFO] sha for GitHub repo terakoya76/puresql: 7e321e1914c41b1804f39c169dfc2a07e8c8f025 [INFO] validating manifest of terakoya76/puresql on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of terakoya76/puresql on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing terakoya76/puresql [INFO] finished frobbing terakoya76/puresql [INFO] frobbed toml for terakoya76/puresql written to work/ex/clippy-test-run/sources/stable/gh/terakoya76/puresql/Cargo.toml [INFO] started frobbing terakoya76/puresql [INFO] finished frobbing terakoya76/puresql [INFO] frobbed toml for terakoya76/puresql written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/terakoya76/puresql/Cargo.toml [INFO] crate terakoya76/puresql has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting terakoya76/puresql against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/terakoya76/puresql:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e1ce6fb23084e6e35e18c0a55dae1020ffdb5ce443277c636b8355497824234c [INFO] running `"docker" "start" "-a" "e1ce6fb23084e6e35e18c0a55dae1020ffdb5ce443277c636b8355497824234c"` [INFO] [stderr] Checking puresql v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | Client { ctx: ctx } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ctx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | columns: columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/columns/range.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | low: low, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `low` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/columns/range.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | high: high, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `high` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tables/tuple.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | Tuple { fields: fields } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tables/table.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | columns: columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tables/table.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | pk_index: pk_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `pk_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tables/table.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | indices: indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tables/table.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | meta: meta, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tables/memory_table.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | columns: columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tables/memory_table.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | meta: meta, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/allocators/mod.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | table_id: table_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `table_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/table_scan.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | table: table, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/table_scan.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | ranges: ranges, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `ranges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/table_scan.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | meta: meta, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/memory_table_scan.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | table: table, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/memory_table_scan.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | ranges: ranges, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `ranges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/memory_table_scan.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | columns: columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/memory_table_scan.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | meta: meta, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/join.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | selectors: selectors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `selectors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/join.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | meta: meta, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/selection.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | inputs: inputs, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inputs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/selection.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | selectors: selectors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `selectors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/selector.rs:280:21 [INFO] [stderr] | [INFO] [stderr] 280 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/selector.rs:287:21 [INFO] [stderr] | [INFO] [stderr] 287 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/projection.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | inputs: inputs, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inputs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/projection.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | projectors: projectors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `projectors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/aggregation.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | group_keys: group_keys, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `group_keys` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/aggregation.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | inputs: inputs, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inputs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/aggregation.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | aggregators: aggregators, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `aggregators` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/parser.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | lexer: lexer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lexer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/parser.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/parser.rs:412:13 [INFO] [stderr] | [INFO] [stderr] 412 | targets: targets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `targets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/parser.rs:415:13 [INFO] [stderr] | [INFO] [stderr] 415 | group_by: group_by, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `group_by` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/parser.rs:416:13 [INFO] [stderr] | [INFO] [stderr] 416 | order_by: order_by, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `order_by` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/parser.rs:417:13 [INFO] [stderr] | [INFO] [stderr] 417 | limit: limit, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/parser.rs:578:21 [INFO] [stderr] | [INFO] [stderr] 578 | table_name: table_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `table_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/parser.rs:719:13 [INFO] [stderr] | [INFO] [stderr] 719 | op: op, [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/lexer.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:27:18 [INFO] [stderr] | [INFO] [stderr] 27 | Client { ctx: ctx } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ctx` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | columns: columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/columns/range.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | low: low, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `low` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/columns/range.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | high: high, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `high` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tables/tuple.rs:10:17 [INFO] [stderr] | [INFO] [stderr] 10 | Tuple { fields: fields } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tables/table.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | columns: columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tables/table.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | pk_index: pk_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `pk_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tables/table.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | indices: indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tables/table.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | meta: meta, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tables/memory_table.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | columns: columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tables/memory_table.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | meta: meta, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/allocators/mod.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | table_id: table_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `table_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/table_scan.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | table: table, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/table_scan.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | ranges: ranges, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `ranges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/table_scan.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | meta: meta, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/memory_table_scan.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | table: table, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `table` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/memory_table_scan.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | ranges: ranges, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `ranges` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/memory_table_scan.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | columns: columns, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `columns` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/memory_table_scan.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | meta: meta, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/join.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | selectors: selectors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `selectors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/join.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | meta: meta, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/selection.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | inputs: inputs, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inputs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/selection.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | selectors: selectors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `selectors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/selector.rs:280:21 [INFO] [stderr] | [INFO] [stderr] 280 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/selector.rs:287:21 [INFO] [stderr] | [INFO] [stderr] 287 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/projection.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | inputs: inputs, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inputs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/projection.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | projectors: projectors, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `projectors` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/aggregation.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | group_keys: group_keys, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `group_keys` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/aggregation.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | inputs: inputs, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inputs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/executors/aggregation.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | aggregators: aggregators, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `aggregators` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/parser.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | lexer: lexer, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `lexer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/parser.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/parser.rs:412:13 [INFO] [stderr] | [INFO] [stderr] 412 | targets: targets, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `targets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/parser.rs:415:13 [INFO] [stderr] | [INFO] [stderr] 415 | group_by: group_by, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `group_by` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/parser.rs:416:13 [INFO] [stderr] | [INFO] [stderr] 416 | order_by: order_by, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `order_by` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/parser.rs:417:13 [INFO] [stderr] | [INFO] [stderr] 417 | limit: limit, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `limit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/parser.rs:578:21 [INFO] [stderr] | [INFO] [stderr] 578 | table_name: table_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `table_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/parser.rs:719:13 [INFO] [stderr] | [INFO] [stderr] 719 | op: op, [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser/lexer.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/executors/table_scan.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | *&mut self.seek_handle = range.low.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.seek_handle` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/executors/table_scan.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | *&mut self.cursor += 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `self.cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/executors/table_scan.rs:60:21 [INFO] [stderr] | [INFO] [stderr] 60 | *&mut self.seek_handle = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.seek_handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/executors/table_scan.rs:85:17 [INFO] [stderr] | [INFO] [stderr] 85 | *&mut self.seek_handle = handle + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.seek_handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/executors/memory_table_scan.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | *&mut self.seek_handle = range.low.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.seek_handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/executors/memory_table_scan.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | *&mut self.cursor += 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `self.cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/executors/memory_table_scan.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | *&mut self.seek_handle = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.seek_handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/executors/projection.rs:59:33 [INFO] [stderr] | [INFO] [stderr] 59 | / if t.table_name.is_some() { [INFO] [stderr] 60 | | if t.table_name.unwrap() != column.table_name { [INFO] [stderr] 61 | | continue; [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 59 | if t.table_name.is_some() && t.table_name.unwrap() != column.table_name { [INFO] [stderr] 60 | continue; [INFO] [stderr] 61 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/executors/aggregation.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | / if t.table_name.is_some() { [INFO] [stderr] 45 | | if t.table_name.unwrap() != column.table_name { [INFO] [stderr] 46 | | continue; [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 44 | if t.table_name.is_some() && t.table_name.unwrap() != column.table_name { [INFO] [stderr] 45 | continue; [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/executors/aggregator.rs:94:16 [INFO] [stderr] | [INFO] [stderr] 94 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 95 | | if value.set_same_type(0) < value { [INFO] [stderr] 96 | | self.result = value; [INFO] [stderr] 97 | | } [INFO] [stderr] 98 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 94 | } else if value.set_same_type(0) < value { [INFO] [stderr] 95 | self.result = value; [INFO] [stderr] 96 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/executors/aggregator.rs:112:16 [INFO] [stderr] | [INFO] [stderr] 112 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 113 | | if value.set_same_type(0) > value { [INFO] [stderr] 114 | | self.result = value; [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 112 | } else if value.set_same_type(0) > value { [INFO] [stderr] 113 | self.result = value; [INFO] [stderr] 114 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/parser/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod parser; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/parser.rs:211:21 [INFO] [stderr] | [INFO] [stderr] 211 | None => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/parser.rs:549:18 [INFO] [stderr] | [INFO] [stderr] 549 | _ => return Err(ParseError::SystemError), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ParseError::SystemError)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser/lexer.rs:145:24 [INFO] [stderr] | [INFO] [stderr] 145 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 146 | | if let Ok(f) = n.parse::() { [INFO] [stderr] 147 | | Token::Lit(Literal::Float(f)) [INFO] [stderr] 148 | | } else { [INFO] [stderr] 149 | | Token::Unknown [INFO] [stderr] 150 | | } [INFO] [stderr] 151 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 145 | } else if let Ok(f) = n.parse::() { [INFO] [stderr] 146 | Token::Lit(Literal::Float(f)) [INFO] [stderr] 147 | } else { [INFO] [stderr] 148 | Token::Unknown [INFO] [stderr] 149 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/executors/table_scan.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | *&mut self.seek_handle = range.low.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.seek_handle` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/executors/table_scan.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | *&mut self.cursor += 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `self.cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/executors/table_scan.rs:60:21 [INFO] [stderr] | [INFO] [stderr] 60 | *&mut self.seek_handle = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.seek_handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/executors/table_scan.rs:85:17 [INFO] [stderr] | [INFO] [stderr] 85 | *&mut self.seek_handle = handle + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.seek_handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/executors/memory_table_scan.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | *&mut self.seek_handle = range.low.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.seek_handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/executors/memory_table_scan.rs:51:17 [INFO] [stderr] | [INFO] [stderr] 51 | *&mut self.cursor += 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `self.cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/executors/memory_table_scan.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | *&mut self.seek_handle = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.seek_handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/executors/projection.rs:59:33 [INFO] [stderr] | [INFO] [stderr] 59 | / if t.table_name.is_some() { [INFO] [stderr] 60 | | if t.table_name.unwrap() != column.table_name { [INFO] [stderr] 61 | | continue; [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 59 | if t.table_name.is_some() && t.table_name.unwrap() != column.table_name { [INFO] [stderr] 60 | continue; [INFO] [stderr] 61 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/executors/aggregation.rs:44:17 [INFO] [stderr] | [INFO] [stderr] 44 | / if t.table_name.is_some() { [INFO] [stderr] 45 | | if t.table_name.unwrap() != column.table_name { [INFO] [stderr] 46 | | continue; [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 44 | if t.table_name.is_some() && t.table_name.unwrap() != column.table_name { [INFO] [stderr] 45 | continue; [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/executors/aggregator.rs:94:16 [INFO] [stderr] | [INFO] [stderr] 94 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 95 | | if value.set_same_type(0) < value { [INFO] [stderr] 96 | | self.result = value; [INFO] [stderr] 97 | | } [INFO] [stderr] 98 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 94 | } else if value.set_same_type(0) < value { [INFO] [stderr] 95 | self.result = value; [INFO] [stderr] 96 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/executors/aggregator.rs:112:16 [INFO] [stderr] | [INFO] [stderr] 112 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 113 | | if value.set_same_type(0) > value { [INFO] [stderr] 114 | | self.result = value; [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 112 | } else if value.set_same_type(0) > value { [INFO] [stderr] 113 | self.result = value; [INFO] [stderr] 114 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/parser/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub mod parser; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/parser.rs:211:21 [INFO] [stderr] | [INFO] [stderr] 211 | None => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser/parser.rs:549:18 [INFO] [stderr] | [INFO] [stderr] 549 | _ => return Err(ParseError::SystemError), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ParseError::SystemError)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/parser/lexer.rs:145:24 [INFO] [stderr] | [INFO] [stderr] 145 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 146 | | if let Ok(f) = n.parse::() { [INFO] [stderr] 147 | | Token::Lit(Literal::Float(f)) [INFO] [stderr] 148 | | } else { [INFO] [stderr] 149 | | Token::Unknown [INFO] [stderr] 150 | | } [INFO] [stderr] 151 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 145 | } else if let Ok(f) = n.parse::() { [INFO] [stderr] 146 | Token::Lit(Literal::Float(f)) [INFO] [stderr] 147 | } else { [INFO] [stderr] 148 | Token::Unknown [INFO] [stderr] 149 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_next_handle` [INFO] [stderr] --> src/executors/table_scan.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | fn set_next_handle(&mut self, next_handle: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client.rs:129:25 [INFO] [stderr] | [INFO] [stderr] 129 | / match target { [INFO] [stderr] 130 | | Projectable::Aggregate(expr) => { [INFO] [stderr] 131 | | aggregators.push(try!(build_aggregator(expr))) [INFO] [stderr] 132 | | } [INFO] [stderr] 133 | | _ => (), [INFO] [stderr] 134 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 129 | if let Projectable::Aggregate(expr) = target { [INFO] [stderr] 130 | aggregators.push(try!(build_aggregator(expr))) [INFO] [stderr] 131 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/client.rs:139:24 [INFO] [stderr] | [INFO] [stderr] 139 | if aggregators.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!aggregators.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client.rs:185:25 [INFO] [stderr] | [INFO] [stderr] 185 | / match target { [INFO] [stderr] 186 | | Projectable::Aggregate(expr) => { [INFO] [stderr] 187 | | aggregators.push(try!(build_aggregator(expr))) [INFO] [stderr] 188 | | } [INFO] [stderr] 189 | | _ => (), [INFO] [stderr] 190 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 185 | if let Projectable::Aggregate(expr) = target { [INFO] [stderr] 186 | aggregators.push(try!(build_aggregator(expr))) [INFO] [stderr] 187 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/client.rs:195:24 [INFO] [stderr] | [INFO] [stderr] 195 | if aggregators.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!aggregators.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/tables/field.rs:242:39 [INFO] [stderr] | [INFO] [stderr] 242 | KIND_I64 => Self::set_i64(&self.get_i64() + &other.get_i64()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 242 | KIND_I64 => Self::set_i64(self.get_i64() + other.get_i64()), [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/tables/field.rs:243:39 [INFO] [stderr] | [INFO] [stderr] 243 | KIND_U64 => Self::set_u64(&self.get_u64() + &other.get_u64()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 243 | KIND_U64 => Self::set_u64(self.get_u64() + other.get_u64()), [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/tables/field.rs:244:39 [INFO] [stderr] | [INFO] [stderr] 244 | KIND_F64 => Self::set_f64(&self.get_f64() + &other.get_f64()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 244 | KIND_F64 => Self::set_f64(self.get_f64() + other.get_f64()), [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/tables/field.rs:262:39 [INFO] [stderr] | [INFO] [stderr] 262 | KIND_I64 => Self::set_i64(&self.get_i64() / &other.get_i64()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 262 | KIND_I64 => Self::set_i64(self.get_i64() / other.get_i64()), [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/tables/field.rs:263:39 [INFO] [stderr] | [INFO] [stderr] 263 | KIND_U64 => Self::set_u64(&self.get_u64() / &other.get_u64()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 263 | KIND_U64 => Self::set_u64(self.get_u64() / other.get_u64()), [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/tables/field.rs:264:39 [INFO] [stderr] | [INFO] [stderr] 264 | KIND_F64 => Self::set_f64(&self.get_f64() / &other.get_f64()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 264 | KIND_F64 => Self::set_f64(self.get_f64() / other.get_f64()), [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/tables/index.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | &mut self.tree.insert(internal_id, value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.tree.insert(internal_id, value);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/tables/table.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | &mut self.meta.next_record_id.increment(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.meta.next_record_id.increment();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tables/table.rs:88:40 [INFO] [stderr] | [INFO] [stderr] 88 | Some(node) => Some(node.0.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*node.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/tables/memory_table.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | &mut self.tree.insert(record_id, tuple); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.tree.insert(record_id, tuple);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/tables/memory_table.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | &mut self.meta.next_record_id.increment(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.meta.next_record_id.increment();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tables/memory_table.rs:61:32 [INFO] [stderr] | [INFO] [stderr] 61 | Some(node) => Some(node.0.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*node.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/meta/table_info.rs:21:31 [INFO] [stderr] | [INFO] [stderr] 21 | if column.name == column_name.to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `column_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/meta/table_info.rs:28:60 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn find_column_infos_by_names(&self, column_names: &Vec<&str>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/meta/table_info.rs:32:40 [INFO] [stderr] | [INFO] [stderr] 32 | if column_info.name == column_name.to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*column_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/meta/index_info.rs:27:40 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn generate_name(column_names: &Vec<&str>) -> String { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/executors/table_scan.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | columns: table.columns.iter().map(|c| c.clone()).collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `table.columns.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/executors/table_scan.rs:50:42 [INFO] [stderr] | [INFO] [stderr] 50 | *&mut self.seek_handle = range.low.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `range.low` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/executors/memory_table_scan.rs:20:36 [INFO] [stderr] | [INFO] [stderr] 20 | let columns: Vec = table.columns.iter().map(|c| c.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `table.columns.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/executors/memory_table_scan.rs:47:42 [INFO] [stderr] | [INFO] [stderr] 47 | *&mut self.seek_handle = range.low.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `range.low` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/executors/memory_table_scan.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | &mut self.set_next_handle(handle + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.set_next_handle(handle + 1);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:38:21 [INFO] [stderr] | [INFO] [stderr] 38 | let ref right_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 38 | let right_side: &Field = &(match $ expr { [INFO] [stderr] 39 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 40 | :: Err ( err ) => { [INFO] [stderr] 41 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 42 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | let ref left_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 44 | let left_side: &Field = &(match $ expr { [INFO] [stderr] 45 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 46 | :: Err ( err ) => { [INFO] [stderr] 47 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 48 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | let ref left_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 57 | let left_side: &Field = &(match $ expr { [INFO] [stderr] 58 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 59 | :: Err ( err ) => { [INFO] [stderr] 60 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 61 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:72:21 [INFO] [stderr] | [INFO] [stderr] 72 | let ref right_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 72 | let right_side: &Field = &(match $ expr { [INFO] [stderr] 73 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 74 | :: Err ( err ) => { [INFO] [stderr] 75 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 76 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | let ref left_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 78 | let left_side: &Field = &(match $ expr { [INFO] [stderr] 79 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 80 | :: Err ( err ) => { [INFO] [stderr] 81 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 82 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:91:21 [INFO] [stderr] | [INFO] [stderr] 91 | let ref left_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 91 | let left_side: &Field = &(match $ expr { [INFO] [stderr] 92 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 93 | :: Err ( err ) => { [INFO] [stderr] 94 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 95 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | let ref right_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 106 | let right_side: &Field = &(match $ expr { [INFO] [stderr] 107 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 108 | :: Err ( err ) => { [INFO] [stderr] 109 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 110 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:112:21 [INFO] [stderr] | [INFO] [stderr] 112 | let ref left_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 112 | let left_side: &Field = &(match $ expr { [INFO] [stderr] 113 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 114 | :: Err ( err ) => { [INFO] [stderr] 115 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 116 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:125:21 [INFO] [stderr] | [INFO] [stderr] 125 | let ref left_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 125 | let left_side: &Field = &(match $ expr { [INFO] [stderr] 126 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 127 | :: Err ( err ) => { [INFO] [stderr] 128 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 129 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:140:21 [INFO] [stderr] | [INFO] [stderr] 140 | let ref right_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 140 | let right_side: &Field = &(match $ expr { [INFO] [stderr] 141 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 142 | :: Err ( err ) => { [INFO] [stderr] 143 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 144 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:146:21 [INFO] [stderr] | [INFO] [stderr] 146 | let ref left_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 146 | let left_side: &Field = &(match $ expr { [INFO] [stderr] 147 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 148 | :: Err ( err ) => { [INFO] [stderr] 149 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 150 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:159:21 [INFO] [stderr] | [INFO] [stderr] 159 | let ref left_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 159 | let left_side: &Field = &(match $ expr { [INFO] [stderr] 160 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 161 | :: Err ( err ) => { [INFO] [stderr] 162 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 163 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:174:21 [INFO] [stderr] | [INFO] [stderr] 174 | let ref right_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 174 | let right_side: &Field = &(match $ expr { [INFO] [stderr] 175 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 176 | :: Err ( err ) => { [INFO] [stderr] 177 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 178 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:180:21 [INFO] [stderr] | [INFO] [stderr] 180 | let ref left_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 180 | let left_side: &Field = &(match $ expr { [INFO] [stderr] 181 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 182 | :: Err ( err ) => { [INFO] [stderr] 183 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 184 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:193:21 [INFO] [stderr] | [INFO] [stderr] 193 | let ref left_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 193 | let left_side: &Field = &(match $ expr { [INFO] [stderr] 194 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 195 | :: Err ( err ) => { [INFO] [stderr] 196 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 197 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:208:21 [INFO] [stderr] | [INFO] [stderr] 208 | let ref right_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 208 | let right_side: &Field = &(match $ expr { [INFO] [stderr] 209 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 210 | :: Err ( err ) => { [INFO] [stderr] 211 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 212 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:214:21 [INFO] [stderr] | [INFO] [stderr] 214 | let ref left_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 214 | let left_side: &Field = &(match $ expr { [INFO] [stderr] 215 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 216 | :: Err ( err ) => { [INFO] [stderr] 217 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 218 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:227:21 [INFO] [stderr] | [INFO] [stderr] 227 | let ref left_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 227 | let left_side: &Field = &(match $ expr { [INFO] [stderr] 228 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 229 | :: Err ( err ) => { [INFO] [stderr] 230 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 231 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/executors/projection.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / loop { [INFO] [stderr] 50 | | match self.inputs.next() { [INFO] [stderr] 51 | | None => return None, [INFO] [stderr] 52 | | Some(tuple) => { [INFO] [stderr] ... | [INFO] [stderr] 78 | | } [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/executors/projection.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | / match target { [INFO] [stderr] 56 | | &Projectable::Target(ref t) => for column in &self.inputs.get_columns() [INFO] [stderr] 57 | | { [INFO] [stderr] 58 | | let t: Target = t.clone(); [INFO] [stderr] ... | [INFO] [stderr] 73 | | &Projectable::Aggregate(ref _a) => (), [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 55 | match *target { [INFO] [stderr] 56 | Projectable::Target(ref t) => for column in &self.inputs.get_columns() [INFO] [stderr] 57 | { [INFO] [stderr] 58 | let t: Target = t.clone(); [INFO] [stderr] 59 | if t.table_name.is_some() { [INFO] [stderr] 60 | if t.table_name.unwrap() != column.table_name { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/executors/aggregation.rs:60:47 [INFO] [stderr] | [INFO] [stderr] 60 | let init_aggrs: Vec = self.aggregators.iter().map(|a| a.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.aggregators.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/executors/aggregation.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | / loop { [INFO] [stderr] 81 | | match self.inputs.next() { [INFO] [stderr] 82 | | None => return None, [INFO] [stderr] 83 | | Some(tuple) => { [INFO] [stderr] ... | [INFO] [stderr] 97 | | } [INFO] [stderr] 98 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/executors/aggregation.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | &mut self.upsert(grouped_keys.clone(), tuple); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.upsert(grouped_keys.clone(), tuple);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser/parser.rs:82:45 [INFO] [stderr] | [INFO] [stderr] 82 | if 0 <= length && length <= (u8::max_value() as i64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/parser/parser.rs:300:15 [INFO] [stderr] | [INFO] [stderr] 300 | while !self.validate_token(&[Token::ClPar]).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.validate_token(&[Token::ClPar]).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser/parser.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | / match try!(self.validate_token(&[Token::Comma, Token::ClPar])) { [INFO] [stderr] 304 | | Token::Comma => try!(self.bump()), [INFO] [stderr] 305 | | _ => (), [INFO] [stderr] 306 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 303 | if let Token::Comma = match $ expr { [INFO] [stderr] 304 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 305 | :: Err ( err ) => { [INFO] [stderr] 306 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 307 | $ crate :: convert :: From :: from ( err ) ) } } { try!(self.bump()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/parser/parser.rs:334:15 [INFO] [stderr] | [INFO] [stderr] 334 | while !self.validate_token(&[Token::ClPar]).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.validate_token(&[Token::ClPar]).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser/parser.rs:337:13 [INFO] [stderr] | [INFO] [stderr] 337 | / match try!(self.validate_token(&[Token::Comma, Token::ClPar])) { [INFO] [stderr] 338 | | Token::Comma => try!(self.bump()), [INFO] [stderr] 339 | | _ => (), [INFO] [stderr] 340 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 337 | if let Token::Comma = match $ expr { [INFO] [stderr] 338 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 339 | :: Err ( err ) => { [INFO] [stderr] 340 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 341 | $ crate :: convert :: From :: from ( err ) ) } } { try!(self.bump()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/parser/parser.rs:358:15 [INFO] [stderr] | [INFO] [stderr] 358 | while !self.validate_token(&[Token::ClPar]).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.validate_token(&[Token::ClPar]).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser/parser.rs:361:13 [INFO] [stderr] | [INFO] [stderr] 361 | / match try!(self.validate_token(&[Token::Comma, Token::ClPar])) { [INFO] [stderr] 362 | | Token::Comma => try!(self.bump()), [INFO] [stderr] 363 | | _ => (), [INFO] [stderr] 364 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 361 | if let Token::Comma = match $ expr { [INFO] [stderr] 362 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 363 | :: Err ( err ) => { [INFO] [stderr] 364 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 365 | $ crate :: convert :: From :: from ( err ) ) } } { try!(self.bump()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parser/parser.rs:384:9 [INFO] [stderr] | [INFO] [stderr] 384 | / let mut conditions: Option = None; [INFO] [stderr] 385 | | if self.validate_keyword(&[Keyword::Where]).is_ok() { [INFO] [stderr] 386 | | conditions = Some(try!(self.parse_conditions())); [INFO] [stderr] 387 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let conditions = if self.validate_keyword(&[Keyword::Where]).is_ok() { Some(try!(self.parse_conditions())) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parser/parser.rs:390:9 [INFO] [stderr] | [INFO] [stderr] 390 | / let mut group_by: Option> = None; [INFO] [stderr] 391 | | if self.validate_keyword(&[Keyword::Group]).is_ok() { [INFO] [stderr] 392 | | group_by = Some(try!(self.parse_groupby())); [INFO] [stderr] 393 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let group_by = if self.validate_keyword(&[Keyword::Group]).is_ok() { Some(try!(self.parse_groupby())) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parser/parser.rs:396:9 [INFO] [stderr] | [INFO] [stderr] 396 | / let mut order_by: Option = None; [INFO] [stderr] 397 | | if self.validate_keyword(&[Keyword::Order]).is_ok() { [INFO] [stderr] 398 | | try!(self.bump()); [INFO] [stderr] 399 | | try!(self.validate_keyword(&[Keyword::By])); [INFO] [stderr] 400 | | try!(self.bump()); [INFO] [stderr] 401 | | order_by = Some(try!(self.parse_orderby())); [INFO] [stderr] 402 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let order_by = if self.validate_keyword(&[Keyword::Order]).is_ok() { ..; Some(try!(self.parse_orderby())) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parser/parser.rs:405:9 [INFO] [stderr] | [INFO] [stderr] 405 | / let mut limit: Option = None; [INFO] [stderr] 406 | | if self.validate_keyword(&[Keyword::Limit]).is_ok() { [INFO] [stderr] 407 | | try!(self.bump()); [INFO] [stderr] 408 | | limit = Some(try!(self.parse_limit())); [INFO] [stderr] 409 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let limit = if self.validate_keyword(&[Keyword::Limit]).is_ok() { ..; Some(try!(self.parse_limit())) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/parser/parser.rs:423:15 [INFO] [stderr] | [INFO] [stderr] 423 | while !self.validate_keyword(&[Keyword::From]).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.validate_keyword(&[Keyword::From]).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/parser/parser.rs:588:9 [INFO] [stderr] | [INFO] [stderr] 588 | / while self.validate_keyword(&[Keyword::Join]).is_ok() [INFO] [stderr] 589 | | || self.validate_token(&[Token::Comma]).is_ok() [INFO] [stderr] 590 | | { [INFO] [stderr] 591 | | if self.validate_keyword(&[Keyword::Join]).is_ok() { [INFO] [stderr] ... | [INFO] [stderr] 605 | | } [INFO] [stderr] 606 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/parser/statement.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | DML(DML), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 7 | DML(Box), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/parser/statement.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | Select(SelectStmt), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 21 | Select(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `puresql`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: method is never used: `set_next_handle` [INFO] [stderr] --> src/executors/table_scan.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | fn set_next_handle(&mut self, next_handle: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client.rs:129:25 [INFO] [stderr] | [INFO] [stderr] 129 | / match target { [INFO] [stderr] 130 | | Projectable::Aggregate(expr) => { [INFO] [stderr] 131 | | aggregators.push(try!(build_aggregator(expr))) [INFO] [stderr] 132 | | } [INFO] [stderr] 133 | | _ => (), [INFO] [stderr] 134 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 129 | if let Projectable::Aggregate(expr) = target { [INFO] [stderr] 130 | aggregators.push(try!(build_aggregator(expr))) [INFO] [stderr] 131 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/client.rs:139:24 [INFO] [stderr] | [INFO] [stderr] 139 | if aggregators.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!aggregators.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client.rs:185:25 [INFO] [stderr] | [INFO] [stderr] 185 | / match target { [INFO] [stderr] 186 | | Projectable::Aggregate(expr) => { [INFO] [stderr] 187 | | aggregators.push(try!(build_aggregator(expr))) [INFO] [stderr] 188 | | } [INFO] [stderr] 189 | | _ => (), [INFO] [stderr] 190 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 185 | if let Projectable::Aggregate(expr) = target { [INFO] [stderr] 186 | aggregators.push(try!(build_aggregator(expr))) [INFO] [stderr] 187 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/client.rs:195:24 [INFO] [stderr] | [INFO] [stderr] 195 | if aggregators.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!aggregators.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/tables/field.rs:242:39 [INFO] [stderr] | [INFO] [stderr] 242 | KIND_I64 => Self::set_i64(&self.get_i64() + &other.get_i64()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 242 | KIND_I64 => Self::set_i64(self.get_i64() + other.get_i64()), [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/tables/field.rs:243:39 [INFO] [stderr] | [INFO] [stderr] 243 | KIND_U64 => Self::set_u64(&self.get_u64() + &other.get_u64()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 243 | KIND_U64 => Self::set_u64(self.get_u64() + other.get_u64()), [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/tables/field.rs:244:39 [INFO] [stderr] | [INFO] [stderr] 244 | KIND_F64 => Self::set_f64(&self.get_f64() + &other.get_f64()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 244 | KIND_F64 => Self::set_f64(self.get_f64() + other.get_f64()), [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/tables/field.rs:262:39 [INFO] [stderr] | [INFO] [stderr] 262 | KIND_I64 => Self::set_i64(&self.get_i64() / &other.get_i64()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 262 | KIND_I64 => Self::set_i64(self.get_i64() / other.get_i64()), [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/tables/field.rs:263:39 [INFO] [stderr] | [INFO] [stderr] 263 | KIND_U64 => Self::set_u64(&self.get_u64() / &other.get_u64()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 263 | KIND_U64 => Self::set_u64(self.get_u64() / other.get_u64()), [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/tables/field.rs:264:39 [INFO] [stderr] | [INFO] [stderr] 264 | KIND_F64 => Self::set_f64(&self.get_f64() / &other.get_f64()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 264 | KIND_F64 => Self::set_f64(self.get_f64() / other.get_f64()), [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/tables/index.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | &mut self.tree.insert(internal_id, value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.tree.insert(internal_id, value);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/tables/table.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | &mut self.meta.next_record_id.increment(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.meta.next_record_id.increment();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tables/table.rs:88:40 [INFO] [stderr] | [INFO] [stderr] 88 | Some(node) => Some(node.0.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*node.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/tables/memory_table.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | &mut self.tree.insert(record_id, tuple); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.tree.insert(record_id, tuple);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/tables/memory_table.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | &mut self.meta.next_record_id.increment(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.meta.next_record_id.increment();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tables/memory_table.rs:61:32 [INFO] [stderr] | [INFO] [stderr] 61 | Some(node) => Some(node.0.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*node.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/meta/table_info.rs:21:31 [INFO] [stderr] | [INFO] [stderr] 21 | if column.name == column_name.to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `column_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/meta/table_info.rs:28:60 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn find_column_infos_by_names(&self, column_names: &Vec<&str>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/meta/table_info.rs:32:40 [INFO] [stderr] | [INFO] [stderr] 32 | if column_info.name == column_name.to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*column_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/meta/index_info.rs:27:40 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn generate_name(column_names: &Vec<&str>) -> String { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/executors/table_scan.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | columns: table.columns.iter().map(|c| c.clone()).collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `table.columns.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/executors/table_scan.rs:50:42 [INFO] [stderr] | [INFO] [stderr] 50 | *&mut self.seek_handle = range.low.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `range.low` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/executors/memory_table_scan.rs:20:36 [INFO] [stderr] | [INFO] [stderr] 20 | let columns: Vec = table.columns.iter().map(|c| c.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `table.columns.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/executors/memory_table_scan.rs:47:42 [INFO] [stderr] | [INFO] [stderr] 47 | *&mut self.seek_handle = range.low.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `range.low` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/executors/memory_table_scan.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | &mut self.set_next_handle(handle + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.set_next_handle(handle + 1);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:38:21 [INFO] [stderr] | [INFO] [stderr] 38 | let ref right_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 38 | let right_side: &Field = &(match $ expr { [INFO] [stderr] 39 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 40 | :: Err ( err ) => { [INFO] [stderr] 41 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 42 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:44:21 [INFO] [stderr] | [INFO] [stderr] 44 | let ref left_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 44 | let left_side: &Field = &(match $ expr { [INFO] [stderr] 45 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 46 | :: Err ( err ) => { [INFO] [stderr] 47 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 48 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | let ref left_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 57 | let left_side: &Field = &(match $ expr { [INFO] [stderr] 58 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 59 | :: Err ( err ) => { [INFO] [stderr] 60 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 61 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:72:21 [INFO] [stderr] | [INFO] [stderr] 72 | let ref right_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 72 | let right_side: &Field = &(match $ expr { [INFO] [stderr] 73 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 74 | :: Err ( err ) => { [INFO] [stderr] 75 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 76 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:78:21 [INFO] [stderr] | [INFO] [stderr] 78 | let ref left_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 78 | let left_side: &Field = &(match $ expr { [INFO] [stderr] 79 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 80 | :: Err ( err ) => { [INFO] [stderr] 81 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 82 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:91:21 [INFO] [stderr] | [INFO] [stderr] 91 | let ref left_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 91 | let left_side: &Field = &(match $ expr { [INFO] [stderr] 92 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 93 | :: Err ( err ) => { [INFO] [stderr] 94 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 95 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | let ref right_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 106 | let right_side: &Field = &(match $ expr { [INFO] [stderr] 107 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 108 | :: Err ( err ) => { [INFO] [stderr] 109 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 110 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:112:21 [INFO] [stderr] | [INFO] [stderr] 112 | let ref left_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 112 | let left_side: &Field = &(match $ expr { [INFO] [stderr] 113 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 114 | :: Err ( err ) => { [INFO] [stderr] 115 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 116 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:125:21 [INFO] [stderr] | [INFO] [stderr] 125 | let ref left_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 125 | let left_side: &Field = &(match $ expr { [INFO] [stderr] 126 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 127 | :: Err ( err ) => { [INFO] [stderr] 128 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 129 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:140:21 [INFO] [stderr] | [INFO] [stderr] 140 | let ref right_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 140 | let right_side: &Field = &(match $ expr { [INFO] [stderr] 141 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 142 | :: Err ( err ) => { [INFO] [stderr] 143 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 144 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:146:21 [INFO] [stderr] | [INFO] [stderr] 146 | let ref left_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 146 | let left_side: &Field = &(match $ expr { [INFO] [stderr] 147 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 148 | :: Err ( err ) => { [INFO] [stderr] 149 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 150 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:159:21 [INFO] [stderr] | [INFO] [stderr] 159 | let ref left_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 159 | let left_side: &Field = &(match $ expr { [INFO] [stderr] 160 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 161 | :: Err ( err ) => { [INFO] [stderr] 162 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 163 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:174:21 [INFO] [stderr] | [INFO] [stderr] 174 | let ref right_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 174 | let right_side: &Field = &(match $ expr { [INFO] [stderr] 175 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 176 | :: Err ( err ) => { [INFO] [stderr] 177 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 178 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:180:21 [INFO] [stderr] | [INFO] [stderr] 180 | let ref left_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 180 | let left_side: &Field = &(match $ expr { [INFO] [stderr] 181 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 182 | :: Err ( err ) => { [INFO] [stderr] 183 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 184 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:193:21 [INFO] [stderr] | [INFO] [stderr] 193 | let ref left_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 193 | let left_side: &Field = &(match $ expr { [INFO] [stderr] 194 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 195 | :: Err ( err ) => { [INFO] [stderr] 196 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 197 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:208:21 [INFO] [stderr] | [INFO] [stderr] 208 | let ref right_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 208 | let right_side: &Field = &(match $ expr { [INFO] [stderr] 209 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 210 | :: Err ( err ) => { [INFO] [stderr] 211 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 212 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:214:21 [INFO] [stderr] | [INFO] [stderr] 214 | let ref left_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 214 | let left_side: &Field = &(match $ expr { [INFO] [stderr] 215 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 216 | :: Err ( err ) => { [INFO] [stderr] 217 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 218 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/executors/selector.rs:227:21 [INFO] [stderr] | [INFO] [stderr] 227 | let ref left_side: Field = try!(find_field( [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 227 | let left_side: &Field = &(match $ expr { [INFO] [stderr] 228 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 229 | :: Err ( err ) => { [INFO] [stderr] 230 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 231 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/executors/selector.rs:332:14 [INFO] [stderr] | [INFO] [stderr] 332 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into-iter-on-array` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/executors/projection.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / loop { [INFO] [stderr] 50 | | match self.inputs.next() { [INFO] [stderr] 51 | | None => return None, [INFO] [stderr] 52 | | Some(tuple) => { [INFO] [stderr] ... | [INFO] [stderr] 78 | | } [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/executors/projection.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | / match target { [INFO] [stderr] 56 | | &Projectable::Target(ref t) => for column in &self.inputs.get_columns() [INFO] [stderr] 57 | | { [INFO] [stderr] 58 | | let t: Target = t.clone(); [INFO] [stderr] ... | [INFO] [stderr] 73 | | &Projectable::Aggregate(ref _a) => (), [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 55 | match *target { [INFO] [stderr] 56 | Projectable::Target(ref t) => for column in &self.inputs.get_columns() [INFO] [stderr] 57 | { [INFO] [stderr] 58 | let t: Target = t.clone(); [INFO] [stderr] 59 | if t.table_name.is_some() { [INFO] [stderr] 60 | if t.table_name.unwrap() != column.table_name { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/executors/aggregation.rs:60:47 [INFO] [stderr] | [INFO] [stderr] 60 | let init_aggrs: Vec = self.aggregators.iter().map(|a| a.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.aggregators.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/executors/aggregation.rs:80:9 [INFO] [stderr] | [INFO] [stderr] 80 | / loop { [INFO] [stderr] 81 | | match self.inputs.next() { [INFO] [stderr] 82 | | None => return None, [INFO] [stderr] 83 | | Some(tuple) => { [INFO] [stderr] ... | [INFO] [stderr] 97 | | } [INFO] [stderr] 98 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/executors/aggregation.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | &mut self.upsert(grouped_keys.clone(), tuple); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.upsert(grouped_keys.clone(), tuple);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/executors/aggregator.rs:224:14 [INFO] [stderr] | [INFO] [stderr] 224 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/parser/parser.rs:82:45 [INFO] [stderr] | [INFO] [stderr] 82 | if 0 <= length && length <= (u8::max_value() as i64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(u8::max_value())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/parser/parser.rs:300:15 [INFO] [stderr] | [INFO] [stderr] 300 | while !self.validate_token(&[Token::ClPar]).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.validate_token(&[Token::ClPar]).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser/parser.rs:303:13 [INFO] [stderr] | [INFO] [stderr] 303 | / match try!(self.validate_token(&[Token::Comma, Token::ClPar])) { [INFO] [stderr] 304 | | Token::Comma => try!(self.bump()), [INFO] [stderr] 305 | | _ => (), [INFO] [stderr] 306 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 303 | if let Token::Comma = match $ expr { [INFO] [stderr] 304 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 305 | :: Err ( err ) => { [INFO] [stderr] 306 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 307 | $ crate :: convert :: From :: from ( err ) ) } } { try!(self.bump()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/parser/parser.rs:334:15 [INFO] [stderr] | [INFO] [stderr] 334 | while !self.validate_token(&[Token::ClPar]).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.validate_token(&[Token::ClPar]).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser/parser.rs:337:13 [INFO] [stderr] | [INFO] [stderr] 337 | / match try!(self.validate_token(&[Token::Comma, Token::ClPar])) { [INFO] [stderr] 338 | | Token::Comma => try!(self.bump()), [INFO] [stderr] 339 | | _ => (), [INFO] [stderr] 340 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 337 | if let Token::Comma = match $ expr { [INFO] [stderr] 338 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 339 | :: Err ( err ) => { [INFO] [stderr] 340 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 341 | $ crate :: convert :: From :: from ( err ) ) } } { try!(self.bump()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/parser/parser.rs:358:15 [INFO] [stderr] | [INFO] [stderr] 358 | while !self.validate_token(&[Token::ClPar]).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.validate_token(&[Token::ClPar]).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser/parser.rs:361:13 [INFO] [stderr] | [INFO] [stderr] 361 | / match try!(self.validate_token(&[Token::Comma, Token::ClPar])) { [INFO] [stderr] 362 | | Token::Comma => try!(self.bump()), [INFO] [stderr] 363 | | _ => (), [INFO] [stderr] 364 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 361 | if let Token::Comma = match $ expr { [INFO] [stderr] 362 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 363 | :: Err ( err ) => { [INFO] [stderr] 364 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 365 | $ crate :: convert :: From :: from ( err ) ) } } { try!(self.bump()) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parser/parser.rs:384:9 [INFO] [stderr] | [INFO] [stderr] 384 | / let mut conditions: Option = None; [INFO] [stderr] 385 | | if self.validate_keyword(&[Keyword::Where]).is_ok() { [INFO] [stderr] 386 | | conditions = Some(try!(self.parse_conditions())); [INFO] [stderr] 387 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let conditions = if self.validate_keyword(&[Keyword::Where]).is_ok() { Some(try!(self.parse_conditions())) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parser/parser.rs:390:9 [INFO] [stderr] | [INFO] [stderr] 390 | / let mut group_by: Option> = None; [INFO] [stderr] 391 | | if self.validate_keyword(&[Keyword::Group]).is_ok() { [INFO] [stderr] 392 | | group_by = Some(try!(self.parse_groupby())); [INFO] [stderr] 393 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let group_by = if self.validate_keyword(&[Keyword::Group]).is_ok() { Some(try!(self.parse_groupby())) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parser/parser.rs:396:9 [INFO] [stderr] | [INFO] [stderr] 396 | / let mut order_by: Option = None; [INFO] [stderr] 397 | | if self.validate_keyword(&[Keyword::Order]).is_ok() { [INFO] [stderr] 398 | | try!(self.bump()); [INFO] [stderr] 399 | | try!(self.validate_keyword(&[Keyword::By])); [INFO] [stderr] 400 | | try!(self.bump()); [INFO] [stderr] 401 | | order_by = Some(try!(self.parse_orderby())); [INFO] [stderr] 402 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let order_by = if self.validate_keyword(&[Keyword::Order]).is_ok() { ..; Some(try!(self.parse_orderby())) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parser/parser.rs:405:9 [INFO] [stderr] | [INFO] [stderr] 405 | / let mut limit: Option = None; [INFO] [stderr] 406 | | if self.validate_keyword(&[Keyword::Limit]).is_ok() { [INFO] [stderr] 407 | | try!(self.bump()); [INFO] [stderr] 408 | | limit = Some(try!(self.parse_limit())); [INFO] [stderr] 409 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let limit = if self.validate_keyword(&[Keyword::Limit]).is_ok() { ..; Some(try!(self.parse_limit())) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/parser/parser.rs:423:15 [INFO] [stderr] | [INFO] [stderr] 423 | while !self.validate_keyword(&[Keyword::From]).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.validate_keyword(&[Keyword::From]).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/parser/parser.rs:588:9 [INFO] [stderr] | [INFO] [stderr] 588 | / while self.validate_keyword(&[Keyword::Join]).is_ok() [INFO] [stderr] 589 | | || self.validate_token(&[Token::Comma]).is_ok() [INFO] [stderr] 590 | | { [INFO] [stderr] 591 | | if self.validate_keyword(&[Keyword::Join]).is_ok() { [INFO] [stderr] ... | [INFO] [stderr] 605 | | } [INFO] [stderr] 606 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/parser/statement.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | DML(DML), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 7 | DML(Box), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/parser/statement.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | Select(SelectStmt), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 21 | Select(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `puresql`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e1ce6fb23084e6e35e18c0a55dae1020ffdb5ce443277c636b8355497824234c"` [INFO] running `"docker" "rm" "-f" "e1ce6fb23084e6e35e18c0a55dae1020ffdb5ce443277c636b8355497824234c"` [INFO] [stdout] e1ce6fb23084e6e35e18c0a55dae1020ffdb5ce443277c636b8355497824234c