[INFO] updating cached repository teozkr/adjacent-solver [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/teozkr/adjacent-solver [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/teozkr/adjacent-solver" "work/ex/clippy-test-run/sources/stable/gh/teozkr/adjacent-solver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/teozkr/adjacent-solver'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/teozkr/adjacent-solver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/teozkr/adjacent-solver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/teozkr/adjacent-solver'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8134201c9e34a2bcee87dfb4e759653e34daaea9 [INFO] sha for GitHub repo teozkr/adjacent-solver: 8134201c9e34a2bcee87dfb4e759653e34daaea9 [INFO] validating manifest of teozkr/adjacent-solver on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of teozkr/adjacent-solver on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing teozkr/adjacent-solver [INFO] finished frobbing teozkr/adjacent-solver [INFO] frobbed toml for teozkr/adjacent-solver written to work/ex/clippy-test-run/sources/stable/gh/teozkr/adjacent-solver/Cargo.toml [INFO] started frobbing teozkr/adjacent-solver [INFO] finished frobbing teozkr/adjacent-solver [INFO] frobbed toml for teozkr/adjacent-solver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/teozkr/adjacent-solver/Cargo.toml [INFO] crate teozkr/adjacent-solver has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting teozkr/adjacent-solver against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/teozkr/adjacent-solver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 290ae3fcae2a7494dde0b91517a7c9b3bc3b53ce81ac619eca2b3e1f9c663030 [INFO] running `"docker" "start" "-a" "290ae3fcae2a7494dde0b91517a7c9b3bc3b53ce81ac619eca2b3e1f9c663030"` [INFO] [stderr] Checking adjacent-solver v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/unequal.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/unequal.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/unequal.rs:208:47 [INFO] [stderr] | [INFO] [stderr] 208 | out.push(char::from_digit(value as u32 + 1, 10).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/unequal.rs:416:21 [INFO] [stderr] | [INFO] [stderr] 416 | fn in_direction(&self, dir: Direction) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/unequal.rs:208:47 [INFO] [stderr] | [INFO] [stderr] 208 | out.push(char::from_digit(value as u32 + 1, 10).unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/unequal.rs:416:21 [INFO] [stderr] | [INFO] [stderr] 416 | fn in_direction(&self, dir: Direction) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.96s [INFO] running `"docker" "inspect" "290ae3fcae2a7494dde0b91517a7c9b3bc3b53ce81ac619eca2b3e1f9c663030"` [INFO] running `"docker" "rm" "-f" "290ae3fcae2a7494dde0b91517a7c9b3bc3b53ce81ac619eca2b3e1f9c663030"` [INFO] [stdout] 290ae3fcae2a7494dde0b91517a7c9b3bc3b53ce81ac619eca2b3e1f9c663030