[INFO] updating cached repository team-rust/sandbox [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/team-rust/sandbox [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/team-rust/sandbox" "work/ex/clippy-test-run/sources/stable/gh/team-rust/sandbox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/team-rust/sandbox'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/team-rust/sandbox" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/team-rust/sandbox"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/team-rust/sandbox'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ec6c5d072e8d7310dff598a944c7c7193b010455 [INFO] sha for GitHub repo team-rust/sandbox: ec6c5d072e8d7310dff598a944c7c7193b010455 [INFO] validating manifest of team-rust/sandbox on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of team-rust/sandbox on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing team-rust/sandbox [INFO] finished frobbing team-rust/sandbox [INFO] frobbed toml for team-rust/sandbox written to work/ex/clippy-test-run/sources/stable/gh/team-rust/sandbox/Cargo.toml [INFO] started frobbing team-rust/sandbox [INFO] finished frobbing team-rust/sandbox [INFO] frobbed toml for team-rust/sandbox written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/team-rust/sandbox/Cargo.toml [INFO] crate team-rust/sandbox has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting team-rust/sandbox against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/team-rust/sandbox:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 416e676ac01bab3f595470f18fe63342182a2e74f1cd0c68ac373a03ea5f561a [INFO] running `"docker" "start" "-a" "416e676ac01bab3f595470f18fe63342182a2e74f1cd0c68ac373a03ea5f561a"` [INFO] [stderr] Checking quicksort v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | return sorted; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `sorted` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | return sorted; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `sorted` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.64s [INFO] running `"docker" "inspect" "416e676ac01bab3f595470f18fe63342182a2e74f1cd0c68ac373a03ea5f561a"` [INFO] running `"docker" "rm" "-f" "416e676ac01bab3f595470f18fe63342182a2e74f1cd0c68ac373a03ea5f561a"` [INFO] [stdout] 416e676ac01bab3f595470f18fe63342182a2e74f1cd0c68ac373a03ea5f561a