[INFO] updating cached repository teaganrehard/pc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/teaganrehard/pc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/teaganrehard/pc" "work/ex/clippy-test-run/sources/stable/gh/teaganrehard/pc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/teaganrehard/pc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/teaganrehard/pc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/teaganrehard/pc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/teaganrehard/pc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c4ec32a7e58e1638b19c291bbd0529db8e8f9887 [INFO] sha for GitHub repo teaganrehard/pc: c4ec32a7e58e1638b19c291bbd0529db8e8f9887 [INFO] validating manifest of teaganrehard/pc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of teaganrehard/pc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing teaganrehard/pc [INFO] finished frobbing teaganrehard/pc [INFO] frobbed toml for teaganrehard/pc written to work/ex/clippy-test-run/sources/stable/gh/teaganrehard/pc/Cargo.toml [INFO] started frobbing teaganrehard/pc [INFO] finished frobbing teaganrehard/pc [INFO] frobbed toml for teaganrehard/pc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/teaganrehard/pc/Cargo.toml [INFO] crate teaganrehard/pc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting teaganrehard/pc against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/teaganrehard/pc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0065e117380c3d29ec9fc2d62cbc0bb2d352dbe1ada4d0ee355e9af4c05097ec [INFO] running `"docker" "start" "-a" "0065e117380c3d29ec9fc2d62cbc0bb2d352dbe1ada4d0ee355e9af4c05097ec"` [INFO] [stderr] Checking pc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/dec_bin.rs:52:20 [INFO] [stderr] | [INFO] [stderr] 52 | assert_eq!(0010010100100011, dec_to_bin(9507)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 52 | assert_eq!(10010100100011, dec_to_bin(9507)); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 52 | assert_eq!(0o10010100100011, dec_to_bin(9507)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dec_bin.rs:52:20 [INFO] [stderr] | [INFO] [stderr] 52 | assert_eq!(0010010100100011, dec_to_bin(9507)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0_010_010_100_100_011` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dec_bin.rs:57:20 [INFO] [stderr] | [INFO] [stderr] 57 | assert_eq!(1011011111110100, dec_to_bin(47092)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `1_011_011_111_110_100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dec_bin.rs:62:20 [INFO] [stderr] | [INFO] [stderr] 62 | assert_ne!(101010101100010011, dec_to_bin(1092)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `101_010_101_100_010_011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dec_bin.rs:67:20 [INFO] [stderr] | [INFO] [stderr] 67 | assert_ne!(1010110111010, dec_to_bin(579)); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_010_110_111_010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/dec_bin.rs:72:37 [INFO] [stderr] | [INFO] [stderr] 72 | assert_eq!(9507, bin_to_dec(0010010100100011)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 72 | assert_eq!(9507, bin_to_dec(10010100100011)); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 72 | assert_eq!(9507, bin_to_dec(0o10010100100011)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dec_bin.rs:72:37 [INFO] [stderr] | [INFO] [stderr] 72 | assert_eq!(9507, bin_to_dec(0010010100100011)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `0_010_010_100_100_011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dec_bin.rs:77:38 [INFO] [stderr] | [INFO] [stderr] 77 | assert_eq!(47092, bin_to_dec(1011011111110100)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `1_011_011_111_110_100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dec_bin.rs:82:20 [INFO] [stderr] | [INFO] [stderr] 82 | assert_ne!(769678923, bin_to_dec(10101010111)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `769_678_923` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dec_bin.rs:82:42 [INFO] [stderr] | [INFO] [stderr] 82 | assert_ne!(769678923, bin_to_dec(10101010111)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `10_101_010_111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dec_bin.rs:87:20 [INFO] [stderr] | [INFO] [stderr] 87 | assert_ne!(37696767, bin_to_dec(10100110101011)); [INFO] [stderr] | ^^^^^^^^ help: consider: `37_696_767` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dec_bin.rs:87:41 [INFO] [stderr] | [INFO] [stderr] 87 | assert_ne!(37696767, bin_to_dec(10100110101011)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `10_100_110_101_011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/dec_bin.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | input_decimal_number = input_decimal_number / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_decimal_number /= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/dec_bin.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | decimal_number = decimal_number + remainder * base; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `decimal_number += remainder * base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/dec_bin.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | input_binary_number = input_binary_number / 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_binary_number /= 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/dec_bin.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | base = base * 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `base *= 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/dec_bin.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | input_decimal_number = input_decimal_number / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_decimal_number /= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/dec_bin.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | decimal_number = decimal_number + remainder * base; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `decimal_number += remainder * base` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/dec_bin.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | input_binary_number = input_binary_number / 10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_binary_number /= 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/dec_bin.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | base = base * 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `base *= 2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.59s [INFO] running `"docker" "inspect" "0065e117380c3d29ec9fc2d62cbc0bb2d352dbe1ada4d0ee355e9af4c05097ec"` [INFO] running `"docker" "rm" "-f" "0065e117380c3d29ec9fc2d62cbc0bb2d352dbe1ada4d0ee355e9af4c05097ec"` [INFO] [stdout] 0065e117380c3d29ec9fc2d62cbc0bb2d352dbe1ada4d0ee355e9af4c05097ec