[INFO] updating cached repository teaearlgraycold/chip8
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/teaearlgraycold/chip8
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/teaearlgraycold/chip8" "work/ex/clippy-test-run/sources/stable/gh/teaearlgraycold/chip8"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/teaearlgraycold/chip8'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/teaearlgraycold/chip8" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/teaearlgraycold/chip8"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/teaearlgraycold/chip8'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] f4883b8560189f8076720af6d71c954348b9b812
[INFO] sha for GitHub repo teaearlgraycold/chip8: f4883b8560189f8076720af6d71c954348b9b812
[INFO] validating manifest of teaearlgraycold/chip8 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of teaearlgraycold/chip8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing teaearlgraycold/chip8
[INFO] finished frobbing teaearlgraycold/chip8
[INFO] frobbed toml for teaearlgraycold/chip8 written to work/ex/clippy-test-run/sources/stable/gh/teaearlgraycold/chip8/Cargo.toml
[INFO] started frobbing teaearlgraycold/chip8
[INFO] finished frobbing teaearlgraycold/chip8
[INFO] frobbed toml for teaearlgraycold/chip8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/teaearlgraycold/chip8/Cargo.toml
[INFO] crate teaearlgraycold/chip8 has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting teaearlgraycold/chip8 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/teaearlgraycold/chip8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e47c8d6d6423b780ca4be9c13259b7193873dcf3126a42f10283a457eeb85b89
[INFO] running `"docker" "start" "-a" "e47c8d6d6423b780ca4be9c13259b7193873dcf3126a42f10283a457eeb85b89"`
[INFO] [stderr]     Checking chip8 v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/chip8.rs:96:9
[INFO] [stderr]    |
[INFO] [stderr] 96 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/chip8.rs:96:9
[INFO] [stderr]    |
[INFO] [stderr] 96 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: operator precedence can trip the unwary
[INFO] [stderr]    --> src/chip8.rs:350:6
[INFO] [stderr]     |
[INFO] [stderr] 350 |     ((instr << start * 4) >> (3 - end + start) * 4)
[INFO] [stderr]     |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(instr << start * 4) >> ((3 - end + start) * 4)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::precedence)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stderr] 
[INFO] [stderr] warning: operator precedence can trip the unwary
[INFO] [stderr]    --> src/chip8.rs:350:7
[INFO] [stderr]     |
[INFO] [stderr] 350 |     ((instr << start * 4) >> (3 - end + start) * 4)
[INFO] [stderr]     |       ^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `instr << (start * 4)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stderr] 
[INFO] [stderr] warning: operator precedence can trip the unwary
[INFO] [stderr]    --> src/chip8.rs:350:6
[INFO] [stderr]     |
[INFO] [stderr] 350 |     ((instr << start * 4) >> (3 - end + start) * 4)
[INFO] [stderr]     |      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(instr << start * 4) >> ((3 - end + start) * 4)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::precedence)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stderr] 
[INFO] [stderr] warning: operator precedence can trip the unwary
[INFO] [stderr]    --> src/chip8.rs:350:7
[INFO] [stderr]     |
[INFO] [stderr] 350 |     ((instr << start * 4) >> (3 - end + start) * 4)
[INFO] [stderr]     |       ^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `instr << (start * 4)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/chip8.rs:141:20
[INFO] [stderr]     |
[INFO] [stderr] 141 |                 if !(self.sp < self.stack.len() as u8) {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.sp >= self.stack.len() as u8`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip8.rs:226:49
[INFO] [stderr]     |
[INFO] [stderr] 226 |             0xB000...0xBFFF => self.pc = addr + self.v[0x0] as u16, // JP V0
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[0x0])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/chip8.rs:241:36
[INFO] [stderr]     |
[INFO] [stderr] 241 |                     let mut line = (self.memory[addr] as u64) << (64 - 8);
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.memory[addr])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip8.rs:277:39
[INFO] [stderr]     |
[INFO] [stderr] 277 |                     0x1E => self.i += self.v[x] as u16,
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[x])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip8.rs:278:38
[INFO] [stderr]     |
[INFO] [stderr] 278 |                     0x29 => self.i = (self.v[x] * 5) as u16,
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[x] * 5)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip8.rs:313:10
[INFO] [stderr]     |
[INFO] [stderr] 313 |         ((msb as u16) << 8) | (lsb as u16)
[INFO] [stderr]     |          ^^^^^^^^^^^^ help: try: `u16::from(msb)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip8.rs:313:31
[INFO] [stderr]     |
[INFO] [stderr] 313 |         ((msb as u16) << 8) | (lsb as u16)
[INFO] [stderr]     |                               ^^^^^^^^^^^^ help: try: `u16::from(lsb)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/chip8.rs:141:20
[INFO] [stderr]     |
[INFO] [stderr] 141 |                 if !(self.sp < self.stack.len() as u8) {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.sp >= self.stack.len() as u8`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip8.rs:226:49
[INFO] [stderr]     |
[INFO] [stderr] 226 |             0xB000...0xBFFF => self.pc = addr + self.v[0x0] as u16, // JP V0
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[0x0])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/chip8.rs:241:36
[INFO] [stderr]     |
[INFO] [stderr] 241 |                     let mut line = (self.memory[addr] as u64) << (64 - 8);
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.memory[addr])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip8.rs:277:39
[INFO] [stderr]     |
[INFO] [stderr] 277 |                     0x1E => self.i += self.v[x] as u16,
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[x])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip8.rs:278:38
[INFO] [stderr]     |
[INFO] [stderr] 278 |                     0x29 => self.i = (self.v[x] * 5) as u16,
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.v[x] * 5)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip8.rs:313:10
[INFO] [stderr]     |
[INFO] [stderr] 313 |         ((msb as u16) << 8) | (lsb as u16)
[INFO] [stderr]     |          ^^^^^^^^^^^^ help: try: `u16::from(msb)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/chip8.rs:313:31
[INFO] [stderr]     |
[INFO] [stderr] 313 |         ((msb as u16) << 8) | (lsb as u16)
[INFO] [stderr]     |                               ^^^^^^^^^^^^ help: try: `u16::from(lsb)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.10s
[INFO] running `"docker" "inspect" "e47c8d6d6423b780ca4be9c13259b7193873dcf3126a42f10283a457eeb85b89"`
[INFO] running `"docker" "rm" "-f" "e47c8d6d6423b780ca4be9c13259b7193873dcf3126a42f10283a457eeb85b89"`
[INFO] [stdout] e47c8d6d6423b780ca4be9c13259b7193873dcf3126a42f10283a457eeb85b89