[INFO] updating cached repository taturou/lifegame-core [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/taturou/lifegame-core [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/taturou/lifegame-core" "work/ex/clippy-test-run/sources/stable/gh/taturou/lifegame-core"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/taturou/lifegame-core'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/taturou/lifegame-core" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/taturou/lifegame-core"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/taturou/lifegame-core'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 237ff309afd790b6ca717e8220cb3e0ffefac0b1 [INFO] sha for GitHub repo taturou/lifegame-core: 237ff309afd790b6ca717e8220cb3e0ffefac0b1 [INFO] validating manifest of taturou/lifegame-core on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of taturou/lifegame-core on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing taturou/lifegame-core [INFO] finished frobbing taturou/lifegame-core [INFO] frobbed toml for taturou/lifegame-core written to work/ex/clippy-test-run/sources/stable/gh/taturou/lifegame-core/Cargo.toml [INFO] started frobbing taturou/lifegame-core [INFO] finished frobbing taturou/lifegame-core [INFO] frobbed toml for taturou/lifegame-core written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/taturou/lifegame-core/Cargo.toml [INFO] crate taturou/lifegame-core has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting taturou/lifegame-core against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/taturou/lifegame-core:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 78d26b713457fe48a78ca79e59d4e28d97f5d0573e94dbabe623ea5703895c29 [INFO] running `"docker" "start" "-a" "78d26b713457fe48a78ca79e59d4e28d97f5d0573e94dbabe623ea5703895c29"` [INFO] [stderr] Checking lifegame v2.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lifegame.rs:226:17 [INFO] [stderr] | [INFO] [stderr] 226 | num_cells: num_cells, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_cells` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lifegame.rs:240:17 [INFO] [stderr] | [INFO] [stderr] 240 | num_cells: num_cells, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_cells` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lifegame.rs:253:17 [INFO] [stderr] | [INFO] [stderr] 253 | num_cells: num_cells, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_cells` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lifegame.rs:266:25 [INFO] [stderr] | [INFO] [stderr] 266 | live: live, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `live` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lifegame.rs:277:25 [INFO] [stderr] | [INFO] [stderr] 277 | live: live, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `live` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lifegame.rs:226:17 [INFO] [stderr] | [INFO] [stderr] 226 | num_cells: num_cells, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_cells` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lifegame.rs:240:17 [INFO] [stderr] | [INFO] [stderr] 240 | num_cells: num_cells, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_cells` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lifegame.rs:253:17 [INFO] [stderr] | [INFO] [stderr] 253 | num_cells: num_cells, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_cells` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lifegame.rs:266:25 [INFO] [stderr] | [INFO] [stderr] 266 | live: live, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `live` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lifegame.rs:277:25 [INFO] [stderr] | [INFO] [stderr] 277 | live: live, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `live` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lifegame.rs:269:9 [INFO] [stderr] | [INFO] [stderr] 269 | iter [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lifegame.rs:263:20 [INFO] [stderr] | [INFO] [stderr] 263 | let iter = LifeGameIterBool { [INFO] [stderr] | ____________________^ [INFO] [stderr] 264 | | pos: 0, [INFO] [stderr] 265 | | max: self.width() * self.height(), [INFO] [stderr] 266 | | live: live, [INFO] [stderr] 267 | | game: self [INFO] [stderr] 268 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lifegame.rs:280:9 [INFO] [stderr] | [INFO] [stderr] 280 | iter [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lifegame.rs:274:20 [INFO] [stderr] | [INFO] [stderr] 274 | let iter = LifeGameIterU8 { [INFO] [stderr] | ____________________^ [INFO] [stderr] 275 | | pos: 0, [INFO] [stderr] 276 | | max: self.width() * self.height(), [INFO] [stderr] 277 | | live: live, [INFO] [stderr] 278 | | game: self [INFO] [stderr] 279 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lifegame.rs:232:20 [INFO] [stderr] | [INFO] [stderr] 232 | let live = if live == 1 { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `live == 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lifegame.rs:269:9 [INFO] [stderr] | [INFO] [stderr] 269 | iter [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lifegame.rs:263:20 [INFO] [stderr] | [INFO] [stderr] 263 | let iter = LifeGameIterBool { [INFO] [stderr] | ____________________^ [INFO] [stderr] 264 | | pos: 0, [INFO] [stderr] 265 | | max: self.width() * self.height(), [INFO] [stderr] 266 | | live: live, [INFO] [stderr] 267 | | game: self [INFO] [stderr] 268 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lifegame.rs:280:9 [INFO] [stderr] | [INFO] [stderr] 280 | iter [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lifegame.rs:274:20 [INFO] [stderr] | [INFO] [stderr] 274 | let iter = LifeGameIterU8 { [INFO] [stderr] | ____________________^ [INFO] [stderr] 275 | | pos: 0, [INFO] [stderr] 276 | | max: self.width() * self.height(), [INFO] [stderr] 277 | | live: live, [INFO] [stderr] 278 | | game: self [INFO] [stderr] 279 | | }; [INFO] [stderr] | |_____________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lifegame.rs:232:20 [INFO] [stderr] | [INFO] [stderr] 232 | let live = if live == 1 { true } else { false }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can reduce it to: `live == 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/lifegame.rs:467:5 [INFO] [stderr] | [INFO] [stderr] 467 | / fn evolution_with_generation() { [INFO] [stderr] 468 | | /* ..... ..... [INFO] [stderr] 469 | | * ..... ..o.. [INFO] [stderr] 470 | | * .ooo. -> ..o.. [INFO] [stderr] ... | [INFO] [stderr] 508 | | assert_eq!(game.get(4, 4), false); [INFO] [stderr] 509 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.01s [INFO] running `"docker" "inspect" "78d26b713457fe48a78ca79e59d4e28d97f5d0573e94dbabe623ea5703895c29"` [INFO] running `"docker" "rm" "-f" "78d26b713457fe48a78ca79e59d4e28d97f5d0573e94dbabe623ea5703895c29"` [INFO] [stdout] 78d26b713457fe48a78ca79e59d4e28d97f5d0573e94dbabe623ea5703895c29