[INFO] updating cached repository tastytentacles/skript_kitty
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/tastytentacles/skript_kitty
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/tastytentacles/skript_kitty" "work/ex/clippy-test-run/sources/stable/gh/tastytentacles/skript_kitty"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tastytentacles/skript_kitty'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/tastytentacles/skript_kitty" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tastytentacles/skript_kitty"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tastytentacles/skript_kitty'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 445c3ac3d239363703fc4a5b101c14a965265872
[INFO] sha for GitHub repo tastytentacles/skript_kitty: 445c3ac3d239363703fc4a5b101c14a965265872
[INFO] validating manifest of tastytentacles/skript_kitty on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of tastytentacles/skript_kitty on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing tastytentacles/skript_kitty
[INFO] finished frobbing tastytentacles/skript_kitty
[INFO] frobbed toml for tastytentacles/skript_kitty written to work/ex/clippy-test-run/sources/stable/gh/tastytentacles/skript_kitty/Cargo.toml
[INFO] started frobbing tastytentacles/skript_kitty
[INFO] finished frobbing tastytentacles/skript_kitty
[INFO] frobbed toml for tastytentacles/skript_kitty written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tastytentacles/skript_kitty/Cargo.toml
[INFO] crate tastytentacles/skript_kitty has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting tastytentacles/skript_kitty against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tastytentacles/skript_kitty:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 35f7ad0f10f041f64ee49a86748dd7aab78df8174e52bd22303ab49ddc600bf2
[INFO] running `"docker" "start" "-a" "35f7ad0f10f041f64ee49a86748dd7aab78df8174e52bd22303ab49ddc600bf2"`
[INFO] [stderr]     Checking skript_kitty v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/irc_h.rs:27:2
[INFO] [stderr]    |
[INFO] [stderr] 27 |     irc_out
[INFO] [stderr]    |     ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/irc_h.rs:21:16
[INFO] [stderr]    |
[INFO] [stderr] 21 |       let irc_out = IRC {
[INFO] [stderr]    |  ___________________^
[INFO] [stderr] 22 | |         stream: tcp,
[INFO] [stderr] 23 | |         read: br,
[INFO] [stderr] 24 | |         write: bw
[INFO] [stderr] 25 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:52:3
[INFO] [stderr]    |
[INFO] [stderr] 52 |         return true;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:54:9
[INFO] [stderr]    |
[INFO] [stderr] 54 |     else { return false; }
[INFO] [stderr]    |            ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/irc_h.rs:27:2
[INFO] [stderr]    |
[INFO] [stderr] 27 |     irc_out
[INFO] [stderr]    |     ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/irc_h.rs:21:16
[INFO] [stderr]    |
[INFO] [stderr] 21 |       let irc_out = IRC {
[INFO] [stderr]    |  ___________________^
[INFO] [stderr] 22 | |         stream: tcp,
[INFO] [stderr] 23 | |         read: br,
[INFO] [stderr] 24 | |         write: bw
[INFO] [stderr] 25 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:52:3
[INFO] [stderr]    |
[INFO] [stderr] 52 |         return true;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:54:9
[INFO] [stderr]    |
[INFO] [stderr] 54 |     else { return false; }
[INFO] [stderr]    |            ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/main.rs:23:35
[INFO] [stderr]    |
[INFO] [stderr] 23 |             let _ = client.write.write_all("PONG: nope".as_bytes());
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"PONG: nope"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:46:20
[INFO] [stderr]    |
[INFO] [stderr] 46 | fn msg_contains(s: &String, t: &str) -> bool {
[INFO] [stderr]    |                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:47:36
[INFO] [stderr]    |
[INFO] [stderr] 47 |     let frac: Vec<&str> = s.splitn(4, " ").collect();
[INFO] [stderr]    |                                       ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/main.rs:50:2
[INFO] [stderr]    |
[INFO] [stderr] 50 |       if frac[1] == "PRIVMSG" &&
[INFO] [stderr]    |  _____^
[INFO] [stderr] 51 | |          String::from_utf8_lossy(frac[3].as_bytes()).contains(t){
[INFO] [stderr] 52 | |         return true;
[INFO] [stderr] 53 | |     }
[INFO] [stderr] 54 | |     else { return false; }
[INFO] [stderr]    | |__________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] help: you can reduce it to
[INFO] [stderr]    |
[INFO] [stderr] 50 |     return frac[1] == "PRIVMSG" &&
[INFO] [stderr] 51 |          String::from_utf8_lossy(frac[3].as_bytes()).contains(t)
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/main.rs:23:35
[INFO] [stderr]    |
[INFO] [stderr] 23 |             let _ = client.write.write_all("PONG: nope".as_bytes());
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"PONG: nope"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:46:20
[INFO] [stderr]    |
[INFO] [stderr] 46 | fn msg_contains(s: &String, t: &str) -> bool {
[INFO] [stderr]    |                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/main.rs:47:36
[INFO] [stderr]    |
[INFO] [stderr] 47 |     let frac: Vec<&str> = s.splitn(4, " ").collect();
[INFO] [stderr]    |                                       ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/main.rs:50:2
[INFO] [stderr]    |
[INFO] [stderr] 50 |       if frac[1] == "PRIVMSG" &&
[INFO] [stderr]    |  _____^
[INFO] [stderr] 51 | |          String::from_utf8_lossy(frac[3].as_bytes()).contains(t){
[INFO] [stderr] 52 | |         return true;
[INFO] [stderr] 53 | |     }
[INFO] [stderr] 54 | |     else { return false; }
[INFO] [stderr]    | |__________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] help: you can reduce it to
[INFO] [stderr]    |
[INFO] [stderr] 50 |     return frac[1] == "PRIVMSG" &&
[INFO] [stderr] 51 |          String::from_utf8_lossy(frac[3].as_bytes()).contains(t)
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.74s
[INFO] running `"docker" "inspect" "35f7ad0f10f041f64ee49a86748dd7aab78df8174e52bd22303ab49ddc600bf2"`
[INFO] running `"docker" "rm" "-f" "35f7ad0f10f041f64ee49a86748dd7aab78df8174e52bd22303ab49ddc600bf2"`
[INFO] [stdout] 35f7ad0f10f041f64ee49a86748dd7aab78df8174e52bd22303ab49ddc600bf2