[INFO] updating cached repository tasdomas/sc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tasdomas/sc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tasdomas/sc" "work/ex/clippy-test-run/sources/stable/gh/tasdomas/sc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tasdomas/sc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tasdomas/sc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tasdomas/sc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tasdomas/sc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9f75d0e8d5a9d2f5022be574a5e32a4888abe15e [INFO] sha for GitHub repo tasdomas/sc: 9f75d0e8d5a9d2f5022be574a5e32a4888abe15e [INFO] validating manifest of tasdomas/sc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tasdomas/sc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tasdomas/sc [INFO] finished frobbing tasdomas/sc [INFO] frobbed toml for tasdomas/sc written to work/ex/clippy-test-run/sources/stable/gh/tasdomas/sc/Cargo.toml [INFO] started frobbing tasdomas/sc [INFO] finished frobbing tasdomas/sc [INFO] frobbed toml for tasdomas/sc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tasdomas/sc/Cargo.toml [INFO] crate tasdomas/sc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tasdomas/sc against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tasdomas/sc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c08f09b76c278c4c3cf0a9fdab645886db9dd859361c519bfb00be166300a3c9 [INFO] running `"docker" "start" "-a" "c08f09b76c278c4c3cf0a9fdab645886db9dd859361c519bfb00be166300a3c9"` [INFO] [stderr] Checking sc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: value assigned to `a` is never read [INFO] [stderr] --> src/ops.rs:6:13 [INFO] [stderr] | [INFO] [stderr] 6 | let mut a :f32 = 0.0; [INFO] [stderr] | ^ [INFO] [stderr] warning: value assigned to `a` is never read [INFO] [stderr] --> src/ops.rs:6:13 [INFO] [stderr] | [INFO] [stderr] 6 | let mut a :f32 = 0.0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `b` is never read [INFO] [stderr] --> src/ops.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | let mut b :f32 = 0.0; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `b` is never read [INFO] [stderr] --> src/ops.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | let mut b :f32 = 0.0; [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: structure field `S` should have a snake case name such as `s` [INFO] [stderr] --> src/stack.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | S: Option>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: structure field `S` should have a snake case name such as `s` [INFO] [stderr] --> src/stack.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | S: Option>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `stack::Stack` [INFO] [stderr] --> src/stack.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Stack [INFO] [stderr] 17 | | where T: Clone { [INFO] [stderr] 18 | | Stack{S: None} [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `stack::Stack` [INFO] [stderr] --> src/stack.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Stack [INFO] [stderr] 17 | | where T: Clone { [INFO] [stderr] 18 | | Stack{S: None} [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/stack.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / match self { [INFO] [stderr] 52 | | &Stack{S: None} => None, [INFO] [stderr] 53 | | &Stack{S: Some(ref b)} => { [INFO] [stderr] 54 | | let v = b.value.clone(); [INFO] [stderr] 55 | | Some(v) [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 51 | match *self { [INFO] [stderr] 52 | Stack{S: None} => None, [INFO] [stderr] 53 | Stack{S: Some(ref b)} => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: function `Sum` should have a snake case name such as `sum` [INFO] [stderr] --> src/ops.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | / pub fn Sum(mut s: Stack) -> Stack { [INFO] [stderr] 6 | | let mut a :f32 = 0.0; [INFO] [stderr] 7 | | { [INFO] [stderr] 8 | | let (ss, input_a) = s.pop(); [INFO] [stderr] ... | [INFO] [stderr] 24 | | s.push(a+b) [INFO] [stderr] 25 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/stack.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / match self { [INFO] [stderr] 52 | | &Stack{S: None} => None, [INFO] [stderr] 53 | | &Stack{S: Some(ref b)} => { [INFO] [stderr] 54 | | let v = b.value.clone(); [INFO] [stderr] 55 | | Some(v) [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 51 | match *self { [INFO] [stderr] 52 | Stack{S: None} => None, [INFO] [stderr] 53 | Stack{S: Some(ref b)} => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: function `Sum` should have a snake case name such as `sum` [INFO] [stderr] --> src/ops.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | / pub fn Sum(mut s: Stack) -> Stack { [INFO] [stderr] 6 | | let mut a :f32 = 0.0; [INFO] [stderr] 7 | | { [INFO] [stderr] 8 | | let (ss, input_a) = s.pop(); [INFO] [stderr] ... | [INFO] [stderr] 24 | | s.push(a+b) [INFO] [stderr] 25 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/bin/sc.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | match input.trim().as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `input.trim()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/bin/sc.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | match input.trim().as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `input.trim()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.30s [INFO] running `"docker" "inspect" "c08f09b76c278c4c3cf0a9fdab645886db9dd859361c519bfb00be166300a3c9"` [INFO] running `"docker" "rm" "-f" "c08f09b76c278c4c3cf0a9fdab645886db9dd859361c519bfb00be166300a3c9"` [INFO] [stdout] c08f09b76c278c4c3cf0a9fdab645886db9dd859361c519bfb00be166300a3c9