[INFO] updating cached repository talklittle/ff13-2-clock-puzzle-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/talklittle/ff13-2-clock-puzzle-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/talklittle/ff13-2-clock-puzzle-rs" "work/ex/clippy-test-run/sources/stable/gh/talklittle/ff13-2-clock-puzzle-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/talklittle/ff13-2-clock-puzzle-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/talklittle/ff13-2-clock-puzzle-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/talklittle/ff13-2-clock-puzzle-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/talklittle/ff13-2-clock-puzzle-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 68cd93a587d4c98c65cb94b964b3a42cec33db24 [INFO] sha for GitHub repo talklittle/ff13-2-clock-puzzle-rs: 68cd93a587d4c98c65cb94b964b3a42cec33db24 [INFO] validating manifest of talklittle/ff13-2-clock-puzzle-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of talklittle/ff13-2-clock-puzzle-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing talklittle/ff13-2-clock-puzzle-rs [INFO] finished frobbing talklittle/ff13-2-clock-puzzle-rs [INFO] frobbed toml for talklittle/ff13-2-clock-puzzle-rs written to work/ex/clippy-test-run/sources/stable/gh/talklittle/ff13-2-clock-puzzle-rs/Cargo.toml [INFO] started frobbing talklittle/ff13-2-clock-puzzle-rs [INFO] finished frobbing talklittle/ff13-2-clock-puzzle-rs [INFO] frobbed toml for talklittle/ff13-2-clock-puzzle-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/talklittle/ff13-2-clock-puzzle-rs/Cargo.toml [INFO] crate talklittle/ff13-2-clock-puzzle-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting talklittle/ff13-2-clock-puzzle-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/talklittle/ff13-2-clock-puzzle-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3f1396415a5644a3962e9f43d681369da54234ac01b558acd9ca3b61a34a731c [INFO] running `"docker" "start" "-a" "3f1396415a5644a3962e9f43d681369da54234ac01b558acd9ca3b61a34a731c"` [INFO] [stderr] Checking ff13-2-clock-puzzle-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:36:18 [INFO] [stderr] | [INFO] [stderr] 36 | let result = brute_force(all_paths, all_origins, vec![]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:36:18 [INFO] [stderr] | [INFO] [stderr] 36 | let result = brute_force(all_paths, all_origins, vec![]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in clock_vals.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | for val in clock_vals { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in clock_vals.enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:25:16 [INFO] [stderr] | [INFO] [stderr] 25 | for val in clock_vals { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | let ref dests = remaining_paths[i as usize]; [INFO] [stderr] | ----^^^^^^^^^------------------------------- help: try: `let dests = &remaining_paths[i as usize];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | let ref dests = remaining_paths[i as usize]; [INFO] [stderr] | ----^^^^^^^^^------------------------------- help: try: `let dests = &remaining_paths[i as usize];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.61s [INFO] running `"docker" "inspect" "3f1396415a5644a3962e9f43d681369da54234ac01b558acd9ca3b61a34a731c"` [INFO] running `"docker" "rm" "-f" "3f1396415a5644a3962e9f43d681369da54234ac01b558acd9ca3b61a34a731c"` [INFO] [stdout] 3f1396415a5644a3962e9f43d681369da54234ac01b558acd9ca3b61a34a731c