[INFO] updating cached repository tak2siva/rust-sqlite [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/tak2siva/rust-sqlite [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/tak2siva/rust-sqlite" "work/ex/clippy-test-run/sources/stable/gh/tak2siva/rust-sqlite"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/tak2siva/rust-sqlite'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/tak2siva/rust-sqlite" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tak2siva/rust-sqlite"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tak2siva/rust-sqlite'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d70f2dcec299f4e3093dd5f3bbd83b85939aa828 [INFO] sha for GitHub repo tak2siva/rust-sqlite: d70f2dcec299f4e3093dd5f3bbd83b85939aa828 [INFO] validating manifest of tak2siva/rust-sqlite on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of tak2siva/rust-sqlite on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing tak2siva/rust-sqlite [INFO] finished frobbing tak2siva/rust-sqlite [INFO] frobbed toml for tak2siva/rust-sqlite written to work/ex/clippy-test-run/sources/stable/gh/tak2siva/rust-sqlite/Cargo.toml [INFO] started frobbing tak2siva/rust-sqlite [INFO] finished frobbing tak2siva/rust-sqlite [INFO] frobbed toml for tak2siva/rust-sqlite written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tak2siva/rust-sqlite/Cargo.toml [INFO] crate tak2siva/rust-sqlite has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting tak2siva/rust-sqlite against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/tak2siva/rust-sqlite:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a2c423004cd8d9eb40092efd43bc16e4defd9825a9056a9e724a2b124088ce4e [INFO] running `"docker" "start" "-a" "a2c423004cd8d9eb40092efd43bc16e4defd9825a9056a9e724a2b124088ce4e"` [INFO] [stderr] Checking sqlite v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/meta_command.rs:15:4 [INFO] [stderr] | [INFO] [stderr] 15 | return MetaCommandResult::META_COMMAND_UNRECOGNIZED_COMMAND; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MetaCommandResult::META_COMMAND_UNRECOGNIZED_COMMAND` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prepare.rs:14:4 [INFO] [stderr] | [INFO] [stderr] 14 | return PrepareResult::PREPARE_SUCCESS; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PrepareResult::PREPARE_SUCCESS` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prepare.rs:18:4 [INFO] [stderr] | [INFO] [stderr] 18 | return PrepareResult::PREPARE_SUCCESS; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PrepareResult::PREPARE_SUCCESS` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prepare.rs:21:4 [INFO] [stderr] | [INFO] [stderr] 21 | return PrepareResult::PREPARE_UNRECOGNIZED_STATEMENT; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PrepareResult::PREPARE_UNRECOGNIZED_STATEMENT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/statement.rs:13:2 [INFO] [stderr] | [INFO] [stderr] 13 | return Statement{ st_type: StatementType::UNKNOWN }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Statement{ st_type: StatementType::UNKNOWN }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:18:2 [INFO] [stderr] | [INFO] [stderr] 18 | return String::from(input.trim()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(input.trim())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:28:6 [INFO] [stderr] | [INFO] [stderr] 28 | if (input.chars().nth(0).unwrap() == '.') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/meta_command.rs:15:4 [INFO] [stderr] | [INFO] [stderr] 15 | return MetaCommandResult::META_COMMAND_UNRECOGNIZED_COMMAND; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MetaCommandResult::META_COMMAND_UNRECOGNIZED_COMMAND` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prepare.rs:14:4 [INFO] [stderr] | [INFO] [stderr] 14 | return PrepareResult::PREPARE_SUCCESS; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PrepareResult::PREPARE_SUCCESS` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prepare.rs:18:4 [INFO] [stderr] | [INFO] [stderr] 18 | return PrepareResult::PREPARE_SUCCESS; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PrepareResult::PREPARE_SUCCESS` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/prepare.rs:21:4 [INFO] [stderr] | [INFO] [stderr] 21 | return PrepareResult::PREPARE_UNRECOGNIZED_STATEMENT; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `PrepareResult::PREPARE_UNRECOGNIZED_STATEMENT` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/statement.rs:13:2 [INFO] [stderr] | [INFO] [stderr] 13 | return Statement{ st_type: StatementType::UNKNOWN }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Statement{ st_type: StatementType::UNKNOWN }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:18:2 [INFO] [stderr] | [INFO] [stderr] 18 | return String::from(input.trim()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(input.trim())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/main.rs:28:6 [INFO] [stderr] | [INFO] [stderr] 28 | if (input.chars().nth(0).unwrap() == '.') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `META_COMMAND_SUCCESS` [INFO] [stderr] --> src/meta_command.rs:5:2 [INFO] [stderr] | [INFO] [stderr] 5 | META_COMMAND_SUCCESS, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/meta_command.rs:9:31 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn do_meta_command(input: &String) -> MetaCommandResult { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/prepare.rs:10:33 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn prepare_statement(input: &String, statement: &mut statement::Statement) -> PrepareResult { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `META_COMMAND_SUCCESS` [INFO] [stderr] --> src/meta_command.rs:5:2 [INFO] [stderr] | [INFO] [stderr] 5 | META_COMMAND_SUCCESS, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/meta_command.rs:9:31 [INFO] [stderr] | [INFO] [stderr] 9 | pub fn do_meta_command(input: &String) -> MetaCommandResult { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] warning: function `defaultStatement` should have a snake case name such as `default_statement` [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] --> src/statement.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn defaultStatement() -> Statement { [INFO] [stderr] 13 | | return Statement{ st_type: StatementType::UNKNOWN }; [INFO] [stderr] 14 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: method `setType` should have a snake case name such as `set_type` [INFO] [stderr] --> src/statement.rs:17:2 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn setType(&mut self, st_type: StatementType) { [INFO] [stderr] | _____^ [INFO] [stderr] 18 | | self.st_type = st_type; [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/prepare.rs:10:33 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn prepare_statement(input: &String, statement: &mut statement::Statement) -> PrepareResult { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: function `defaultStatement` should have a snake case name such as `default_statement` [INFO] [stderr] --> src/statement.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn defaultStatement() -> Statement { [INFO] [stderr] 13 | | return Statement{ st_type: StatementType::UNKNOWN }; [INFO] [stderr] 14 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: method `setType` should have a snake case name such as `set_type` [INFO] [stderr] --> src/statement.rs:17:2 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn setType(&mut self, st_type: StatementType) { [INFO] [stderr] | _____^ [INFO] [stderr] 18 | | self.st_type = st_type; [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.47s [INFO] running `"docker" "inspect" "a2c423004cd8d9eb40092efd43bc16e4defd9825a9056a9e724a2b124088ce4e"` [INFO] running `"docker" "rm" "-f" "a2c423004cd8d9eb40092efd43bc16e4defd9825a9056a9e724a2b124088ce4e"` [INFO] [stdout] a2c423004cd8d9eb40092efd43bc16e4defd9825a9056a9e724a2b124088ce4e