[INFO] updating cached repository szhongren/rustbookv2 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/szhongren/rustbookv2 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/szhongren/rustbookv2" "work/ex/clippy-test-run/sources/stable/gh/szhongren/rustbookv2"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/szhongren/rustbookv2'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/szhongren/rustbookv2" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/szhongren/rustbookv2"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/szhongren/rustbookv2'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8534333cc27bf65741c823c98fcd03235b40ada7 [INFO] sha for GitHub repo szhongren/rustbookv2: 8534333cc27bf65741c823c98fcd03235b40ada7 [INFO] validating manifest of szhongren/rustbookv2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of szhongren/rustbookv2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing szhongren/rustbookv2 [INFO] finished frobbing szhongren/rustbookv2 [INFO] frobbed toml for szhongren/rustbookv2 written to work/ex/clippy-test-run/sources/stable/gh/szhongren/rustbookv2/Cargo.toml [INFO] started frobbing szhongren/rustbookv2 [INFO] finished frobbing szhongren/rustbookv2 [INFO] frobbed toml for szhongren/rustbookv2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/szhongren/rustbookv2/Cargo.toml [INFO] crate szhongren/rustbookv2 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting szhongren/rustbookv2 against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/szhongren/rustbookv2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dc43858a6b48ec7b4e1055249eb11fc66436d484f42506b4680ff94f63b540ca [INFO] running `"docker" "start" "-a" "dc43858a6b48ec7b4e1055249eb11fc66436d484f42506b4680ff94f63b540ca"` [INFO] [stderr] Checking rand v0.3.16 [INFO] [stderr] Checking rustbook v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/section03.rs:28:16 [INFO] [stderr] | [INFO] [stderr] 28 | let (x, y, z) = tup; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/section09.rs:2:20 [INFO] [stderr] | [INFO] [stderr] 2 | println!("{}", "to panic, use panic like: panic!(\"crash and burn\"))"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/section10.rs:206:20 [INFO] [stderr] | [INFO] [stderr] 206 | Self { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/section10.rs:206:26 [INFO] [stderr] | [INFO] [stderr] 206 | Self { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/section03.rs:28:16 [INFO] [stderr] | [INFO] [stderr] 28 | let (x, y, z) = tup; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/section09.rs:2:20 [INFO] [stderr] | [INFO] [stderr] 2 | println!("{}", "to panic, use panic like: panic!(\"crash and burn\"))"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/section10.rs:206:20 [INFO] [stderr] | [INFO] [stderr] 206 | Self { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/section10.rs:206:26 [INFO] [stderr] | [INFO] [stderr] 206 | Self { x: x, y: y } [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/section03.rs:13:28 [INFO] [stderr] | [INFO] [stderr] 13 | let hexadecimal: u64 = 0xdeadbeef; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/section03.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | y [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/section03.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | let y = { [INFO] [stderr] | _____________^ [INFO] [stderr] 41 | | let x = 3; [INFO] [stderr] 42 | | x + 2 [INFO] [stderr] 43 | | }; // expression, returns a value [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/section03.rs:13:28 [INFO] [stderr] | [INFO] [stderr] 13 | let hexadecimal: u64 = 0xdeadbeef; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xdead_beef` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/section03.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | y [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/section03.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | let y = { [INFO] [stderr] | _____________^ [INFO] [stderr] 41 | | let x = 3; [INFO] [stderr] 42 | | x + 2 [INFO] [stderr] 43 | | }; // expression, returns a value [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/section04.rs:10:28 [INFO] [stderr] | [INFO] [stderr] 10 | fn calculate_length(s: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/section04.rs:34:28 [INFO] [stderr] | [INFO] [stderr] 34 | fn first_word_naive(s: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/section04.rs:46:22 [INFO] [stderr] | [INFO] [stderr] 46 | fn first_word(s: &String) -> &str { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/section06.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | / match some_u8_value { [INFO] [stderr] 145 | | Some(3) => println!("three"), [INFO] [stderr] 146 | | _ => (), [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(3) = some_u8_value { println!("three") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/section04.rs:10:28 [INFO] [stderr] | [INFO] [stderr] 10 | fn calculate_length(s: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/section04.rs:34:28 [INFO] [stderr] | [INFO] [stderr] 34 | fn first_word_naive(s: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/section04.rs:46:22 [INFO] [stderr] | [INFO] [stderr] 46 | fn first_word(s: &String) -> &str { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/section06.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | / match some_u8_value { [INFO] [stderr] 145 | | Some(3) => println!("three"), [INFO] [stderr] 146 | | _ => (), [INFO] [stderr] 147 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(3) = some_u8_value { println!("three") }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.33s [INFO] running `"docker" "inspect" "dc43858a6b48ec7b4e1055249eb11fc66436d484f42506b4680ff94f63b540ca"` [INFO] running `"docker" "rm" "-f" "dc43858a6b48ec7b4e1055249eb11fc66436d484f42506b4680ff94f63b540ca"` [INFO] [stdout] dc43858a6b48ec7b4e1055249eb11fc66436d484f42506b4680ff94f63b540ca