[INFO] updating cached repository szagi3891/gitstatus
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/szagi3891/gitstatus
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/szagi3891/gitstatus" "work/ex/clippy-test-run/sources/stable/gh/szagi3891/gitstatus"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/szagi3891/gitstatus'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/szagi3891/gitstatus" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/szagi3891/gitstatus"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/szagi3891/gitstatus'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] de0c9695b6e98ac82dfda2754fd1c360211a30d5
[INFO] sha for GitHub repo szagi3891/gitstatus: de0c9695b6e98ac82dfda2754fd1c360211a30d5
[INFO] validating manifest of szagi3891/gitstatus on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of szagi3891/gitstatus on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing szagi3891/gitstatus
[INFO] finished frobbing szagi3891/gitstatus
[INFO] frobbed toml for szagi3891/gitstatus written to work/ex/clippy-test-run/sources/stable/gh/szagi3891/gitstatus/Cargo.toml
[INFO] started frobbing szagi3891/gitstatus
[INFO] finished frobbing szagi3891/gitstatus
[INFO] frobbed toml for szagi3891/gitstatus written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/szagi3891/gitstatus/Cargo.toml
[INFO] crate szagi3891/gitstatus has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting szagi3891/gitstatus against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/szagi3891/gitstatus:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e00f1b96c445168fe81c420ccd9093a28cca52ff31cdc6c49864844b4f63cac4
[INFO] running `"docker" "start" "-a" "e00f1b96c445168fe81c420ccd9093a28cca52ff31cdc6c49864844b4f63cac4"`
[INFO] [stderr]     Checking git-status-all v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:18:2
[INFO] [stderr]    |
[INFO] [stderr] 18 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:35:4
[INFO] [stderr]    |
[INFO] [stderr] 35 |             println!("");
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/main.rs:107:5
[INFO] [stderr]     |
[INFO] [stderr] 107 |                 println!("");
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:18:2
[INFO] [stderr]    |
[INFO] [stderr] 18 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:35:4
[INFO] [stderr]    |
[INFO] [stderr] 35 |             println!("");
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/main.rs:107:5
[INFO] [stderr]     |
[INFO] [stderr] 107 |                 println!("");
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/get_list.rs:34:7
[INFO] [stderr]    |
[INFO] [stderr] 34 |             if dir_info.is_dir() == false {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!dir_info.is_dir()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/command.rs:81:63
[INFO] [stderr]    |
[INFO] [stderr] 81 |             if out.status.success() && out.status.code() == Some(0) && out.stderr.len() == 0 {
[INFO] [stderr]    |                                                                        ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `out.stderr.is_empty()`
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/get_list.rs:34:7
[INFO] [stderr]    |
[INFO] [stderr] 34 |             if dir_info.is_dir() == false {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!dir_info.is_dir()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/command.rs:81:63
[INFO] [stderr]    |
[INFO] [stderr] 81 |             if out.status.success() && out.status.code() == Some(0) && out.stderr.len() == 0 {
[INFO] [stderr]    |                                                                        ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `out.stderr.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:97:29
[INFO] [stderr]    |
[INFO] [stderr] 97 |                             count_err = count_err + 1;
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `count_err += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/main.rs:97:29
[INFO] [stderr]    |
[INFO] [stderr] 97 |                             count_err = count_err + 1;
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `count_err += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/main.rs:144:5
[INFO] [stderr]     |
[INFO] [stderr] 144 |     if item.is_dir == false {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!item.is_dir`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/main.rs:144:5
[INFO] [stderr]     |
[INFO] [stderr] 144 |     if item.is_dir == false {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!item.is_dir`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:146:14
[INFO] [stderr]     |
[INFO] [stderr] 146 |         return Err(format!("pomijam bo to plik"));
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"pomijam bo to plik".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/main.rs:201:6
[INFO] [stderr]     |
[INFO] [stderr] 201 |                       if item == ' ' || item == '*' {
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 202 | |                         false
[INFO] [stderr] 203 | |                     } else {
[INFO] [stderr] 204 | |                         true
[INFO] [stderr] 205 | |                     }
[INFO] [stderr]     | |_____________________^ help: you can reduce it to: `!(item == ' ' || item == '*')`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/main.rs:228:4
[INFO] [stderr]     |
[INFO] [stderr] 228 |               match is_err {
[INFO] [stderr]     |  _____________^
[INFO] [stderr] 229 | |                 false => {
[INFO] [stderr] 230 | |                     Ok(())
[INFO] [stderr] 231 | |                 }
[INFO] [stderr] ...   |
[INFO] [stderr] 234 | |                 }
[INFO] [stderr] 235 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 228 |             if is_err {
[INFO] [stderr] 229 |     Err("Nie wszystkie branche są wypchnięte na zdalny serwer".to_owned())
[INFO] [stderr] 230 | } else {
[INFO] [stderr] 231 |     Ok(())
[INFO] [stderr] 232 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:245:22
[INFO] [stderr]     |
[INFO] [stderr] 245 | fn test_branch(path: &String, branch_clear: &String) -> Result<(), String> {
[INFO] [stderr]     |                      ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]     |
[INFO] [stderr] 245 | fn test_branch(path: &str, branch_clear: &String) -> Result<(), String> {
[INFO] [stderr]     |                      ^^^^
[INFO] [stderr] help: change `path.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 254 |         current_dir : path.to_string(),
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^
[INFO] [stderr] help: change `path.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 260 |         current_dir : path.to_string(),
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:245:45
[INFO] [stderr]     |
[INFO] [stderr] 245 | fn test_branch(path: &String, branch_clear: &String) -> Result<(), String> {
[INFO] [stderr]     |                                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:250:19
[INFO] [stderr]     |
[INFO] [stderr] 250 |     let branch1 = format!("{}"       , branch_clear);
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `branch_clear.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:146:14
[INFO] [stderr]     |
[INFO] [stderr] 146 |         return Err(format!("pomijam bo to plik"));
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"pomijam bo to plik".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/main.rs:201:6
[INFO] [stderr]     |
[INFO] [stderr] 201 |                       if item == ' ' || item == '*' {
[INFO] [stderr]     |  _____________________^
[INFO] [stderr] 202 | |                         false
[INFO] [stderr] 203 | |                     } else {
[INFO] [stderr] 204 | |                         true
[INFO] [stderr] 205 | |                     }
[INFO] [stderr]     | |_____________________^ help: you can reduce it to: `!(item == ' ' || item == '*')`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/main.rs:228:4
[INFO] [stderr]     |
[INFO] [stderr] 228 |               match is_err {
[INFO] [stderr]     |  _____________^
[INFO] [stderr] 229 | |                 false => {
[INFO] [stderr] 230 | |                     Ok(())
[INFO] [stderr] 231 | |                 }
[INFO] [stderr] ...   |
[INFO] [stderr] 234 | |                 }
[INFO] [stderr] 235 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 228 |             if is_err {
[INFO] [stderr] 229 |     Err("Nie wszystkie branche są wypchnięte na zdalny serwer".to_owned())
[INFO] [stderr] 230 | } else {
[INFO] [stderr] 231 |     Ok(())
[INFO] [stderr] 232 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:245:22
[INFO] [stderr]     |
[INFO] [stderr] 245 | fn test_branch(path: &String, branch_clear: &String) -> Result<(), String> {
[INFO] [stderr]     |                      ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]     |
[INFO] [stderr] 245 | fn test_branch(path: &str, branch_clear: &String) -> Result<(), String> {
[INFO] [stderr]     |                      ^^^^
[INFO] [stderr] help: change `path.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 254 |         current_dir : path.to_string(),
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^
[INFO] [stderr] help: change `path.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 260 |         current_dir : path.to_string(),
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/main.rs:245:45
[INFO] [stderr]     |
[INFO] [stderr] 245 | fn test_branch(path: &String, branch_clear: &String) -> Result<(), String> {
[INFO] [stderr]     |                                             ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:250:19
[INFO] [stderr]     |
[INFO] [stderr] 250 |     let branch1 = format!("{}"       , branch_clear);
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `branch_clear.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.05s
[INFO] running `"docker" "inspect" "e00f1b96c445168fe81c420ccd9093a28cca52ff31cdc6c49864844b4f63cac4"`
[INFO] running `"docker" "rm" "-f" "e00f1b96c445168fe81c420ccd9093a28cca52ff31cdc6c49864844b4f63cac4"`
[INFO] [stdout] e00f1b96c445168fe81c420ccd9093a28cca52ff31cdc6c49864844b4f63cac4