[INFO] updating cached repository syntheticsh/binary-play
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/syntheticsh/binary-play
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/syntheticsh/binary-play" "work/ex/clippy-test-run/sources/stable/gh/syntheticsh/binary-play"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/syntheticsh/binary-play'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/syntheticsh/binary-play" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/syntheticsh/binary-play"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/syntheticsh/binary-play'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 2ef5ff608528a7ce2e4a22f44bd1871aab525fd7
[INFO] sha for GitHub repo syntheticsh/binary-play: 2ef5ff608528a7ce2e4a22f44bd1871aab525fd7
[INFO] validating manifest of syntheticsh/binary-play on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of syntheticsh/binary-play on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing syntheticsh/binary-play
[INFO] finished frobbing syntheticsh/binary-play
[INFO] frobbed toml for syntheticsh/binary-play written to work/ex/clippy-test-run/sources/stable/gh/syntheticsh/binary-play/Cargo.toml
[INFO] started frobbing syntheticsh/binary-play
[INFO] finished frobbing syntheticsh/binary-play
[INFO] frobbed toml for syntheticsh/binary-play written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/syntheticsh/binary-play/Cargo.toml
[INFO] crate syntheticsh/binary-play has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting syntheticsh/binary-play against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/syntheticsh/binary-play:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ddd850eea6d69f2255db976a6dc7961bbddf919e2f4ef00ba453bd4047bb68f4
[INFO] running `"docker" "start" "-a" "ddd850eea6d69f2255db976a6dc7961bbddf919e2f4ef00ba453bd4047bb68f4"`
[INFO] [stderr]     Checking binary v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/lib.rs:100:13
[INFO] [stderr]     |
[INFO] [stderr] 100 |             left
[INFO] [stderr]     |             ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/lib.rs:99:24
[INFO] [stderr]     |
[INFO] [stderr] 99  |             let left = &self.left;
[INFO] [stderr]     |                        ^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/lib.rs:105:13
[INFO] [stderr]     |
[INFO] [stderr] 105 |             right
[INFO] [stderr]     |             ^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/lib.rs:104:25
[INFO] [stderr]     |
[INFO] [stderr] 104 |             let right = &self.left;
[INFO] [stderr]     |                         ^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/lib.rs:100:13
[INFO] [stderr]     |
[INFO] [stderr] 100 |             left
[INFO] [stderr]     |             ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/lib.rs:99:24
[INFO] [stderr]     |
[INFO] [stderr] 99  |             let left = &self.left;
[INFO] [stderr]     |                        ^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/lib.rs:105:13
[INFO] [stderr]     |
[INFO] [stderr] 105 |             right
[INFO] [stderr]     |             ^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/lib.rs:104:25
[INFO] [stderr]     |
[INFO] [stderr] 104 |             let right = &self.left;
[INFO] [stderr]     |                         ^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:144:9
[INFO] [stderr]     |
[INFO] [stderr] 144 | /         pub fn iter_mut<'a>(&'a mut self) -> IterMut<T> {
[INFO] [stderr] 145 | |             let mut values = vec![];
[INFO] [stderr] 146 | |
[INFO] [stderr] 147 | |             let right_tree = &mut self.right;
[INFO] [stderr] ...   |
[INFO] [stderr] 173 | |             IterMut { values }
[INFO] [stderr] 174 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:176:9
[INFO] [stderr]     |
[INFO] [stderr] 176 | /         pub fn iter<'a>(&'a self) -> Iter<'a, T> {
[INFO] [stderr] 177 | |             let mut values = vec![];
[INFO] [stderr] 178 | |
[INFO] [stderr] 179 | |             match self.get_left() {
[INFO] [stderr] ...   |
[INFO] [stderr] 202 | |             Iter { values, current: 0 }
[INFO] [stderr] 203 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `into_iter` on this type; consider implementing the `std::iter::IntoIterator` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:205:9
[INFO] [stderr]     |
[INFO] [stderr] 205 | /         pub fn into_iter(self) -> IntoIter<T> {
[INFO] [stderr] 206 | |             let mut values = vec![];
[INFO] [stderr] 207 | |
[INFO] [stderr] 208 | |             let (left, head) = self.take_left();
[INFO] [stderr] ...   |
[INFO] [stderr] 241 | |             }
[INFO] [stderr] 242 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:210:13
[INFO] [stderr]     |
[INFO] [stderr] 210 | /             match left {
[INFO] [stderr] 211 | |                 Some(left_tree) => {
[INFO] [stderr] 212 | |                     for tree in left_tree.into_iter() {
[INFO] [stderr] 213 | |                         let value = tree;
[INFO] [stderr] ...   |
[INFO] [stderr] 217 | |                 None => {}
[INFO] [stderr] 218 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 210 |             if let Some(left_tree) = left {
[INFO] [stderr] 211 |     for tree in left_tree.into_iter() {
[INFO] [stderr] 212 |         let value = tree;
[INFO] [stderr] 213 |         values.push(value);
[INFO] [stderr] 214 |     }
[INFO] [stderr] 215 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:220:13
[INFO] [stderr]     |
[INFO] [stderr] 220 | /             match head {
[INFO] [stderr] 221 | |                 Some(head_tree) => {
[INFO] [stderr] 222 | |                     let (mut detached_head, mut right) = head_tree.take_right();
[INFO] [stderr] 223 | |                     let value = detached_head.unwrap().value;
[INFO] [stderr] ...   |
[INFO] [stderr] 236 | |                 None => {}
[INFO] [stderr] 237 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 220 |             if let Some(head_tree) = head {
[INFO] [stderr] 221 |     let (mut detached_head, mut right) = head_tree.take_right();
[INFO] [stderr] 222 |     let value = detached_head.unwrap().value;
[INFO] [stderr] 223 |     values.push(value);
[INFO] [stderr] 224 | 
[INFO] [stderr] 225 |     match right {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:226:21
[INFO] [stderr]     |
[INFO] [stderr] 226 | /                     match right {
[INFO] [stderr] 227 | |                         Some(right_tree) => {
[INFO] [stderr] 228 | |                             for tree in right_tree.into_iter() {
[INFO] [stderr] 229 | |                                 let value = tree;
[INFO] [stderr] ...   |
[INFO] [stderr] 233 | |                         None => {}
[INFO] [stderr] 234 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 226 |                     if let Some(right_tree) = right {
[INFO] [stderr] 227 |     for tree in right_tree.into_iter() {
[INFO] [stderr] 228 |         let value = tree;
[INFO] [stderr] 229 |         values.push(value);
[INFO] [stderr] 230 |     }
[INFO] [stderr] 231 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:144:9
[INFO] [stderr]     |
[INFO] [stderr] 144 | /         pub fn iter_mut<'a>(&'a mut self) -> IterMut<T> {
[INFO] [stderr] 145 | |             let mut values = vec![];
[INFO] [stderr] 146 | |
[INFO] [stderr] 147 | |             let right_tree = &mut self.right;
[INFO] [stderr] ...   |
[INFO] [stderr] 173 | |             IterMut { values }
[INFO] [stderr] 174 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:176:9
[INFO] [stderr]     |
[INFO] [stderr] 176 | /         pub fn iter<'a>(&'a self) -> Iter<'a, T> {
[INFO] [stderr] 177 | |             let mut values = vec![];
[INFO] [stderr] 178 | |
[INFO] [stderr] 179 | |             match self.get_left() {
[INFO] [stderr] ...   |
[INFO] [stderr] 202 | |             Iter { values, current: 0 }
[INFO] [stderr] 203 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: defining a method called `into_iter` on this type; consider implementing the `std::iter::IntoIterator` trait or choosing a less ambiguous name
[INFO] [stderr]    --> src/lib.rs:205:9
[INFO] [stderr]     |
[INFO] [stderr] 205 | /         pub fn into_iter(self) -> IntoIter<T> {
[INFO] [stderr] 206 | |             let mut values = vec![];
[INFO] [stderr] 207 | |
[INFO] [stderr] 208 | |             let (left, head) = self.take_left();
[INFO] [stderr] ...   |
[INFO] [stderr] 241 | |             }
[INFO] [stderr] 242 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::should_implement_trait)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:210:13
[INFO] [stderr]     |
[INFO] [stderr] 210 | /             match left {
[INFO] [stderr] 211 | |                 Some(left_tree) => {
[INFO] [stderr] 212 | |                     for tree in left_tree.into_iter() {
[INFO] [stderr] 213 | |                         let value = tree;
[INFO] [stderr] ...   |
[INFO] [stderr] 217 | |                 None => {}
[INFO] [stderr] 218 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 210 |             if let Some(left_tree) = left {
[INFO] [stderr] 211 |     for tree in left_tree.into_iter() {
[INFO] [stderr] 212 |         let value = tree;
[INFO] [stderr] 213 |         values.push(value);
[INFO] [stderr] 214 |     }
[INFO] [stderr] 215 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:220:13
[INFO] [stderr]     |
[INFO] [stderr] 220 | /             match head {
[INFO] [stderr] 221 | |                 Some(head_tree) => {
[INFO] [stderr] 222 | |                     let (mut detached_head, mut right) = head_tree.take_right();
[INFO] [stderr] 223 | |                     let value = detached_head.unwrap().value;
[INFO] [stderr] ...   |
[INFO] [stderr] 236 | |                 None => {}
[INFO] [stderr] 237 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 220 |             if let Some(head_tree) = head {
[INFO] [stderr] 221 |     let (mut detached_head, mut right) = head_tree.take_right();
[INFO] [stderr] 222 |     let value = detached_head.unwrap().value;
[INFO] [stderr] 223 |     values.push(value);
[INFO] [stderr] 224 | 
[INFO] [stderr] 225 |     match right {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:226:21
[INFO] [stderr]     |
[INFO] [stderr] 226 | /                     match right {
[INFO] [stderr] 227 | |                         Some(right_tree) => {
[INFO] [stderr] 228 | |                             for tree in right_tree.into_iter() {
[INFO] [stderr] 229 | |                                 let value = tree;
[INFO] [stderr] ...   |
[INFO] [stderr] 233 | |                         None => {}
[INFO] [stderr] 234 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 226 |                     if let Some(right_tree) = right {
[INFO] [stderr] 227 |     for tree in right_tree.into_iter() {
[INFO] [stderr] 228 |         let value = tree;
[INFO] [stderr] 229 |         values.push(value);
[INFO] [stderr] 230 |     }
[INFO] [stderr] 231 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/main.rs:56:5
[INFO] [stderr]    |
[INFO] [stderr] 56 |     print!("\n");
[INFO] [stderr]    |     ^^^^^^^^^^^^
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/main.rs:56:5
[INFO] [stderr]    |
[INFO] [stderr] 56 |     print!("\n");
[INFO] [stderr]    |     ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/main.rs:62:5
[INFO] [stderr]    |
[INFO] [stderr] 62 |     print!("\n");
[INFO] [stderr]    |     ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead
[INFO] [stderr]   --> src/main.rs:62:5
[INFO] [stderr]    |
[INFO] [stderr] 62 |     print!("\n");
[INFO] [stderr]    |     ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.38s
[INFO] running `"docker" "inspect" "ddd850eea6d69f2255db976a6dc7961bbddf919e2f4ef00ba453bd4047bb68f4"`
[INFO] running `"docker" "rm" "-f" "ddd850eea6d69f2255db976a6dc7961bbddf919e2f4ef00ba453bd4047bb68f4"`
[INFO] [stdout] ddd850eea6d69f2255db976a6dc7961bbddf919e2f4ef00ba453bd4047bb68f4