[INFO] updating cached repository sunny4381/brightness [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sunny4381/brightness [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sunny4381/brightness" "work/ex/clippy-test-run/sources/stable/gh/sunny4381/brightness"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sunny4381/brightness'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sunny4381/brightness" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sunny4381/brightness"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sunny4381/brightness'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9bf590b9057464706d60dd93e7a7604f1e375278 [INFO] sha for GitHub repo sunny4381/brightness: 9bf590b9057464706d60dd93e7a7604f1e375278 [INFO] validating manifest of sunny4381/brightness on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sunny4381/brightness on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sunny4381/brightness [INFO] finished frobbing sunny4381/brightness [INFO] frobbed toml for sunny4381/brightness written to work/ex/clippy-test-run/sources/stable/gh/sunny4381/brightness/Cargo.toml [INFO] started frobbing sunny4381/brightness [INFO] finished frobbing sunny4381/brightness [INFO] frobbed toml for sunny4381/brightness written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sunny4381/brightness/Cargo.toml [INFO] crate sunny4381/brightness has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sunny4381/brightness against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sunny4381/brightness:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8e89ac9c46e510ee771a553cc8e26b3743fab0e055a6e08d793941b1f65d6733 [INFO] running `"docker" "start" "-a" "8e89ac9c46e510ee771a553cc8e26b3743fab0e055a6e08d793941b1f65d6733"` [INFO] [stderr] Checking num-traits v0.1.37 [INFO] [stderr] Checking adler32 v0.3.0 [INFO] [stderr] Checking inflate v0.1.1 [INFO] [stderr] Checking num_cpus v1.3.0 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking thread-id v3.0.0 [INFO] [stderr] Checking gif v0.9.1 [INFO] [stderr] Checking deque v0.3.1 [INFO] [stderr] Checking thread_local v0.3.3 [INFO] [stderr] Checking deflate v0.7.4 [INFO] [stderr] Checking rayon v0.6.0 [INFO] [stderr] Checking aho-corasick v0.6.2 [INFO] [stderr] Checking regex v0.2.1 [INFO] [stderr] Checking num-integer v0.1.33 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking num-iter v0.1.33 [INFO] [stderr] Checking num-rational v0.1.36 [INFO] [stderr] Checking jpeg-decoder v0.1.11 [INFO] [stderr] Checking docopt v0.7.0 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking image v0.12.3 [INFO] [stderr] Checking brightness v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | const USAGE: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | return sum / (count as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sum / (count as f64)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | return calc_gray(SamplePixels::from_image(img, smpl)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `calc_gray(SamplePixels::from_image(img, smpl))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:49:57 [INFO] [stderr] | [INFO] [stderr] 49 | x_points: rand::sample(&mut rng, 0..width, ((width as f64) * smpl / 100.0) as usize), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:50:58 [INFO] [stderr] | [INFO] [stderr] 50 | y_points: rand::sample(&mut rng, 0..height, ((height as f64) * smpl / 100.0) as usize) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/main.rs:79:14 [INFO] [stderr] | [INFO] [stderr] 79 | fn calc_gray<'a, I>(pixels: I) -> f64 [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:15:15 [INFO] [stderr] | [INFO] [stderr] 15 | const USAGE: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | return sum / (count as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sum / (count as f64)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | return calc_gray(SamplePixels::from_image(img, smpl)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `calc_gray(SamplePixels::from_image(img, smpl))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:86:19 [INFO] [stderr] | [INFO] [stderr] 86 | let red = pixel.data[0] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pixel.data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:87:20 [INFO] [stderr] | [INFO] [stderr] 87 | let blue = pixel.data[1] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pixel.data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | let green = pixel.data[2] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pixel.data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:94:18 [INFO] [stderr] | [INFO] [stderr] 94 | return sum / (count as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:49:57 [INFO] [stderr] | [INFO] [stderr] 49 | x_points: rand::sample(&mut rng, 0..width, ((width as f64) * smpl / 100.0) as usize), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:50:58 [INFO] [stderr] | [INFO] [stderr] 50 | y_points: rand::sample(&mut rng, 0..height, ((height as f64) * smpl / 100.0) as usize) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/main.rs:79:14 [INFO] [stderr] | [INFO] [stderr] 79 | fn calc_gray<'a, I>(pixels: I) -> f64 [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:86:19 [INFO] [stderr] | [INFO] [stderr] 86 | let red = pixel.data[0] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pixel.data[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:87:20 [INFO] [stderr] | [INFO] [stderr] 87 | let blue = pixel.data[1] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pixel.data[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | let green = pixel.data[2] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(pixel.data[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:94:18 [INFO] [stderr] | [INFO] [stderr] 94 | return sum / (count as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.57s [INFO] running `"docker" "inspect" "8e89ac9c46e510ee771a553cc8e26b3743fab0e055a6e08d793941b1f65d6733"` [INFO] running `"docker" "rm" "-f" "8e89ac9c46e510ee771a553cc8e26b3743fab0e055a6e08d793941b1f65d6733"` [INFO] [stdout] 8e89ac9c46e510ee771a553cc8e26b3743fab0e055a6e08d793941b1f65d6733