[INFO] updating cached repository studio-lucia/sssunpack
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/studio-lucia/sssunpack
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/studio-lucia/sssunpack" "work/ex/clippy-test-run/sources/stable/gh/studio-lucia/sssunpack"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/studio-lucia/sssunpack'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/studio-lucia/sssunpack" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/studio-lucia/sssunpack"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/studio-lucia/sssunpack'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 9778a307659e317c5ea1a7ce533017b3ef5fa27b
[INFO] sha for GitHub repo studio-lucia/sssunpack: 9778a307659e317c5ea1a7ce533017b3ef5fa27b
[INFO] validating manifest of studio-lucia/sssunpack on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of studio-lucia/sssunpack on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing studio-lucia/sssunpack
[INFO] finished frobbing studio-lucia/sssunpack
[INFO] frobbed toml for studio-lucia/sssunpack written to work/ex/clippy-test-run/sources/stable/gh/studio-lucia/sssunpack/Cargo.toml
[INFO] started frobbing studio-lucia/sssunpack
[INFO] finished frobbing studio-lucia/sssunpack
[INFO] frobbed toml for studio-lucia/sssunpack written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/studio-lucia/sssunpack/Cargo.toml
[INFO] crate studio-lucia/sssunpack has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting studio-lucia/sssunpack against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/studio-lucia/sssunpack:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b1c72ffb9528142d9776fcd415d05dd2df3379b2dcc61c88299794d94396c6ab
[INFO] running `"docker" "start" "-a" "b1c72ffb9528142d9776fcd415d05dd2df3379b2dcc61c88299794d94396c6ab"`
[INFO] [stderr]     Checking term_size v0.3.0
[INFO] [stderr]     Checking atty v0.2.2
[INFO] [stderr]     Checking clap v2.24.2
[INFO] [stderr]     Checking sssunpack v0.3.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 | /     return Cursor::new(bytes)
[INFO] [stderr] 30 | |         .read_u16::<BigEndian>()
[INFO] [stderr] 31 | |         .unwrap();
[INFO] [stderr]    | |__________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 29 |     Cursor::new(bytes)
[INFO] [stderr] 30 |         .read_u16::<BigEndian>()
[INFO] [stderr] 31 |         .unwrap()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 | /     return Cursor::new(bytes)
[INFO] [stderr] 36 | |         .read_u32::<BigEndian>()
[INFO] [stderr] 37 | |         .unwrap();
[INFO] [stderr]    | |__________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 35 |     Cursor::new(bytes)
[INFO] [stderr] 36 |         .read_u32::<BigEndian>()
[INFO] [stderr] 37 |         .unwrap()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:54:5
[INFO] [stderr]    |
[INFO] [stderr] 54 | /     return Some(FileEntry {
[INFO] [stderr] 55 | |         name: String::from_utf8(filename).unwrap(),
[INFO] [stderr] 56 | |         start: uint16_from_bytes([data[14], data[15]]),
[INFO] [stderr] 57 | |         end: uint16_from_bytes([data[18], data[19]]),
[INFO] [stderr] 58 | |         length: uint32_from_bytes([data[20], data[21], data[22], data[23]]),
[INFO] [stderr] 59 | |     });
[INFO] [stderr]    | |_______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 54 |     Some(FileEntry {
[INFO] [stderr] 55 |         name: String::from_utf8(filename).unwrap(),
[INFO] [stderr] 56 |         start: uint16_from_bytes([data[14], data[15]]),
[INFO] [stderr] 57 |         end: uint16_from_bytes([data[18], data[19]]),
[INFO] [stderr] 58 |         length: uint32_from_bytes([data[20], data[21], data[22], data[23]]),
[INFO] [stderr] 59 |     })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:71:20
[INFO] [stderr]    |
[INFO] [stderr] 71 |         Some(f) => return Ok(f.start as usize),
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(f.start as usize)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:72:17
[INFO] [stderr]    |
[INFO] [stderr] 72 |         None => return Err(String::from("Unable to parse header!")),
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(String::from("Unable to parse header!"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 | /     return data[0..SECTOR_LENGTH * header_size.unwrap()]
[INFO] [stderr] 81 | |         .chunks(24)
[INFO] [stderr] 82 | |         .filter_map(|header| parse_file_listing(header))
[INFO] [stderr] 83 | |         .collect();
[INFO] [stderr]    | |___________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 80 |     data[0..SECTOR_LENGTH * header_size.unwrap()]
[INFO] [stderr] 81 |         .chunks(24)
[INFO] [stderr] 82 |         .filter_map(|header| parse_file_listing(header))
[INFO] [stderr] 83 |         .collect()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:93:5
[INFO] [stderr]    |
[INFO] [stderr] 93 |     return Ok(());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:101:5
[INFO] [stderr]     |
[INFO] [stderr] 101 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:117:5
[INFO] [stderr]     |
[INFO] [stderr] 117 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:149:5
[INFO] [stderr]     |
[INFO] [stderr] 149 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:29:5
[INFO] [stderr]    |
[INFO] [stderr] 29 | /     return Cursor::new(bytes)
[INFO] [stderr] 30 | |         .read_u16::<BigEndian>()
[INFO] [stderr] 31 | |         .unwrap();
[INFO] [stderr]    | |__________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 29 |     Cursor::new(bytes)
[INFO] [stderr] 30 |         .read_u16::<BigEndian>()
[INFO] [stderr] 31 |         .unwrap()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:35:5
[INFO] [stderr]    |
[INFO] [stderr] 35 | /     return Cursor::new(bytes)
[INFO] [stderr] 36 | |         .read_u32::<BigEndian>()
[INFO] [stderr] 37 | |         .unwrap();
[INFO] [stderr]    | |__________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 35 |     Cursor::new(bytes)
[INFO] [stderr] 36 |         .read_u32::<BigEndian>()
[INFO] [stderr] 37 |         .unwrap()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:54:5
[INFO] [stderr]    |
[INFO] [stderr] 54 | /     return Some(FileEntry {
[INFO] [stderr] 55 | |         name: String::from_utf8(filename).unwrap(),
[INFO] [stderr] 56 | |         start: uint16_from_bytes([data[14], data[15]]),
[INFO] [stderr] 57 | |         end: uint16_from_bytes([data[18], data[19]]),
[INFO] [stderr] 58 | |         length: uint32_from_bytes([data[20], data[21], data[22], data[23]]),
[INFO] [stderr] 59 | |     });
[INFO] [stderr]    | |_______^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 54 |     Some(FileEntry {
[INFO] [stderr] 55 |         name: String::from_utf8(filename).unwrap(),
[INFO] [stderr] 56 |         start: uint16_from_bytes([data[14], data[15]]),
[INFO] [stderr] 57 |         end: uint16_from_bytes([data[18], data[19]]),
[INFO] [stderr] 58 |         length: uint32_from_bytes([data[20], data[21], data[22], data[23]]),
[INFO] [stderr] 59 |     })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:71:20
[INFO] [stderr]    |
[INFO] [stderr] 71 |         Some(f) => return Ok(f.start as usize),
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(f.start as usize)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:72:17
[INFO] [stderr]    |
[INFO] [stderr] 72 |         None => return Err(String::from("Unable to parse header!")),
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(String::from("Unable to parse header!"))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:80:5
[INFO] [stderr]    |
[INFO] [stderr] 80 | /     return data[0..SECTOR_LENGTH * header_size.unwrap()]
[INFO] [stderr] 81 | |         .chunks(24)
[INFO] [stderr] 82 | |         .filter_map(|header| parse_file_listing(header))
[INFO] [stderr] 83 | |         .collect();
[INFO] [stderr]    | |___________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 80 |     data[0..SECTOR_LENGTH * header_size.unwrap()]
[INFO] [stderr] 81 |         .chunks(24)
[INFO] [stderr] 82 |         .filter_map(|header| parse_file_listing(header))
[INFO] [stderr] 83 |         .collect()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:93:5
[INFO] [stderr]    |
[INFO] [stderr] 93 |     return Ok(());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:101:5
[INFO] [stderr]     |
[INFO] [stderr] 101 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:117:5
[INFO] [stderr]     |
[INFO] [stderr] 117 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:149:5
[INFO] [stderr]     |
[INFO] [stderr] 149 |     return Ok(());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 8.77s
[INFO] running `"docker" "inspect" "b1c72ffb9528142d9776fcd415d05dd2df3379b2dcc61c88299794d94396c6ab"`
[INFO] running `"docker" "rm" "-f" "b1c72ffb9528142d9776fcd415d05dd2df3379b2dcc61c88299794d94396c6ab"`
[INFO] [stdout] b1c72ffb9528142d9776fcd415d05dd2df3379b2dcc61c88299794d94396c6ab