[INFO] updating cached repository studio-lucia/fontbuild
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/studio-lucia/fontbuild
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/studio-lucia/fontbuild" "work/ex/clippy-test-run/sources/stable/gh/studio-lucia/fontbuild"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/studio-lucia/fontbuild'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/studio-lucia/fontbuild" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/studio-lucia/fontbuild"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/studio-lucia/fontbuild'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5bd7e67af75e42fec2092a646989d4bdf77b1ffd
[INFO] sha for GitHub repo studio-lucia/fontbuild: 5bd7e67af75e42fec2092a646989d4bdf77b1ffd
[INFO] validating manifest of studio-lucia/fontbuild on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of studio-lucia/fontbuild on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing studio-lucia/fontbuild
[INFO] finished frobbing studio-lucia/fontbuild
[INFO] frobbed toml for studio-lucia/fontbuild written to work/ex/clippy-test-run/sources/stable/gh/studio-lucia/fontbuild/Cargo.toml
[INFO] started frobbing studio-lucia/fontbuild
[INFO] finished frobbing studio-lucia/fontbuild
[INFO] frobbed toml for studio-lucia/fontbuild written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/studio-lucia/fontbuild/Cargo.toml
[INFO] crate studio-lucia/fontbuild has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting studio-lucia/fontbuild against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/studio-lucia/fontbuild:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 25f5edf176c8e89368ab4e330d9d56b1d70d7d99a916867a30c50aea74d00581
[INFO] running `"docker" "start" "-a" "25f5edf176c8e89368ab4e330d9d56b1d70d7d99a916867a30c50aea74d00581"`
[INFO] [stderr]     Checking num-integer v0.1.34
[INFO] [stderr]     Checking memchr v1.0.1
[INFO] [stderr]     Checking term_size v0.3.0
[INFO] [stderr]     Checking atty v0.2.2
[INFO] [stderr]     Checking deflate v0.7.13
[INFO] [stderr]     Checking aho-corasick v0.6.3
[INFO] [stderr]     Checking textwrap v0.6.0
[INFO] [stderr]     Checking num-iter v0.1.33
[INFO] [stderr]     Checking clap v2.25.0
[INFO] [stderr]     Checking regex v0.2.2
[INFO] [stderr]     Checking png v0.9.0
[INFO] [stderr]     Checking fontbuild v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:27:21
[INFO] [stderr]    |
[INFO] [stderr] 27 |         Ok(glob) => return Ok(glob),
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(glob)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:28:19
[INFO] [stderr]    |
[INFO] [stderr] 28 |         Err(e) => return Err(format!("Error listing files: {}", e)),
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Error listing files: {}", e))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:37:5
[INFO] [stderr]    |
[INFO] [stderr] 37 |     return v
[INFO] [stderr]    |     ^^^^^^^^ help: remove `return` as shown: `v`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:45:5
[INFO] [stderr]    |
[INFO] [stderr] 45 |     return v;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `v`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:65:5
[INFO] [stderr]    |
[INFO] [stderr] 65 |     return Ok(result);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:112:5
[INFO] [stderr]     |
[INFO] [stderr] 112 |     return Ok(buf);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buf)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:123:5
[INFO] [stderr]     |
[INFO] [stderr] 123 |     return Ok(captures[1].parse().unwrap());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(captures[1].parse().unwrap())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:129:5
[INFO] [stderr]     |
[INFO] [stderr] 129 |     return 2 + (2 * number_of_codepoints as u16);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `2 + (2 * number_of_codepoints as u16)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:135:5
[INFO] [stderr]     |
[INFO] [stderr] 135 |     return codepoints.iter().flat_map(|c| vec![0, *c]).collect::<Vec<u8>>();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `codepoints.iter().flat_map(|c| vec![0, *c]).collect::<Vec<u8>>()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:82:13
[INFO] [stderr]    |
[INFO] [stderr] 82 |             format!("Invalid colour format - only greyscale or indexed are supported")));
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid colour format - only greyscale or indexed are supported".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:27:21
[INFO] [stderr]    |
[INFO] [stderr] 27 |         Ok(glob) => return Ok(glob),
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(glob)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:28:19
[INFO] [stderr]    |
[INFO] [stderr] 28 |         Err(e) => return Err(format!("Error listing files: {}", e)),
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("Error listing files: {}", e))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:37:5
[INFO] [stderr]    |
[INFO] [stderr] 37 |     return v
[INFO] [stderr]    |     ^^^^^^^^ help: remove `return` as shown: `v`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:45:5
[INFO] [stderr]    |
[INFO] [stderr] 45 |     return v;
[INFO] [stderr]    |     ^^^^^^^^^ help: remove `return` as shown: `v`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:65:5
[INFO] [stderr]    |
[INFO] [stderr] 65 |     return Ok(result);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:112:5
[INFO] [stderr]     |
[INFO] [stderr] 112 |     return Ok(buf);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(buf)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:123:5
[INFO] [stderr]     |
[INFO] [stderr] 123 |     return Ok(captures[1].parse().unwrap());
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(captures[1].parse().unwrap())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:129:5
[INFO] [stderr]     |
[INFO] [stderr] 129 |     return 2 + (2 * number_of_codepoints as u16);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `2 + (2 * number_of_codepoints as u16)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:135:5
[INFO] [stderr]     |
[INFO] [stderr] 135 |     return codepoints.iter().flat_map(|c| vec![0, *c]).collect::<Vec<u8>>();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `codepoints.iter().flat_map(|c| vec![0, *c]).collect::<Vec<u8>>()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/main.rs:82:13
[INFO] [stderr]    |
[INFO] [stderr] 82 |             format!("Invalid colour format - only greyscale or indexed are supported")));
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Invalid colour format - only greyscale or indexed are supported".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 14.49s
[INFO] running `"docker" "inspect" "25f5edf176c8e89368ab4e330d9d56b1d70d7d99a916867a30c50aea74d00581"`
[INFO] running `"docker" "rm" "-f" "25f5edf176c8e89368ab4e330d9d56b1d70d7d99a916867a30c50aea74d00581"`
[INFO] [stdout] 25f5edf176c8e89368ab4e330d9d56b1d70d7d99a916867a30c50aea74d00581