[INFO] updating cached repository stpettersens/touch [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/stpettersens/touch [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/stpettersens/touch" "work/ex/clippy-test-run/sources/stable/gh/stpettersens/touch"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stpettersens/touch'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/stpettersens/touch" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stpettersens/touch"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stpettersens/touch'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 24bfeb6ff58aa38ebebe2d77e79339a74d0e3ffd [INFO] sha for GitHub repo stpettersens/touch: 24bfeb6ff58aa38ebebe2d77e79339a74d0e3ffd [INFO] validating manifest of stpettersens/touch on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stpettersens/touch on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stpettersens/touch [INFO] finished frobbing stpettersens/touch [INFO] frobbed toml for stpettersens/touch written to work/ex/clippy-test-run/sources/stable/gh/stpettersens/touch/Cargo.toml [INFO] started frobbing stpettersens/touch [INFO] finished frobbing stpettersens/touch [INFO] frobbed toml for stpettersens/touch written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stpettersens/touch/Cargo.toml [INFO] crate stpettersens/touch has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stpettersens/touch against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stpettersens/touch:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7b87a5d8933035075095cfccf6391e284f8c2c5a8ab1be1f02a8e57fbdb27306 [INFO] running `"docker" "start" "-a" "7b87a5d8933035075095cfccf6391e284f8c2c5a8ab1be1f02a8e57fbdb27306"` [INFO] [stderr] Checking clioptions v0.1.0 [INFO] [stderr] Checking litepattern v0.1.0 [INFO] [stderr] Checking time v0.1.36 [INFO] [stderr] Checking filetime v0.1.10 [INFO] [stderr] Checking touch v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | unit [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | let unit = match n { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | Some(unit) => unit as i32, [INFO] [stderr] 51 | | None => 0 as i32, [INFO] [stderr] 52 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | timestamp [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:80:21 [INFO] [stderr] | [INFO] [stderr] 80 | let timestamp = match n { [INFO] [stderr] | _____________________^ [INFO] [stderr] 81 | | Some(timestamp) => timestamp as i64, [INFO] [stderr] 82 | | None => -1 as i64, [INFO] [stderr] 83 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | unit [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:49:16 [INFO] [stderr] | [INFO] [stderr] 49 | let unit = match n { [INFO] [stderr] | ________________^ [INFO] [stderr] 50 | | Some(unit) => unit as i32, [INFO] [stderr] 51 | | None => 0 as i32, [INFO] [stderr] 52 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/main.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | timestamp [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/main.rs:80:21 [INFO] [stderr] | [INFO] [stderr] 80 | let timestamp = match n { [INFO] [stderr] | _____________________^ [INFO] [stderr] 81 | | Some(timestamp) => timestamp as i64, [INFO] [stderr] 82 | | None => -1 as i64, [INFO] [stderr] 83 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/main.rs:87:1 [INFO] [stderr] | [INFO] [stderr] 87 | / fn touch(program: &str, file: &str, create: bool, access: bool, modify: bool, [INFO] [stderr] 88 | | rfile: String, timestamp: String, unix: bool, log: bool) { [INFO] [stderr] 89 | | let touchf = "__touch_file__"; [INFO] [stderr] 90 | | let p = Path::new(file); [INFO] [stderr] ... | [INFO] [stderr] 139 | | exit(0); [INFO] [stderr] 140 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/main.rs:87:1 [INFO] [stderr] | [INFO] [stderr] 87 | / fn touch(program: &str, file: &str, create: bool, access: bool, modify: bool, [INFO] [stderr] 88 | | rfile: String, timestamp: String, unix: bool, log: bool) { [INFO] [stderr] 89 | | let touchf = "__touch_file__"; [INFO] [stderr] 90 | | let p = Path::new(file); [INFO] [stderr] ... | [INFO] [stderr] 139 | | exit(0); [INFO] [stderr] 140 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.69s [INFO] running `"docker" "inspect" "7b87a5d8933035075095cfccf6391e284f8c2c5a8ab1be1f02a8e57fbdb27306"` [INFO] running `"docker" "rm" "-f" "7b87a5d8933035075095cfccf6391e284f8c2c5a8ab1be1f02a8e57fbdb27306"` [INFO] [stdout] 7b87a5d8933035075095cfccf6391e284f8c2c5a8ab1be1f02a8e57fbdb27306