[INFO] updating cached repository sticnarf/k-nucleotide [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sticnarf/k-nucleotide [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sticnarf/k-nucleotide" "work/ex/clippy-test-run/sources/stable/gh/sticnarf/k-nucleotide"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sticnarf/k-nucleotide'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sticnarf/k-nucleotide" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sticnarf/k-nucleotide"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sticnarf/k-nucleotide'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f8a803f422fd3a54b30a934e3cc6d7af852cb757 [INFO] sha for GitHub repo sticnarf/k-nucleotide: f8a803f422fd3a54b30a934e3cc6d7af852cb757 [INFO] validating manifest of sticnarf/k-nucleotide on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sticnarf/k-nucleotide on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sticnarf/k-nucleotide [INFO] finished frobbing sticnarf/k-nucleotide [INFO] frobbed toml for sticnarf/k-nucleotide written to work/ex/clippy-test-run/sources/stable/gh/sticnarf/k-nucleotide/Cargo.toml [INFO] started frobbing sticnarf/k-nucleotide [INFO] finished frobbing sticnarf/k-nucleotide [INFO] frobbed toml for sticnarf/k-nucleotide written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sticnarf/k-nucleotide/Cargo.toml [INFO] crate sticnarf/k-nucleotide has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sticnarf/k-nucleotide against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sticnarf/k-nucleotide:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f2ae789fde7b9482f216948a4d4394477e7ac440ebbb8bed5f1e489be6564b42 [INFO] running `"docker" "start" "-a" "f2ae789fde7b9482f216948a4d4394477e7ac440ebbb8bed5f1e489be6564b42"` [INFO] [stderr] Checking spin v0.4.5 [INFO] [stderr] Checking fnv v1.0.5 [INFO] [stderr] Checking num_cpus v1.2.1 [INFO] [stderr] Checking deque v0.3.1 [INFO] [stderr] Checking concurrent-hashmap v0.2.2 [INFO] [stderr] Checking rayon v0.6.0 [INFO] [stderr] Checking k-nucleotide v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:105:5 [INFO] [stderr] | [INFO] [stderr] 105 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | const TASK_SIZE: usize = 5000000; [INFO] [stderr] | ^^^^^^^ help: consider: `5_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | const LOOKUPS: [&'static str; 5] = ["GGT", "GGTA", "GGTATT", "GGTATTTTAATT", "GGTATTTTAATTTATAGT"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | const TASK_SIZE: usize = 5000000; [INFO] [stderr] | ^^^^^^^ help: consider: `5_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:22:18 [INFO] [stderr] | [INFO] [stderr] 22 | const LOOKUPS: [&'static str; 5] = ["GGT", "GGTA", "GGTATT", "GGTATTTTAATT", "GGTATTTTAATTTATAGT"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:31:40 [INFO] [stderr] | [INFO] [stderr] 31 | if len > 2 && data.starts_with(">TH".as_bytes()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b">TH"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:45:56 [INFO] [stderr] | [INFO] [stderr] 45 | s.as_bytes().iter().fold(0, |acc, &x| (acc << 2) + ENCODING_TABLE[x as usize] as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(ENCODING_TABLE[x as usize])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:71:73 [INFO] [stderr] | [INFO] [stderr] 71 | self.value = (self.value * (1 << 2)) % (1 << (2 * self.size)) + (c as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:87:11 [INFO] [stderr] | [INFO] [stderr] 87 | while input.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:127:43 [INFO] [stderr] | [INFO] [stderr] 127 | parse(&data[head..tail], len, tables.get(&len).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tables[&len]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:129:12 [INFO] [stderr] | [INFO] [stderr] 129 | report(tables.get(&1).unwrap(), SEQ_LENS[0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tables[&1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:130:12 [INFO] [stderr] | [INFO] [stderr] 130 | report(tables.get(&2).unwrap(), SEQ_LENS[1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tables[&2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:132:21 [INFO] [stderr] | [INFO] [stderr] 132 | let table = tables.get(&pattern.len()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tables[&pattern.len()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/main.rs:31:40 [INFO] [stderr] | [INFO] [stderr] 31 | if len > 2 && data.starts_with(">TH".as_bytes()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b">TH"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:45:56 [INFO] [stderr] | [INFO] [stderr] 45 | s.as_bytes().iter().fold(0, |acc, &x| (acc << 2) + ENCODING_TABLE[x as usize] as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(ENCODING_TABLE[x as usize])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:71:73 [INFO] [stderr] | [INFO] [stderr] 71 | self.value = (self.value * (1 << 2)) % (1 << (2 * self.size)) + (c as u64); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(c)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:87:11 [INFO] [stderr] | [INFO] [stderr] 87 | while input.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!input.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:127:43 [INFO] [stderr] | [INFO] [stderr] 127 | parse(&data[head..tail], len, tables.get(&len).unwrap().clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tables[&len]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:129:12 [INFO] [stderr] | [INFO] [stderr] 129 | report(tables.get(&1).unwrap(), SEQ_LENS[0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tables[&1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:130:12 [INFO] [stderr] | [INFO] [stderr] 130 | report(tables.get(&2).unwrap(), SEQ_LENS[1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tables[&2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:132:21 [INFO] [stderr] | [INFO] [stderr] 132 | let table = tables.get(&pattern.len()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tables[&pattern.len()]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.36s [INFO] running `"docker" "inspect" "f2ae789fde7b9482f216948a4d4394477e7ac440ebbb8bed5f1e489be6564b42"` [INFO] running `"docker" "rm" "-f" "f2ae789fde7b9482f216948a4d4394477e7ac440ebbb8bed5f1e489be6564b42"` [INFO] [stdout] f2ae789fde7b9482f216948a4d4394477e7ac440ebbb8bed5f1e489be6564b42