[INFO] updating cached repository steveklabnik/adventure [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/steveklabnik/adventure [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/steveklabnik/adventure" "work/ex/clippy-test-run/sources/stable/gh/steveklabnik/adventure"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/steveklabnik/adventure'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/steveklabnik/adventure" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/steveklabnik/adventure"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/steveklabnik/adventure'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a318dd0e951a1c28dbf9198dbef286dbc04036a2 [INFO] sha for GitHub repo steveklabnik/adventure: a318dd0e951a1c28dbf9198dbef286dbc04036a2 [INFO] validating manifest of steveklabnik/adventure on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of steveklabnik/adventure on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing steveklabnik/adventure [INFO] finished frobbing steveklabnik/adventure [INFO] frobbed toml for steveklabnik/adventure written to work/ex/clippy-test-run/sources/stable/gh/steveklabnik/adventure/Cargo.toml [INFO] started frobbing steveklabnik/adventure [INFO] finished frobbing steveklabnik/adventure [INFO] frobbed toml for steveklabnik/adventure written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/steveklabnik/adventure/Cargo.toml [INFO] crate steveklabnik/adventure has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting steveklabnik/adventure against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/steveklabnik/adventure:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3ca70bf7ccd6ec5660d410f16d9d0c27282690e748923607ef95d57707de40fd [INFO] running `"docker" "start" "-a" "3ca70bf7ccd6ec5660d410f16d9d0c27282690e748923607ef95d57707de40fd"` [INFO] [stderr] Checking adventure v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `direction` [INFO] [stderr] --> src/main.rs:67:25 [INFO] [stderr] | [INFO] [stderr] 67 | fn is_locked(&self, direction: Direction) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_direction` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `direction` [INFO] [stderr] --> src/main.rs:67:25 [INFO] [stderr] | [INFO] [stderr] 67 | fn is_locked(&self, direction: Direction) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_direction` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `items` [INFO] [stderr] --> src/main.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | items: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `name` [INFO] [stderr] --> src/main.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | name: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | self.exits.iter().find(|e| e.can_go(&direction)).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|e| e.can_go(&direction)).is_some()` with `any(|e| e.can_go(&direction))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: field is never used: `items` [INFO] [stderr] --> src/main.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | items: Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `name` [INFO] [stderr] --> src/main.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | name: String, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | self.exits.iter().find(|e| e.can_go(&direction)).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::search_is_some)] on by default [INFO] [stderr] = note: replace `find(|e| e.can_go(&direction)).is_some()` with `any(|e| e.can_go(&direction))` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | self.exits.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.exits.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | self.exits.iter().find(|e| e.locked).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|e| e.locked).is_some()` with `any(|e| e.locked)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:155:30 [INFO] [stderr] | [INFO] [stderr] 155 | current_room = enter(rooms.get_mut(current_room).unwrap()).unwrap_or(current_room); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `rooms[current_room]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | self.exits.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.exits.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`. [INFO] [stderr] --> src/main.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | self.exits.iter().find(|e| e.locked).is_some() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: replace `find(|e| e.locked).is_some()` with `any(|e| e.locked)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:197:9 [INFO] [stderr] | [INFO] [stderr] 197 | / io::stdin() [INFO] [stderr] 198 | | .read_line(&mut input) [INFO] [stderr] 199 | | .ok() [INFO] [stderr] 200 | | .expect("Failed to read line"); [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:155:30 [INFO] [stderr] | [INFO] [stderr] 155 | current_room = enter(rooms.get_mut(current_room).unwrap()).unwrap_or(current_room); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `rooms[current_room]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:197:9 [INFO] [stderr] | [INFO] [stderr] 197 | / io::stdin() [INFO] [stderr] 198 | | .read_line(&mut input) [INFO] [stderr] 199 | | .ok() [INFO] [stderr] 200 | | .expect("Failed to read line"); [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.58s [INFO] running `"docker" "inspect" "3ca70bf7ccd6ec5660d410f16d9d0c27282690e748923607ef95d57707de40fd"` [INFO] running `"docker" "rm" "-f" "3ca70bf7ccd6ec5660d410f16d9d0c27282690e748923607ef95d57707de40fd"` [INFO] [stdout] 3ca70bf7ccd6ec5660d410f16d9d0c27282690e748923607ef95d57707de40fd