[INFO] updating cached repository stevefranchak/backup-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/stevefranchak/backup-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/stevefranchak/backup-rs" "work/ex/clippy-test-run/sources/stable/gh/stevefranchak/backup-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stevefranchak/backup-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/stevefranchak/backup-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevefranchak/backup-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevefranchak/backup-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c18859a068bd8829dfb48cc3e9425904b0dd0ac1 [INFO] sha for GitHub repo stevefranchak/backup-rs: c18859a068bd8829dfb48cc3e9425904b0dd0ac1 [INFO] validating manifest of stevefranchak/backup-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stevefranchak/backup-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stevefranchak/backup-rs [INFO] finished frobbing stevefranchak/backup-rs [INFO] frobbed toml for stevefranchak/backup-rs written to work/ex/clippy-test-run/sources/stable/gh/stevefranchak/backup-rs/Cargo.toml [INFO] started frobbing stevefranchak/backup-rs [INFO] finished frobbing stevefranchak/backup-rs [INFO] frobbed toml for stevefranchak/backup-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevefranchak/backup-rs/Cargo.toml [INFO] crate stevefranchak/backup-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stevefranchak/backup-rs against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stevefranchak/backup-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ce7ed3cbb546ffc142ef98995e3cd794c83762cb31e324008785bd5119fdaaa3 [INFO] running `"docker" "start" "-a" "ce7ed3cbb546ffc142ef98995e3cd794c83762cb31e324008785bd5119fdaaa3"` [INFO] [stderr] Checking backup v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utilities/iterator_list.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | list: list, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `list` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utilities/iterator_list.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | list: list, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `list` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/config/mod.rs:97:12 [INFO] [stderr] | [INFO] [stderr] 97 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 98 | | if !config.should_show_help() { [INFO] [stderr] 99 | | return Err("missing file operand".to_string()); [INFO] [stderr] 100 | | } [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 97 | } else if !config.should_show_help() { [INFO] [stderr] 98 | return Err("missing file operand".to_string()); [INFO] [stderr] 99 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:13:19 [INFO] [stderr] | [INFO] [stderr] 13 | const PROG_NAME: &'static str = "backup"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/config/mod.rs:97:12 [INFO] [stderr] | [INFO] [stderr] 97 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 98 | | if !config.should_show_help() { [INFO] [stderr] 99 | | return Err("missing file operand".to_string()); [INFO] [stderr] 100 | | } [INFO] [stderr] 101 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 97 | } else if !config.should_show_help() { [INFO] [stderr] 98 | return Err("missing file operand".to_string()); [INFO] [stderr] 99 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:13:19 [INFO] [stderr] | [INFO] [stderr] 13 | const PROG_NAME: &'static str = "backup"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/config/cmd_line_parse.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / match self { [INFO] [stderr] 18 | | &ShortOpt(_) => true, [INFO] [stderr] 19 | | _ => false, [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 17 | match *self { [INFO] [stderr] 18 | ShortOpt(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/config/cmd_line_parse.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | / match self { [INFO] [stderr] 28 | | &LongOpt(_, _) => true, [INFO] [stderr] 29 | | _ => false, [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 27 | match *self { [INFO] [stderr] 28 | LongOpt(_, _) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/config/cmd_line_parse.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / match self { [INFO] [stderr] 38 | | &Positional(_) => true, [INFO] [stderr] 39 | | _ => false, [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 37 | match *self { [INFO] [stderr] 38 | Positional(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/config/cmd_line_parse.rs:56:30 [INFO] [stderr] | [INFO] [stderr] 56 | if token.starts_with("-") { // non-expensive check to avoid regex matching every iteration [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/config/mod.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | / match arg { [INFO] [stderr] 62 | | &ShortOpt(ref name) => { [INFO] [stderr] 63 | | match name.as_str() { [INFO] [stderr] 64 | | "t" => config.set_should_truncate(true), [INFO] [stderr] ... | [INFO] [stderr] 78 | | &Positional(ref operand) => operands.push(operand), [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 61 | match *arg { [INFO] [stderr] 62 | ShortOpt(ref name) => { [INFO] [stderr] 63 | match name.as_str() { [INFO] [stderr] 64 | "t" => config.set_should_truncate(true), [INFO] [stderr] 65 | _ => set_invalid_option(&mut invalid_option, Some(arg)), [INFO] [stderr] 66 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/config/mod.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / match invalid_option.unwrap() { [INFO] [stderr] 86 | | &ShortOpt(ref name) => return Err(format!("invalid option -- {}", name)), [INFO] [stderr] 87 | | &LongOpt(ref name, _) => return Err(format!("unrecognized option '{}'", name)), [INFO] [stderr] 88 | | _ => (), [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 85 | match *invalid_option.unwrap() { [INFO] [stderr] 86 | ShortOpt(ref name) => return Err(format!("invalid option -- {}", name)), [INFO] [stderr] 87 | LongOpt(ref name, _) => return Err(format!("unrecognized option '{}'", name)), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config/mod.rs:95:8 [INFO] [stderr] | [INFO] [stderr] 95 | if operands.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!operands.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/config/mod.rs:96:29 [INFO] [stderr] | [INFO] [stderr] 96 | config.set_filename(operands.get(0).unwrap().to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&operands[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:58:26 [INFO] [stderr] | [INFO] [stderr] 58 | fn print_prog_error(err: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/config/cmd_line_parse.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / match self { [INFO] [stderr] 18 | | &ShortOpt(_) => true, [INFO] [stderr] 19 | | _ => false, [INFO] [stderr] 20 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 17 | match *self { [INFO] [stderr] 18 | ShortOpt(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/config/cmd_line_parse.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | / match self { [INFO] [stderr] 28 | | &LongOpt(_, _) => true, [INFO] [stderr] 29 | | _ => false, [INFO] [stderr] 30 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 27 | match *self { [INFO] [stderr] 28 | LongOpt(_, _) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/config/cmd_line_parse.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | / match self { [INFO] [stderr] 38 | | &Positional(_) => true, [INFO] [stderr] 39 | | _ => false, [INFO] [stderr] 40 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 37 | match *self { [INFO] [stderr] 38 | Positional(_) => true, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/config/cmd_line_parse.rs:56:30 [INFO] [stderr] | [INFO] [stderr] 56 | if token.starts_with("-") { // non-expensive check to avoid regex matching every iteration [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/config/mod.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | / match arg { [INFO] [stderr] 62 | | &ShortOpt(ref name) => { [INFO] [stderr] 63 | | match name.as_str() { [INFO] [stderr] 64 | | "t" => config.set_should_truncate(true), [INFO] [stderr] ... | [INFO] [stderr] 78 | | &Positional(ref operand) => operands.push(operand), [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 61 | match *arg { [INFO] [stderr] 62 | ShortOpt(ref name) => { [INFO] [stderr] 63 | match name.as_str() { [INFO] [stderr] 64 | "t" => config.set_should_truncate(true), [INFO] [stderr] 65 | _ => set_invalid_option(&mut invalid_option, Some(arg)), [INFO] [stderr] 66 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/config/mod.rs:85:9 [INFO] [stderr] | [INFO] [stderr] 85 | / match invalid_option.unwrap() { [INFO] [stderr] 86 | | &ShortOpt(ref name) => return Err(format!("invalid option -- {}", name)), [INFO] [stderr] 87 | | &LongOpt(ref name, _) => return Err(format!("unrecognized option '{}'", name)), [INFO] [stderr] 88 | | _ => (), [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 85 | match *invalid_option.unwrap() { [INFO] [stderr] 86 | ShortOpt(ref name) => return Err(format!("invalid option -- {}", name)), [INFO] [stderr] 87 | LongOpt(ref name, _) => return Err(format!("unrecognized option '{}'", name)), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config/mod.rs:95:8 [INFO] [stderr] | [INFO] [stderr] 95 | if operands.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!operands.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/config/mod.rs:96:29 [INFO] [stderr] | [INFO] [stderr] 96 | config.set_filename(operands.get(0).unwrap().to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&operands[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:58:26 [INFO] [stderr] | [INFO] [stderr] 58 | fn print_prog_error(err: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.26s [INFO] running `"docker" "inspect" "ce7ed3cbb546ffc142ef98995e3cd794c83762cb31e324008785bd5119fdaaa3"` [INFO] running `"docker" "rm" "-f" "ce7ed3cbb546ffc142ef98995e3cd794c83762cb31e324008785bd5119fdaaa3"` [INFO] [stdout] ce7ed3cbb546ffc142ef98995e3cd794c83762cb31e324008785bd5119fdaaa3