[INFO] updating cached repository stephenpearson/project-euler-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/stephenpearson/project-euler-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/stephenpearson/project-euler-rust" "work/ex/clippy-test-run/sources/stable/gh/stephenpearson/project-euler-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stephenpearson/project-euler-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/stephenpearson/project-euler-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stephenpearson/project-euler-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stephenpearson/project-euler-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 191cf23a83a35d2d125e8511785cfd96e4eda9ff [INFO] sha for GitHub repo stephenpearson/project-euler-rust: 191cf23a83a35d2d125e8511785cfd96e4eda9ff [INFO] validating manifest of stephenpearson/project-euler-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stephenpearson/project-euler-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stephenpearson/project-euler-rust [INFO] finished frobbing stephenpearson/project-euler-rust [INFO] frobbed toml for stephenpearson/project-euler-rust written to work/ex/clippy-test-run/sources/stable/gh/stephenpearson/project-euler-rust/Cargo.toml [INFO] started frobbing stephenpearson/project-euler-rust [INFO] finished frobbing stephenpearson/project-euler-rust [INFO] frobbed toml for stephenpearson/project-euler-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stephenpearson/project-euler-rust/Cargo.toml [INFO] crate stephenpearson/project-euler-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stephenpearson/project-euler-rust against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stephenpearson/project-euler-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 678e51d0b3f85ecd85ac602b3aad5e31245a7489facaba4009236105f4460102 [INFO] running `"docker" "start" "-a" "678e51d0b3f85ecd85ac602b3aad5e31245a7489facaba4009236105f4460102"` [INFO] [stderr] Checking euler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/common/prime.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/common/prime.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/common/prime.rs:37:28 [INFO] [stderr] | [INFO] [stderr] 37 | Ordering::Equal => return x, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/common/prime.rs:38:27 [INFO] [stderr] | [INFO] [stderr] 38 | Ordering::Less => return gcd(x, y - x), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `gcd(x, y - x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/common/prime.rs:39:30 [INFO] [stderr] | [INFO] [stderr] 39 | Ordering::Greater => return gcd(x - y, y) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `gcd(x - y, y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/p2/init.rs:7:16 [INFO] [stderr] | [INFO] [stderr] 7 | while t2 < 4000000 { [INFO] [stderr] | ^^^^^^^ help: consider: `4_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/p3/init.rs:6:17 [INFO] [stderr] | [INFO] [stderr] 6 | let value = 600851475143; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `600_851_475_143` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/p4/init.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | return reversed == value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `reversed == value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/p5/init.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/p126/init.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | return 2 * x + 2 * y + 4 * (l - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `2 * x + 2 * y + 4 * (l - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/p126/init.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return total; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/p126/init.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return 2 * cap(x, y, l) + z * ring(x, y, l); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `2 * cap(x, y, l) + z * ring(x, y, l)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/common/prime.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/common/prime.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/common/prime.rs:37:28 [INFO] [stderr] | [INFO] [stderr] 37 | Ordering::Equal => return x, [INFO] [stderr] | ^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/common/prime.rs:38:27 [INFO] [stderr] | [INFO] [stderr] 38 | Ordering::Less => return gcd(x, y - x), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `gcd(x, y - x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/common/prime.rs:39:30 [INFO] [stderr] | [INFO] [stderr] 39 | Ordering::Greater => return gcd(x - y, y) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `gcd(x - y, y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/p2/init.rs:7:16 [INFO] [stderr] | [INFO] [stderr] 7 | while t2 < 4000000 { [INFO] [stderr] | ^^^^^^^ help: consider: `4_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/p3/init.rs:6:17 [INFO] [stderr] | [INFO] [stderr] 6 | let value = 600851475143; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `600_851_475_143` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/p4/init.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | return reversed == value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `reversed == value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/p5/init.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/p126/init.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | return 2 * x + 2 * y + 4 * (l - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `2 * x + 2 * y + 4 * (l - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/p126/init.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return total; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/p126/init.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return 2 * cap(x, y, l) + z * ring(x, y, l); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `2 * cap(x, y, l) + z * ring(x, y, l)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/p2/init.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | t2 = t1 + t2; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `t2 += t1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/p4/init.rs:5:19 [INFO] [stderr] | [INFO] [stderr] 5 | let mut acc = value.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/p4/init.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | acc = acc / 10; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `acc /= 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/p126/init.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | fn show(count: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/p2/init.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | t2 = t1 + t2; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `t2 += t1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/p4/init.rs:5:19 [INFO] [stderr] | [INFO] [stderr] 5 | let mut acc = value.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/p4/init.rs:8:9 [INFO] [stderr] | [INFO] [stderr] 8 | acc = acc / 10; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `acc /= 10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/p126/init.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | fn show(count: &Vec) { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.99s [INFO] running `"docker" "inspect" "678e51d0b3f85ecd85ac602b3aad5e31245a7489facaba4009236105f4460102"` [INFO] running `"docker" "rm" "-f" "678e51d0b3f85ecd85ac602b3aad5e31245a7489facaba4009236105f4460102"` [INFO] [stdout] 678e51d0b3f85ecd85ac602b3aad5e31245a7489facaba4009236105f4460102