[INFO] updating cached repository steffenhaug/lie-parser
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/steffenhaug/lie-parser
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/steffenhaug/lie-parser" "work/ex/clippy-test-run/sources/stable/gh/steffenhaug/lie-parser"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/steffenhaug/lie-parser'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/steffenhaug/lie-parser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/steffenhaug/lie-parser"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/steffenhaug/lie-parser'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 574c4cb19e9bd3c726aa7b1520a625ed33757218
[INFO] sha for GitHub repo steffenhaug/lie-parser: 574c4cb19e9bd3c726aa7b1520a625ed33757218
[INFO] validating manifest of steffenhaug/lie-parser on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of steffenhaug/lie-parser on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing steffenhaug/lie-parser
[INFO] finished frobbing steffenhaug/lie-parser
[INFO] frobbed toml for steffenhaug/lie-parser written to work/ex/clippy-test-run/sources/stable/gh/steffenhaug/lie-parser/Cargo.toml
[INFO] started frobbing steffenhaug/lie-parser
[INFO] finished frobbing steffenhaug/lie-parser
[INFO] frobbed toml for steffenhaug/lie-parser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/steffenhaug/lie-parser/Cargo.toml
[INFO] crate steffenhaug/lie-parser has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting steffenhaug/lie-parser against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/steffenhaug/lie-parser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 91a89e94d5f566c7a3cf5f84643023e817769aff5d2348559b49d90712ef63a1
[INFO] running `"docker" "start" "-a" "91a89e94d5f566c7a3cf5f84643023e817769aff5d2348559b49d90712ef63a1"`
[INFO] [stderr]     Checking bytecount v0.1.7
[INFO] [stderr]     Checking termion v1.5.1
[INFO] [stderr]     Checking liner v0.4.4
[INFO] [stderr]     Checking parser v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/stream.rs:66:9
[INFO] [stderr]    |
[INFO] [stderr] 66 |         return c == a;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `c == a`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/stream.rs:72:21
[INFO] [stderr]    |
[INFO] [stderr] 72 |             None => return false
[INFO] [stderr]    |                     ^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/stream.rs:66:9
[INFO] [stderr]    |
[INFO] [stderr] 66 |         return c == a;
[INFO] [stderr]    |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `c == a`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/stream.rs:72:21
[INFO] [stderr]    |
[INFO] [stderr] 72 |             None => return false
[INFO] [stderr]    |                     ^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/stream.rs:22:35
[INFO] [stderr]    |
[INFO] [stderr] 22 |     pub fn from_string<'s>(input: &'s String) -> Stream<'s> {
[INFO] [stderr]    |                                   ^^^^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/stream.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 | /     pub fn from_string<'s>(input: &'s String) -> Stream<'s> {
[INFO] [stderr] 23 | |         Stream {
[INFO] [stderr] 24 | |             it: input.chars().peekable(),
[INFO] [stderr] 25 | |             pushback: None,
[INFO] [stderr] ...  |
[INFO] [stderr] 28 | |         }
[INFO] [stderr] 29 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `<Stream>::from_string` doesn't need a mutable reference
[INFO] [stderr]    --> src/lexer.rs:220:46
[INFO] [stderr]     |
[INFO] [stderr] 220 |         let mut stream = Stream::from_string(&mut filecontents);
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 36
[INFO] [stderr]    --> src/lexer.rs:381:1
[INFO] [stderr]     |
[INFO] [stderr] 381 | / fn scan(stream: &mut Stream) -> ScanResult<Token> {
[INFO] [stderr] 382 | |     // loop lets us reuse the current stack frame
[INFO] [stderr] 383 | |     // instead of recursively calling scan in the
[INFO] [stderr] 384 | |     // cases where we don't get a token from
[INFO] [stderr] ...   |
[INFO] [stderr] 520 | |     };
[INFO] [stderr] 521 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/parser.rs:191:9
[INFO] [stderr]     |
[INFO] [stderr] 191 |         format!("{}", self.id)
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.id.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: unused label `'munch`
[INFO] [stderr]    --> src/parser.rs:501:9
[INFO] [stderr]     |
[INFO] [stderr] 501 | /         'munch: while !self.peek_is(&Lexeme::EOF) {
[INFO] [stderr] 502 | |             let smt = self.statement()?;
[INFO] [stderr] 503 | |             smts.push(Box::new(smt));
[INFO] [stderr] 504 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_label)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label
[INFO] [stderr] 
[INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead
[INFO] [stderr]    --> src/parser.rs:584:9
[INFO] [stderr]     |
[INFO] [stderr] 584 | /         self.tokens.peek().map_or(None, |t| {
[INFO] [stderr] 585 | |             Some(*t)
[INFO] [stderr] 586 | |         })
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_or_none)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none
[INFO] [stderr] help: try using and_then instead
[INFO] [stderr]     |
[INFO] [stderr] 584 |         self.tokens.peek().and_then(|t| {
[INFO] [stderr] 585 |             Some(*t)
[INFO] [stderr] 586 |         })
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/parser.rs:626:1
[INFO] [stderr]     |
[INFO] [stderr] 626 | / pub fn parse<'a>(tokens: Iter<'a, Token>) -> Result<Vec<Box<Expr>>, String> {
[INFO] [stderr] 627 | |     let mut parser = Parser::new(tokens);
[INFO] [stderr] 628 | |     parser.statements()
[INFO] [stderr] 629 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/stream.rs:22:35
[INFO] [stderr]    |
[INFO] [stderr] 22 |     pub fn from_string<'s>(input: &'s String) -> Stream<'s> {
[INFO] [stderr]    |                                   ^^^^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/stream.rs:22:5
[INFO] [stderr]    |
[INFO] [stderr] 22 | /     pub fn from_string<'s>(input: &'s String) -> Stream<'s> {
[INFO] [stderr] 23 | |         Stream {
[INFO] [stderr] 24 | |             it: input.chars().peekable(),
[INFO] [stderr] 25 | |             pushback: None,
[INFO] [stderr] ...  |
[INFO] [stderr] 28 | |         }
[INFO] [stderr] 29 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `<Stream>::from_string` doesn't need a mutable reference
[INFO] [stderr]    --> src/lexer.rs:220:46
[INFO] [stderr]     |
[INFO] [stderr] 220 |         let mut stream = Stream::from_string(&mut filecontents);
[INFO] [stderr]     |                                              ^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: the function has a cyclomatic complexity of 36
[INFO] [stderr]    --> src/lexer.rs:381:1
[INFO] [stderr]     |
[INFO] [stderr] 381 | / fn scan(stream: &mut Stream) -> ScanResult<Token> {
[INFO] [stderr] 382 | |     // loop lets us reuse the current stack frame
[INFO] [stderr] 383 | |     // instead of recursively calling scan in the
[INFO] [stderr] 384 | |     // cases where we don't get a token from
[INFO] [stderr] ...   |
[INFO] [stderr] 520 | |     };
[INFO] [stderr] 521 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cyclomatic_complexity)] on by default
[INFO] [stderr]     = help: you could split it up into multiple smaller functions
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/parser.rs:191:9
[INFO] [stderr]     |
[INFO] [stderr] 191 |         format!("{}", self.id)
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.id.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: unused label `'munch`
[INFO] [stderr]    --> src/parser.rs:501:9
[INFO] [stderr]     |
[INFO] [stderr] 501 | /         'munch: while !self.peek_is(&Lexeme::EOF) {
[INFO] [stderr] 502 | |             let smt = self.statement()?;
[INFO] [stderr] 503 | |             smts.push(Box::new(smt));
[INFO] [stderr] 504 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_label)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label
[INFO] [stderr] 
[INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead
[INFO] [stderr]    --> src/parser.rs:584:9
[INFO] [stderr]     |
[INFO] [stderr] 584 | /         self.tokens.peek().map_or(None, |t| {
[INFO] [stderr] 585 | |             Some(*t)
[INFO] [stderr] 586 | |         })
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_or_none)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none
[INFO] [stderr] help: try using and_then instead
[INFO] [stderr]     |
[INFO] [stderr] 584 |         self.tokens.peek().and_then(|t| {
[INFO] [stderr] 585 |             Some(*t)
[INFO] [stderr] 586 |         })
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/parser.rs:626:1
[INFO] [stderr]     |
[INFO] [stderr] 626 | / pub fn parse<'a>(tokens: Iter<'a, Token>) -> Result<Vec<Box<Expr>>, String> {
[INFO] [stderr] 627 | |     let mut parser = Parser::new(tokens);
[INFO] [stderr] 628 | |     parser.statements()
[INFO] [stderr] 629 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.42s
[INFO] running `"docker" "inspect" "91a89e94d5f566c7a3cf5f84643023e817769aff5d2348559b49d90712ef63a1"`
[INFO] running `"docker" "rm" "-f" "91a89e94d5f566c7a3cf5f84643023e817769aff5d2348559b49d90712ef63a1"`
[INFO] [stdout] 91a89e94d5f566c7a3cf5f84643023e817769aff5d2348559b49d90712ef63a1