[INFO] updating cached repository statianzo/imposters [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/statianzo/imposters [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/statianzo/imposters" "work/ex/clippy-test-run/sources/stable/gh/statianzo/imposters"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/statianzo/imposters'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/statianzo/imposters" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/statianzo/imposters"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/statianzo/imposters'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 344a5027ba57464a424c1906376445b6e208cb57 [INFO] sha for GitHub repo statianzo/imposters: 344a5027ba57464a424c1906376445b6e208cb57 [INFO] validating manifest of statianzo/imposters on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of statianzo/imposters on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing statianzo/imposters [INFO] finished frobbing statianzo/imposters [INFO] frobbed toml for statianzo/imposters written to work/ex/clippy-test-run/sources/stable/gh/statianzo/imposters/Cargo.toml [INFO] started frobbing statianzo/imposters [INFO] finished frobbing statianzo/imposters [INFO] frobbed toml for statianzo/imposters written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/statianzo/imposters/Cargo.toml [INFO] crate statianzo/imposters has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting statianzo/imposters against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/statianzo/imposters:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d12e1f7824a3059b738bc6954a3e82b005d1975e89fd35edce61d1eed1b76279 [INFO] running `"docker" "start" "-a" "d12e1f7824a3059b738bc6954a3e82b005d1975e89fd35edce61d1eed1b76279"` [INFO] [stderr] Compiling regex v1.0.1 [INFO] [stderr] Checking termcolor v0.3.6 [INFO] [stderr] Checking imposters v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking humantime v1.1.1 [INFO] [stderr] Checking log v0.4.3 [INFO] [stderr] Checking rand v0.5.3 [INFO] [stderr] Checking aho-corasick v0.6.5 [INFO] [stderr] error[E0602]: unknown lint: `clippy::into_iter_on_array` [INFO] [stderr] | [INFO] [stderr] = note: requested on the command line with `-D clippy::into_iter_on_array` [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0602`. [INFO] [stderr] error: Could not compile `regex`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ch04_machinery/turing.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | return tape; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `tape` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ch05_bigo/search.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `arr`. [INFO] [stderr] --> src/ch05_bigo/search.rs:5:14 [INFO] [stderr] | [INFO] [stderr] 5 | for i in 0..arr.len() { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 5 | for in &arr { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ch06_datastructures::graph::Graph<'a>` [INFO] [stderr] --> src/ch06_datastructures/graph.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Self { [INFO] [stderr] 11 | | Graph { edges: vec![] } [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `ch06_datastructures::heap::Heap` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/ch06_datastructures/heap.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | / impl Heap { [INFO] [stderr] 13 | | pub fn new() -> Self { [INFO] [stderr] 14 | | Heap { [INFO] [stderr] 15 | | elements: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 63 | | } [INFO] [stderr] 64 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ch06_datastructures::heap::Heap` [INFO] [stderr] --> src/ch06_datastructures/heap.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn new() -> Self { [INFO] [stderr] 14 | | Heap { [INFO] [stderr] 15 | | elements: Vec::new(), [INFO] [stderr] 16 | | } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ch06_datastructures::linked_im::LinkedList` [INFO] [stderr] --> src/ch06_datastructures/linked_im.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> LinkedList { [INFO] [stderr] 17 | | LinkedList { head: Option::None } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `ch06_datastructures::queue::Queue` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/ch06_datastructures/queue.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / impl Queue { [INFO] [stderr] 17 | | pub fn new() -> Self { [INFO] [stderr] 18 | | Queue { [INFO] [stderr] 19 | | length: 0, [INFO] [stderr] ... | [INFO] [stderr] 61 | | } [INFO] [stderr] 62 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ch06_datastructures::queue::Queue` [INFO] [stderr] --> src/ch06_datastructures/queue.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Self { [INFO] [stderr] 18 | | Queue { [INFO] [stderr] 19 | | length: 0, [INFO] [stderr] 20 | | front: Option::None, [INFO] [stderr] 21 | | rear: ptr::null_mut(), [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | impl Default for ch06_datastructures::queue::Queue { [INFO] [stderr] 17 | fn default() -> Self { [INFO] [stderr] 18 | Self::new() [INFO] [stderr] 19 | } [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ch06_datastructures/queue.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | self.length = self.length + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.length += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ch10_patterns::builder::StringBuilder<'a>` [INFO] [stderr] --> src/ch10_patterns/builder.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Self { [INFO] [stderr] 12 | | StringBuilder { segments: vec![] } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ch10_patterns::factory::Customer` [INFO] [stderr] --> src/ch10_patterns/factory.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> Self { [INFO] [stderr] 10 | | Customer { [INFO] [stderr] 11 | | name: String::new(), [INFO] [stderr] 12 | | } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "d12e1f7824a3059b738bc6954a3e82b005d1975e89fd35edce61d1eed1b76279"` [INFO] running `"docker" "rm" "-f" "d12e1f7824a3059b738bc6954a3e82b005d1975e89fd35edce61d1eed1b76279"` [INFO] [stdout] d12e1f7824a3059b738bc6954a3e82b005d1975e89fd35edce61d1eed1b76279