[INFO] updating cached repository stanislaw/alltext [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/stanislaw/alltext [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/stanislaw/alltext" "work/ex/clippy-test-run/sources/stable/gh/stanislaw/alltext"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stanislaw/alltext'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/stanislaw/alltext" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stanislaw/alltext"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stanislaw/alltext'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 31b52633af74b3416e0d37887838c9f11e609734 [INFO] sha for GitHub repo stanislaw/alltext: 31b52633af74b3416e0d37887838c9f11e609734 [INFO] validating manifest of stanislaw/alltext on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stanislaw/alltext on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stanislaw/alltext [INFO] finished frobbing stanislaw/alltext [INFO] frobbed toml for stanislaw/alltext written to work/ex/clippy-test-run/sources/stable/gh/stanislaw/alltext/Cargo.toml [INFO] started frobbing stanislaw/alltext [INFO] finished frobbing stanislaw/alltext [INFO] frobbed toml for stanislaw/alltext written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stanislaw/alltext/Cargo.toml [INFO] crate stanislaw/alltext has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stanislaw/alltext against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stanislaw/alltext:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4ab2a46b7becd0013219bf95488fa671e1dcca5dfa0a33e2499fe4dab9e22705 [INFO] running `"docker" "start" "-a" "4ab2a46b7becd0013219bf95488fa671e1dcca5dfa0a33e2499fe4dab9e22705"` [INFO] [stderr] Checking alltext v0.0.3 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/alltext.rs:7:25 [INFO] [stderr] | [INFO] [stderr] 7 | const ALLTEXT_VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/alltext.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / if null_delimiter { [INFO] [stderr] 57 | | if input_raw.last().is_some() { [INFO] [stderr] 58 | | let needs_pop = { [INFO] [stderr] 59 | | let last: &u8 = input_raw.last().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 56 | if null_delimiter && input_raw.last().is_some() { [INFO] [stderr] 57 | let needs_pop = { [INFO] [stderr] 58 | let last: &u8 = input_raw.last().unwrap(); [INFO] [stderr] 59 | [INFO] [stderr] 60 | last == &delimiter [INFO] [stderr] 61 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/alltext.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | &input_raw.clear(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_raw.clear();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/alltext.rs:7:25 [INFO] [stderr] | [INFO] [stderr] 7 | const ALLTEXT_VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/alltext.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / if null_delimiter { [INFO] [stderr] 57 | | if input_raw.last().is_some() { [INFO] [stderr] 58 | | let needs_pop = { [INFO] [stderr] 59 | | let last: &u8 = input_raw.last().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 56 | if null_delimiter && input_raw.last().is_some() { [INFO] [stderr] 57 | let needs_pop = { [INFO] [stderr] 58 | let last: &u8 = input_raw.last().unwrap(); [INFO] [stderr] 59 | [INFO] [stderr] 60 | last == &delimiter [INFO] [stderr] 61 | }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/alltext.rs:3:25 [INFO] [stderr] | [INFO] [stderr] 3 | const ALLTEXT_VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/alltext.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return output [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `output` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/alltext.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | &input_raw.clear(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_raw.clear();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> tests/alltext.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | / process.stdin.unwrap().write(input.as_bytes()).unwrap_or_else(|e| { [INFO] [stderr] 31 | | panic!("error: {}", e) [INFO] [stderr] 32 | | }); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `alltext`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4ab2a46b7becd0013219bf95488fa671e1dcca5dfa0a33e2499fe4dab9e22705"` [INFO] running `"docker" "rm" "-f" "4ab2a46b7becd0013219bf95488fa671e1dcca5dfa0a33e2499fe4dab9e22705"` [INFO] [stdout] 4ab2a46b7becd0013219bf95488fa671e1dcca5dfa0a33e2499fe4dab9e22705