[INFO] updating cached repository stan4cb/rs-brainfuck [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/stan4cb/rs-brainfuck [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/stan4cb/rs-brainfuck" "work/ex/clippy-test-run/sources/stable/gh/stan4cb/rs-brainfuck"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stan4cb/rs-brainfuck'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/stan4cb/rs-brainfuck" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stan4cb/rs-brainfuck"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stan4cb/rs-brainfuck'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 364e8f045b1d3b1da9a25d01608b84e5ec663ac1 [INFO] sha for GitHub repo stan4cb/rs-brainfuck: 364e8f045b1d3b1da9a25d01608b84e5ec663ac1 [INFO] validating manifest of stan4cb/rs-brainfuck on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stan4cb/rs-brainfuck on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stan4cb/rs-brainfuck [INFO] finished frobbing stan4cb/rs-brainfuck [INFO] frobbed toml for stan4cb/rs-brainfuck written to work/ex/clippy-test-run/sources/stable/gh/stan4cb/rs-brainfuck/Cargo.toml [INFO] started frobbing stan4cb/rs-brainfuck [INFO] finished frobbing stan4cb/rs-brainfuck [INFO] frobbed toml for stan4cb/rs-brainfuck written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stan4cb/rs-brainfuck/Cargo.toml [INFO] crate stan4cb/rs-brainfuck has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stan4cb/rs-brainfuck against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stan4cb/rs-brainfuck:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] da6121152a5cf1f8173efe78e4c6b343b222426ee37ffc34934e4b63df3b01ca [INFO] running `"docker" "start" "-a" "da6121152a5cf1f8173efe78e4c6b343b222426ee37ffc34934e4b63df3b01ca"` [INFO] [stderr] Checking rs-brainfuck v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: function is never used: `brain_luck` [INFO] [stderr] --> src/main.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | fn brain_luck(code: &str, input: Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:47:28 [INFO] [stderr] | [INFO] [stderr] 47 | if jumps.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!jumps.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:47:28 [INFO] [stderr] | [INFO] [stderr] 47 | if jumps.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!jumps.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.51s [INFO] running `"docker" "inspect" "da6121152a5cf1f8173efe78e4c6b343b222426ee37ffc34934e4b63df3b01ca"` [INFO] running `"docker" "rm" "-f" "da6121152a5cf1f8173efe78e4c6b343b222426ee37ffc34934e4b63df3b01ca"` [INFO] [stdout] da6121152a5cf1f8173efe78e4c6b343b222426ee37ffc34934e4b63df3b01ca