[INFO] updating cached repository stallmanifold/idea-runner [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/stallmanifold/idea-runner [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/stallmanifold/idea-runner" "work/ex/clippy-test-run/sources/stable/gh/stallmanifold/idea-runner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/stallmanifold/idea-runner'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/stallmanifold/idea-runner" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stallmanifold/idea-runner"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stallmanifold/idea-runner'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fd499b77f844033970f0aaabab9c1b83c8b74581 [INFO] sha for GitHub repo stallmanifold/idea-runner: fd499b77f844033970f0aaabab9c1b83c8b74581 [INFO] validating manifest of stallmanifold/idea-runner on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of stallmanifold/idea-runner on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing stallmanifold/idea-runner [INFO] finished frobbing stallmanifold/idea-runner [INFO] frobbed toml for stallmanifold/idea-runner written to work/ex/clippy-test-run/sources/stable/gh/stallmanifold/idea-runner/Cargo.toml [INFO] started frobbing stallmanifold/idea-runner [INFO] finished frobbing stallmanifold/idea-runner [INFO] frobbed toml for stallmanifold/idea-runner written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stallmanifold/idea-runner/Cargo.toml [INFO] crate stallmanifold/idea-runner has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting stallmanifold/idea-runner against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/stallmanifold/idea-runner:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0460abbd60fb9a336ddccae62ef8c87f7270f9739ea431b97cf856a31caa4adf [INFO] running `"docker" "start" "-a" "0460abbd60fb9a336ddccae62ef8c87f7270f9739ea431b97cf856a31caa4adf"` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/src/main.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] warning: path `/opt/crater/workdir/src/main.rs` was erroneously implicitly accepted for binary `idea`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] Checking idea-runner v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/command.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib/command.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib/command.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | command [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib/command.rs:65:23 [INFO] [stderr] | [INFO] [stderr] 65 | let command = match subcommand { [INFO] [stderr] | _______________________^ [INFO] [stderr] 66 | | SubCommand::Set => { [INFO] [stderr] 67 | | // There is at least one other argument, pass that as the path. [INFO] [stderr] 68 | | if arguments.len() > 1 { [INFO] [stderr] ... | [INFO] [stderr] 75 | | _ => Some(Command::new(subcommand, Vec::new().as_ref())) [INFO] [stderr] 76 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib/command.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | arguments: arguments.iter().map(|st| st.clone()).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `arguments.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib/command.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | command [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib/command.rs:65:23 [INFO] [stderr] | [INFO] [stderr] 65 | let command = match subcommand { [INFO] [stderr] | _______________________^ [INFO] [stderr] 66 | | SubCommand::Set => { [INFO] [stderr] 67 | | // There is at least one other argument, pass that as the path. [INFO] [stderr] 68 | | if arguments.len() > 1 { [INFO] [stderr] ... | [INFO] [stderr] 75 | | _ => Some(Command::new(subcommand, Vec::new().as_ref())) [INFO] [stderr] 76 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib/command.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | arguments: arguments.iter().map(|st| st.clone()).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `arguments.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.64s [INFO] running `"docker" "inspect" "0460abbd60fb9a336ddccae62ef8c87f7270f9739ea431b97cf856a31caa4adf"` [INFO] running `"docker" "rm" "-f" "0460abbd60fb9a336ddccae62ef8c87f7270f9739ea431b97cf856a31caa4adf"` [INFO] [stdout] 0460abbd60fb9a336ddccae62ef8c87f7270f9739ea431b97cf856a31caa4adf