[INFO] updating cached repository st1ckman67/Rust_Refences [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/st1ckman67/Rust_Refences [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/st1ckman67/Rust_Refences" "work/ex/clippy-test-run/sources/stable/gh/st1ckman67/Rust_Refences"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/st1ckman67/Rust_Refences'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/st1ckman67/Rust_Refences" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/st1ckman67/Rust_Refences"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/st1ckman67/Rust_Refences'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a76462b56a1a41916d3ce4405045aea759a5fd6f [INFO] sha for GitHub repo st1ckman67/Rust_Refences: a76462b56a1a41916d3ce4405045aea759a5fd6f [INFO] validating manifest of st1ckman67/Rust_Refences on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of st1ckman67/Rust_Refences on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing st1ckman67/Rust_Refences [INFO] finished frobbing st1ckman67/Rust_Refences [INFO] frobbed toml for st1ckman67/Rust_Refences written to work/ex/clippy-test-run/sources/stable/gh/st1ckman67/Rust_Refences/Cargo.toml [INFO] started frobbing st1ckman67/Rust_Refences [INFO] finished frobbing st1ckman67/Rust_Refences [INFO] frobbed toml for st1ckman67/Rust_Refences written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/st1ckman67/Rust_Refences/Cargo.toml [INFO] crate st1ckman67/Rust_Refences has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting st1ckman67/Rust_Refences against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/st1ckman67/Rust_Refences:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1b80f7fb32ec248cc3ca187bb7d858455024a179920519d01f305a920c81bef8 [INFO] running `"docker" "start" "-a" "1b80f7fb32ec248cc3ca187bb7d858455024a179920519d01f305a920c81bef8"` [INFO] [stderr] Checking references v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:14:24 [INFO] [stderr] | [INFO] [stderr] 14 | fn calculate_length(s: &String) -> usize { // s is a reference to a String [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:14:24 [INFO] [stderr] | [INFO] [stderr] 14 | fn calculate_length(s: &String) -> usize { // s is a reference to a String [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.34s [INFO] running `"docker" "inspect" "1b80f7fb32ec248cc3ca187bb7d858455024a179920519d01f305a920c81bef8"` [INFO] running `"docker" "rm" "-f" "1b80f7fb32ec248cc3ca187bb7d858455024a179920519d01f305a920c81bef8"` [INFO] [stdout] 1b80f7fb32ec248cc3ca187bb7d858455024a179920519d01f305a920c81bef8