[INFO] updating cached repository ssokolow/rip_media [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/ssokolow/rip_media [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/ssokolow/rip_media" "work/ex/clippy-test-run/sources/stable/gh/ssokolow/rip_media"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/ssokolow/rip_media'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/ssokolow/rip_media" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ssokolow/rip_media"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ssokolow/rip_media'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cdb7ed4c78fef78914fffa94b19c6a1254a80c62 [INFO] sha for GitHub repo ssokolow/rip_media: cdb7ed4c78fef78914fffa94b19c6a1254a80c62 [INFO] validating manifest of ssokolow/rip_media on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ssokolow/rip_media on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ssokolow/rip_media [INFO] finished frobbing ssokolow/rip_media [INFO] frobbed toml for ssokolow/rip_media written to work/ex/clippy-test-run/sources/stable/gh/ssokolow/rip_media/Cargo.toml [INFO] started frobbing ssokolow/rip_media [INFO] finished frobbing ssokolow/rip_media [INFO] frobbed toml for ssokolow/rip_media written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ssokolow/rip_media/Cargo.toml [INFO] crate ssokolow/rip_media has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ssokolow/rip_media against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/ssokolow/rip_media:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 10bcb60ed4f9cec91a3828dcaea0b75de070f3f8e96f23e4da6de96f60eac23c [INFO] running `"docker" "start" "-a" "10bcb60ed4f9cec91a3828dcaea0b75de070f3f8e96f23e4da6de96f60eac23c"` [INFO] [stderr] Checking bitflags v0.8.0 [INFO] [stderr] Checking encode_unicode v0.1.3 [INFO] [stderr] Checking error-chain v0.9.0 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking clap v2.21.1 [INFO] [stderr] Checking rustyline v1.0.0 [INFO] [stderr] Checking rip_media v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `clippy_pedantic` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:58:42 [INFO] [stderr] | [INFO] [stderr] 58 | #![cfg_attr(feature="cargo-clippy", warn(clippy_pedantic, clippy_restrictions))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::pedantic` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: unknown lint: `clippy_restrictions` [INFO] [stderr] --> src/main.rs:58:59 [INFO] [stderr] | [INFO] [stderr] 58 | #![cfg_attr(feature="cargo-clippy", warn(clippy_pedantic, clippy_restrictions))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unknown_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint `assign_ops` has been removed: `using compound assignment operators (e.g. `+=`) is harmless` [INFO] [stderr] --> src/main.rs:61:43 [INFO] [stderr] | [INFO] [stderr] 61 | #![cfg_attr(feature="cargo-clippy", allow(assign_ops, float_arithmetic))] [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: lint name `float_arithmetic` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:61:55 [INFO] [stderr] | [INFO] [stderr] 61 | #![cfg_attr(feature="cargo-clippy", allow(assign_ops, float_arithmetic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change it to: `clippy::float_arithmetic` [INFO] [stderr] [INFO] [stderr] warning: lint name `use_debug` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/validators.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | #[allow(use_debug)] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::use_debug` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/platform.rs:103:33 [INFO] [stderr] | [INFO] [stderr] 103 | LinuxPlatformProvider { device: device } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `use_debug` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/platform.rs:154:17 [INFO] [stderr] | [INFO] [stderr] 154 | #[allow(use_debug)] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::use_debug` [INFO] [stderr] [INFO] [stderr] warning: lint name `use_debug` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/platform.rs:163:17 [INFO] [stderr] | [INFO] [stderr] 163 | #[allow(use_debug)] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::use_debug` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_pedantic` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:58:42 [INFO] [stderr] | [INFO] [stderr] 58 | #![cfg_attr(feature="cargo-clippy", warn(clippy_pedantic, clippy_restrictions))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::pedantic` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: unknown lint: `clippy_restrictions` [INFO] [stderr] --> src/main.rs:58:59 [INFO] [stderr] | [INFO] [stderr] 58 | #![cfg_attr(feature="cargo-clippy", warn(clippy_pedantic, clippy_restrictions))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unknown_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint `assign_ops` has been removed: `using compound assignment operators (e.g. `+=`) is harmless` [INFO] [stderr] --> src/main.rs:61:43 [INFO] [stderr] | [INFO] [stderr] 61 | #![cfg_attr(feature="cargo-clippy", allow(assign_ops, float_arithmetic))] [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: lint name `float_arithmetic` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:61:55 [INFO] [stderr] | [INFO] [stderr] 61 | #![cfg_attr(feature="cargo-clippy", allow(assign_ops, float_arithmetic))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change it to: `clippy::float_arithmetic` [INFO] [stderr] [INFO] [stderr] warning: lint name `use_debug` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/validators.rs:108:17 [INFO] [stderr] | [INFO] [stderr] 108 | #[allow(use_debug)] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::use_debug` [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/platform.rs:103:33 [INFO] [stderr] | [INFO] [stderr] 103 | LinuxPlatformProvider { device: device } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `use_debug` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/platform.rs:154:17 [INFO] [stderr] | [INFO] [stderr] 154 | #[allow(use_debug)] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::use_debug` [INFO] [stderr] [INFO] [stderr] warning: lint name `use_debug` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/platform.rs:163:17 [INFO] [stderr] | [INFO] [stderr] 163 | #[allow(use_debug)] [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::use_debug` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_pedantic` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:58:42 [INFO] [stderr] | [INFO] [stderr] 58 | #![cfg_attr(feature="cargo-clippy", warn(clippy_pedantic, clippy_restrictions))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::pedantic` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_pedantic` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:58:42 [INFO] [stderr] | [INFO] [stderr] 58 | #![cfg_attr(feature="cargo-clippy", warn(clippy_pedantic, clippy_restrictions))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::pedantic` [INFO] [stderr] [INFO] [stderr] warning: unused import: `errors::*` [INFO] [stderr] --> src/main.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | use errors::*; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/validators.rs:9:32 [INFO] [stderr] | [INFO] [stderr] 9 | const INVALID_FILENAME_CHARS: &'static str = "/\\:*?\"<>|\0"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should put bare URLs between `<`/`>` or make a proper Markdown link [INFO] [stderr] --> src/validators.rs:17:15 [INFO] [stderr] | [INFO] [stderr] 17 | /// https://doc.rust-lang.org/book/conditional-compilation.html [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:58:42 [INFO] [stderr] | [INFO] [stderr] 58 | #![cfg_attr(feature="cargo-clippy", warn(clippy_pedantic, clippy_restrictions))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::doc_markdown)] implied by #[warn(clippy::pedantic)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stderr] [INFO] [stderr] warning: you should put bare URLs between `<`/`>` or make a proper Markdown link [INFO] [stderr] --> src/validators.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | /// Adapted from http://stackoverflow.com/a/30791678 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stderr] [INFO] [stderr] warning: unused import: `errors::*` [INFO] [stderr] --> src/main.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | use errors::*; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/validators.rs:9:32 [INFO] [stderr] | [INFO] [stderr] 9 | const INVALID_FILENAME_CHARS: &'static str = "/\\:*?\"<>|\0"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should put bare URLs between `<`/`>` or make a proper Markdown link [INFO] [stderr] --> src/validators.rs:17:15 [INFO] [stderr] | [INFO] [stderr] 17 | /// https://doc.rust-lang.org/book/conditional-compilation.html [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:58:42 [INFO] [stderr] | [INFO] [stderr] 58 | #![cfg_attr(feature="cargo-clippy", warn(clippy_pedantic, clippy_restrictions))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::doc_markdown)] implied by #[warn(clippy::pedantic)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/subcommands.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | const DONE_SOUND: &'static str = "/usr/share/sounds/KDE-Im-Nudge.ogg"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/subcommands.rs:22:20 [INFO] [stderr] | [INFO] [stderr] 22 | const FAIL_SOUND: &'static str = "/usr/share/sounds/KDE-K3B-Finish-Error.ogg"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:101:24 [INFO] [stderr] | [INFO] [stderr] 101 | const DEFAULT_INPATH: &'static str = "/dev/sr0"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should put bare URLs between `<`/`>` or make a proper Markdown link [INFO] [stderr] --> src/main.rs:133:6 [INFO] [stderr] | [INFO] [stderr] 133 | /// http://blog.ssokolow.com/archives/2016/10/17/a-more-formal-way-to-think-about-validity-of-input-data/ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stderr] [INFO] [stderr] warning: you should put bare URLs between `<`/`>` or make a proper Markdown link [INFO] [stderr] --> src/validators.rs:102:18 [INFO] [stderr] | [INFO] [stderr] 102 | /// Adapted from http://stackoverflow.com/a/30791678 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stderr] [INFO] [stderr] warning: you should put bare URLs between `<`/`>` or make a proper Markdown link [INFO] [stderr] --> src/platform.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | /// https://www.reddit.com/r/rust/comments/5tmvti/how_can_i_get_the_full_path_of_a_file_from_a/ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/platform.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | return LinuxPlatformProvider::new(Cow::Borrowed(path.as_os_str())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `LinuxPlatformProvider::new(Cow::Borrowed(path.as_os_str()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/subcommands.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | const DONE_SOUND: &'static str = "/usr/share/sounds/KDE-Im-Nudge.ogg"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/subcommands.rs:22:20 [INFO] [stderr] | [INFO] [stderr] 22 | const FAIL_SOUND: &'static str = "/usr/share/sounds/KDE-K3B-Finish-Error.ogg"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:101:24 [INFO] [stderr] | [INFO] [stderr] 101 | const DEFAULT_INPATH: &'static str = "/dev/sr0"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you should put bare URLs between `<`/`>` or make a proper Markdown link [INFO] [stderr] --> src/main.rs:133:6 [INFO] [stderr] | [INFO] [stderr] 133 | /// http://blog.ssokolow.com/archives/2016/10/17/a-more-formal-way-to-think-about-validity-of-input-data/ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stderr] [INFO] [stderr] warning: you should put `DEFAULT_INPATH` between ticks in the documentation [INFO] [stderr] --> src/main.rs:260:22 [INFO] [stderr] | [INFO] [stderr] 260 | /// Can override DEFAULT_INPATH when specifying -i before the subcommand [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stderr] [INFO] [stderr] warning: you should put `DEFAULT_INPATH` between ticks in the documentation [INFO] [stderr] --> src/main.rs:270:22 [INFO] [stderr] | [INFO] [stderr] 270 | /// Can override DEFAULT_INPATH when specifying -i after the subcommand [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_markdown [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/validators.rs:118:24 [INFO] [stderr] | [INFO] [stderr] 118 | fn is_bad_for_fname(c: &char) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by value, but not consumed in the function body [INFO] [stderr] --> src/validators.rs:137:24 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn set_size(value: String) -> Result<(), String> { [INFO] [stderr] | ^^^^^^ help: consider changing the type to: `&str` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:58:42 [INFO] [stderr] | [INFO] [stderr] 58 | #![cfg_attr(feature="cargo-clippy", warn(clippy_pedantic, clippy_restrictions))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::needless_pass_by_value)] implied by #[warn(clippy::pedantic)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value [INFO] [stderr] [INFO] [stderr] warning: Calling subcommands::glob::MatchOptions::default() is more clear than this expression [INFO] [stderr] --> src/subcommands.rs:92:59 [INFO] [stderr] | [INFO] [stderr] 92 | let options = MatchOptions { case_sensitive: false, ..Default::default() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `subcommands::glob::MatchOptions::default()` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:58:42 [INFO] [stderr] | [INFO] [stderr] 58 | #![cfg_attr(feature="cargo-clippy", warn(clippy_pedantic, clippy_restrictions))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::default_trait_access)] implied by #[warn(clippy::pedantic)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_trait_access [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/subcommands.rs:233:5 [INFO] [stderr] | [INFO] [stderr] 233 | plat_provider.read_line("Insert disc and press Enter..."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | subcommands::rip(&mut provider, subcommand_func, name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/validators.rs:118:24 [INFO] [stderr] | [INFO] [stderr] 118 | fn is_bad_for_fname(c: &char) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by value, but not consumed in the function body [INFO] [stderr] --> src/validators.rs:137:24 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn set_size(value: String) -> Result<(), String> { [INFO] [stderr] | ^^^^^^ help: consider changing the type to: `&str` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:58:42 [INFO] [stderr] | [INFO] [stderr] 58 | #![cfg_attr(feature="cargo-clippy", warn(clippy_pedantic, clippy_restrictions))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::needless_pass_by_value)] implied by #[warn(clippy::pedantic)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_value [INFO] [stderr] [INFO] [stderr] warning: Calling subcommands::glob::MatchOptions::default() is more clear than this expression [INFO] [stderr] --> src/subcommands.rs:92:59 [INFO] [stderr] | [INFO] [stderr] 92 | let options = MatchOptions { case_sensitive: false, ..Default::default() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `subcommands::glob::MatchOptions::default()` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:58:42 [INFO] [stderr] | [INFO] [stderr] 58 | #![cfg_attr(feature="cargo-clippy", warn(clippy_pedantic, clippy_restrictions))] [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] = note: #[warn(clippy::default_trait_access)] implied by #[warn(clippy::pedantic)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_trait_access [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/subcommands.rs:233:5 [INFO] [stderr] | [INFO] [stderr] 233 | plat_provider.read_line("Insert disc and press Enter..."); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | subcommands::rip(&mut provider, subcommand_func, name); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.52s [INFO] running `"docker" "inspect" "10bcb60ed4f9cec91a3828dcaea0b75de070f3f8e96f23e4da6de96f60eac23c"` [INFO] running `"docker" "rm" "-f" "10bcb60ed4f9cec91a3828dcaea0b75de070f3f8e96f23e4da6de96f60eac23c"` [INFO] [stdout] 10bcb60ed4f9cec91a3828dcaea0b75de070f3f8e96f23e4da6de96f60eac23c