[INFO] updating cached repository sphinxc0re/prisoners [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sphinxc0re/prisoners [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sphinxc0re/prisoners" "work/ex/clippy-test-run/sources/stable/gh/sphinxc0re/prisoners"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sphinxc0re/prisoners'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sphinxc0re/prisoners" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sphinxc0re/prisoners"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sphinxc0re/prisoners'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f298fec195f9badc0166328fdfbd19901b67fa1a [INFO] sha for GitHub repo sphinxc0re/prisoners: f298fec195f9badc0166328fdfbd19901b67fa1a [INFO] validating manifest of sphinxc0re/prisoners on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sphinxc0re/prisoners on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sphinxc0re/prisoners [INFO] finished frobbing sphinxc0re/prisoners [INFO] frobbed toml for sphinxc0re/prisoners written to work/ex/clippy-test-run/sources/stable/gh/sphinxc0re/prisoners/Cargo.toml [INFO] started frobbing sphinxc0re/prisoners [INFO] finished frobbing sphinxc0re/prisoners [INFO] frobbed toml for sphinxc0re/prisoners written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sphinxc0re/prisoners/Cargo.toml [INFO] crate sphinxc0re/prisoners has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sphinxc0re/prisoners against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sphinxc0re/prisoners:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 280493a608c0278cc103381f2cc14e81602b790b52c85470e286fcf1a494673b [INFO] running `"docker" "start" "-a" "280493a608c0278cc103381f2cc14e81602b790b52c85470e286fcf1a494673b"` [INFO] [stderr] Checking linked-hash-map v0.5.0 [INFO] [stderr] Checking yaml-rust v0.4.0 [INFO] [stderr] Checking prisoners v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mp.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mp.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | return_sender: return_sender [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `return_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:80:85 [INFO] [stderr] | [INFO] [stderr] 80 | let comp = Message::Complaint { need: need_vec[need_index].clone(), amount: amount }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `amount` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mp.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | message: message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `message` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mp.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | return_sender: return_sender [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `return_sender` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:80:85 [INFO] [stderr] | [INFO] [stderr] 80 | let comp = Message::Complaint { need: need_vec[need_index].clone(), amount: amount }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `amount` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/guard.rs:67:53 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn track_prisoner(&mut self, prisoner_name: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/guard.rs:74:55 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn untrack_prisoner(&mut self, prisoner_name: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prisoner.rs:33:80 [INFO] [stderr] | [INFO] [stderr] 33 | let message = Message::Complaint { need: need.clone(), amount: amount.clone() }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*amount` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/prisoner.rs:73:30 [INFO] [stderr] | [INFO] [stderr] 73 | for ref mut guard in self.guard_map.values().into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self.guard_map.values()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/prisoner.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | for ref mut guard in self.guard_map.values().into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^ ----------------------------------- help: try: `let guard = &mut self.guard_map.values().into_iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/prisoner.rs:80:30 [INFO] [stderr] | [INFO] [stderr] 80 | for ref mut guard in self.guard_map.values().into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self.guard_map.values()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/prisoner.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | for ref mut guard in self.guard_map.values().into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^ ----------------------------------- help: try: `let guard = &mut self.guard_map.values().into_iter();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/prisoner.rs:86:40 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn track_need(&mut self, need: &String, amount: i8) -> i8 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/utils.rs:6:30 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn str_vec_from_yaml_vec<'a>(need_vec: Yaml) -> Vec { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/main.rs:89:60 [INFO] [stderr] | [INFO] [stderr] 89 | prisoner.track_need(&need, amount * -1); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/guard.rs:67:53 [INFO] [stderr] | [INFO] [stderr] 67 | pub fn track_prisoner(&mut self, prisoner_name: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/guard.rs:74:55 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn untrack_prisoner(&mut self, prisoner_name: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/prisoner.rs:33:80 [INFO] [stderr] | [INFO] [stderr] 33 | let message = Message::Complaint { need: need.clone(), amount: amount.clone() }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*amount` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/prisoner.rs:73:30 [INFO] [stderr] | [INFO] [stderr] 73 | for ref mut guard in self.guard_map.values().into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self.guard_map.values()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/prisoner.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | for ref mut guard in self.guard_map.values().into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^ ----------------------------------- help: try: `let guard = &mut self.guard_map.values().into_iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/prisoner.rs:80:30 [INFO] [stderr] | [INFO] [stderr] 80 | for ref mut guard in self.guard_map.values().into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self.guard_map.values()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/prisoner.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | for ref mut guard in self.guard_map.values().into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^ ----------------------------------- help: try: `let guard = &mut self.guard_map.values().into_iter();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/prisoner.rs:86:40 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn track_need(&mut self, need: &String, amount: i8) -> i8 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/utils.rs:6:30 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn str_vec_from_yaml_vec<'a>(need_vec: Yaml) -> Vec { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/main.rs:89:60 [INFO] [stderr] | [INFO] [stderr] 89 | prisoner.track_need(&need, amount * -1); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.60s [INFO] running `"docker" "inspect" "280493a608c0278cc103381f2cc14e81602b790b52c85470e286fcf1a494673b"` [INFO] running `"docker" "rm" "-f" "280493a608c0278cc103381f2cc14e81602b790b52c85470e286fcf1a494673b"` [INFO] [stdout] 280493a608c0278cc103381f2cc14e81602b790b52c85470e286fcf1a494673b