[INFO] updating cached repository spencedalley/rust_finite_state_machine [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/spencedalley/rust_finite_state_machine [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/spencedalley/rust_finite_state_machine" "work/ex/clippy-test-run/sources/stable/gh/spencedalley/rust_finite_state_machine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/spencedalley/rust_finite_state_machine'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/spencedalley/rust_finite_state_machine" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/spencedalley/rust_finite_state_machine"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/spencedalley/rust_finite_state_machine'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 73896eee1d6ca5e5bb3baa1b18eea9719995f72a [INFO] sha for GitHub repo spencedalley/rust_finite_state_machine: 73896eee1d6ca5e5bb3baa1b18eea9719995f72a [INFO] validating manifest of spencedalley/rust_finite_state_machine on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of spencedalley/rust_finite_state_machine on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing spencedalley/rust_finite_state_machine [INFO] finished frobbing spencedalley/rust_finite_state_machine [INFO] frobbed toml for spencedalley/rust_finite_state_machine written to work/ex/clippy-test-run/sources/stable/gh/spencedalley/rust_finite_state_machine/Cargo.toml [INFO] started frobbing spencedalley/rust_finite_state_machine [INFO] finished frobbing spencedalley/rust_finite_state_machine [INFO] frobbed toml for spencedalley/rust_finite_state_machine written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/spencedalley/rust_finite_state_machine/Cargo.toml [INFO] crate spencedalley/rust_finite_state_machine has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting spencedalley/rust_finite_state_machine against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/spencedalley/rust_finite_state_machine:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a6a35682c2526ee4606c845322450ab9a507b10ad06dde7ddf20d89c29a08f9e [INFO] running `"docker" "start" "-a" "a6a35682c2526ee4606c845322450ab9a507b10ad06dde7ddf20d89c29a08f9e"` [INFO] [stderr] Checking finite_state_machines v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | '#' => { return (None, MachineState::Comment); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Comment)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:19:26 [INFO] [stderr] | [INFO] [stderr] 19 | '^' => { return (None, MachineState::Upper); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Upper)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | '_' => { return (None, MachineState::Lower); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Lower)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | _ => { return (Some(character), MachineState::Normal); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Some(character), MachineState::Normal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | return (None, MachineState::Normal); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Normal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | return (None, MachineState::Comment); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Comment)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | return (None, MachineState::Normal); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Normal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | return (Some(character.to_ascii_uppercase()), MachineState::Upper); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Some(character.to_ascii_uppercase()), MachineState::Upper)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | return (None, MachineState::Normal); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Normal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | return (Some(character.to_ascii_lowercase()), MachineState::Lower); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Some(character.to_ascii_lowercase()), MachineState::Lower)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/state_match.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/state_match.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | '#' => { return (None, MachineState::Comment); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Comment)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:19:26 [INFO] [stderr] | [INFO] [stderr] 19 | '^' => { return (None, MachineState::Upper); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Upper)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | '_' => { return (None, MachineState::Lower); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Lower)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | _ => { return (Some(character), MachineState::Normal); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Some(character), MachineState::Normal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | return (None, MachineState::Normal); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Normal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | return (None, MachineState::Comment); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Comment)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | return (None, MachineState::Normal); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Normal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | return (Some(character.to_ascii_uppercase()), MachineState::Upper); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Some(character.to_ascii_uppercase()), MachineState::Upper)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | return (None, MachineState::Normal); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Normal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | return (Some(character.to_ascii_lowercase()), MachineState::Lower); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Some(character.to_ascii_lowercase()), MachineState::Lower)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/state_match.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/state_match.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / match state { [INFO] [stderr] 16 | | &MachineState::Normal => { [INFO] [stderr] 17 | | match character { [INFO] [stderr] 18 | | '#' => { return (None, MachineState::Comment); } [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 15 | match *state { [INFO] [stderr] 16 | MachineState::Normal => { [INFO] [stderr] 17 | match character { [INFO] [stderr] 18 | '#' => { return (None, MachineState::Comment); } [INFO] [stderr] 19 | '^' => { return (None, MachineState::Upper); } [INFO] [stderr] 20 | '_' => { return (None, MachineState::Lower); } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/state_match.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/state_match.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / match state { [INFO] [stderr] 16 | | &MachineState::Normal => { [INFO] [stderr] 17 | | match character { [INFO] [stderr] 18 | | '#' => { return (None, MachineState::Comment); } [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 15 | match *state { [INFO] [stderr] 16 | MachineState::Normal => { [INFO] [stderr] 17 | match character { [INFO] [stderr] 18 | '#' => { return (None, MachineState::Comment); } [INFO] [stderr] 19 | '^' => { return (None, MachineState::Upper); } [INFO] [stderr] 20 | '_' => { return (None, MachineState::Lower); } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | '#' => { return (None, MachineState::Comment); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Comment)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:19:26 [INFO] [stderr] | [INFO] [stderr] 19 | '^' => { return (None, MachineState::Upper); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Upper)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | '_' => { return (None, MachineState::Lower); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Lower)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | _ => { return (Some(character), MachineState::Normal); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Some(character), MachineState::Normal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | return (None, MachineState::Normal); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Normal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | return (None, MachineState::Comment); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Comment)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | return (None, MachineState::Normal); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Normal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | return (Some(character.to_ascii_uppercase()), MachineState::Upper); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Some(character.to_ascii_uppercase()), MachineState::Upper)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | return (None, MachineState::Normal); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Normal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | return (Some(character.to_ascii_lowercase()), MachineState::Lower); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Some(character.to_ascii_lowercase()), MachineState::Lower)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | '#' => { return (None, MachineState::Comment); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Comment)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:19:26 [INFO] [stderr] | [INFO] [stderr] 19 | '^' => { return (None, MachineState::Upper); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Upper)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | '_' => { return (None, MachineState::Lower); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Lower)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | _ => { return (Some(character), MachineState::Normal); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Some(character), MachineState::Normal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | return (None, MachineState::Normal); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Normal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | return (None, MachineState::Comment); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Comment)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:33:17 [INFO] [stderr] | [INFO] [stderr] 33 | return (None, MachineState::Normal); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Normal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | return (Some(character.to_ascii_uppercase()), MachineState::Upper); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Some(character.to_ascii_uppercase()), MachineState::Upper)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | return (None, MachineState::Normal); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, MachineState::Normal)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/state_match.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | return (Some(character.to_ascii_lowercase()), MachineState::Lower); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Some(character.to_ascii_lowercase()), MachineState::Lower)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/state_match.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/state_match.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/state_match.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/state_match.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/state_match.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / match state { [INFO] [stderr] 16 | | &MachineState::Normal => { [INFO] [stderr] 17 | | match character { [INFO] [stderr] 18 | | '#' => { return (None, MachineState::Comment); } [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 15 | match *state { [INFO] [stderr] 16 | MachineState::Normal => { [INFO] [stderr] 17 | match character { [INFO] [stderr] 18 | '#' => { return (None, MachineState::Comment); } [INFO] [stderr] 19 | '^' => { return (None, MachineState::Upper); } [INFO] [stderr] 20 | '_' => { return (None, MachineState::Lower); } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/state_match.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / match state { [INFO] [stderr] 16 | | &MachineState::Normal => { [INFO] [stderr] 17 | | match character { [INFO] [stderr] 18 | | '#' => { return (None, MachineState::Comment); } [INFO] [stderr] ... | [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 15 | match *state { [INFO] [stderr] 16 | MachineState::Normal => { [INFO] [stderr] 17 | match character { [INFO] [stderr] 18 | '#' => { return (None, MachineState::Comment); } [INFO] [stderr] 19 | '^' => { return (None, MachineState::Upper); } [INFO] [stderr] 20 | '_' => { return (None, MachineState::Lower); } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | / match output { [INFO] [stderr] 13 | | // If output is "some" rather than None, put whatever the value is in c [INFO] [stderr] 14 | | Some(c) => { processed_string.push(c); } [INFO] [stderr] 15 | | None => {} [INFO] [stderr] 16 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(c) = output { processed_string.push(c); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | / match output { [INFO] [stderr] 13 | | // If output is "some" rather than None, put whatever the value is in c [INFO] [stderr] 14 | | Some(c) => { processed_string.push(c); } [INFO] [stderr] 15 | | None => {} [INFO] [stderr] 16 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Some(c) = output { processed_string.push(c); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.23s [INFO] running `"docker" "inspect" "a6a35682c2526ee4606c845322450ab9a507b10ad06dde7ddf20d89c29a08f9e"` [INFO] running `"docker" "rm" "-f" "a6a35682c2526ee4606c845322450ab9a507b10ad06dde7ddf20d89c29a08f9e"` [INFO] [stdout] a6a35682c2526ee4606c845322450ab9a507b10ad06dde7ddf20d89c29a08f9e