[INFO] updating cached repository sosik/git-credential-docker-store [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sosik/git-credential-docker-store [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sosik/git-credential-docker-store" "work/ex/clippy-test-run/sources/stable/gh/sosik/git-credential-docker-store"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sosik/git-credential-docker-store'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sosik/git-credential-docker-store" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sosik/git-credential-docker-store"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sosik/git-credential-docker-store'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1137a8e51dc610ec3b557520fe60cc4d6e4f13fb [INFO] sha for GitHub repo sosik/git-credential-docker-store: 1137a8e51dc610ec3b557520fe60cc4d6e4f13fb [INFO] validating manifest of sosik/git-credential-docker-store on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sosik/git-credential-docker-store on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sosik/git-credential-docker-store [INFO] finished frobbing sosik/git-credential-docker-store [INFO] frobbed toml for sosik/git-credential-docker-store written to work/ex/clippy-test-run/sources/stable/gh/sosik/git-credential-docker-store/Cargo.toml [INFO] started frobbing sosik/git-credential-docker-store [INFO] finished frobbing sosik/git-credential-docker-store [INFO] frobbed toml for sosik/git-credential-docker-store written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sosik/git-credential-docker-store/Cargo.toml [INFO] crate sosik/git-credential-docker-store has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sosik/git-credential-docker-store against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sosik/git-credential-docker-store:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1267b88b5e2d69f44f02d97753e66087a23d6e90737a137e266543cf922cbe3a [INFO] running `"docker" "start" "-a" "1267b88b5e2d69f44f02d97753e66087a23d6e90737a137e266543cf922cbe3a"` [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking git-credential-docker-store v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | println!("") [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | println!("") [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/cmdget.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | let linestr = line.unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `line.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/cmdget.rs:26:24 [INFO] [stderr] | [INFO] [stderr] 26 | protocol = linestr.split_at(9).1.to_string() + &"://"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"://"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/cmdget.rs:44:23 [INFO] [stderr] | [INFO] [stderr] 44 | let linestr = line.unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `line.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:21:2 [INFO] [stderr] | [INFO] [stderr] 21 | match params.subcommand_name() { [INFO] [stderr] | _____^ [INFO] [stderr] 22 | | Some("get") => { [INFO] [stderr] 23 | | match cmdget::execute(file_name) { [INFO] [stderr] 24 | | Ok(s) => println!("{}", s), [INFO] [stderr] ... | [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | if let Some("get") = params.subcommand_name() { [INFO] [stderr] 22 | match cmdget::execute(file_name) { [INFO] [stderr] 23 | Ok(s) => println!("{}", s), [INFO] [stderr] 24 | Err(e) => println!("{}", e), [INFO] [stderr] 25 | }; [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/cmdget.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | let linestr = line.unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `line.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/cmdget.rs:26:24 [INFO] [stderr] | [INFO] [stderr] 26 | protocol = linestr.split_at(9).1.to_string() + &"://"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `"://"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/cmdget.rs:44:23 [INFO] [stderr] | [INFO] [stderr] 44 | let linestr = line.unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `line.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:21:2 [INFO] [stderr] | [INFO] [stderr] 21 | match params.subcommand_name() { [INFO] [stderr] | _____^ [INFO] [stderr] 22 | | Some("get") => { [INFO] [stderr] 23 | | match cmdget::execute(file_name) { [INFO] [stderr] 24 | | Ok(s) => println!("{}", s), [INFO] [stderr] ... | [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 21 | if let Some("get") = params.subcommand_name() { [INFO] [stderr] 22 | match cmdget::execute(file_name) { [INFO] [stderr] 23 | Ok(s) => println!("{}", s), [INFO] [stderr] 24 | Err(e) => println!("{}", e), [INFO] [stderr] 25 | }; [INFO] [stderr] 26 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.78s [INFO] running `"docker" "inspect" "1267b88b5e2d69f44f02d97753e66087a23d6e90737a137e266543cf922cbe3a"` [INFO] running `"docker" "rm" "-f" "1267b88b5e2d69f44f02d97753e66087a23d6e90737a137e266543cf922cbe3a"` [INFO] [stdout] 1267b88b5e2d69f44f02d97753e66087a23d6e90737a137e266543cf922cbe3a