[INFO] updating cached repository soh335/raytracinginoneweekend [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/soh335/raytracinginoneweekend [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/soh335/raytracinginoneweekend" "work/ex/clippy-test-run/sources/stable/gh/soh335/raytracinginoneweekend"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/soh335/raytracinginoneweekend'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/soh335/raytracinginoneweekend" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/soh335/raytracinginoneweekend"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/soh335/raytracinginoneweekend'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7edd5a607639d509b5111696f3bf789465e29f0b [INFO] sha for GitHub repo soh335/raytracinginoneweekend: 7edd5a607639d509b5111696f3bf789465e29f0b [INFO] validating manifest of soh335/raytracinginoneweekend on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of soh335/raytracinginoneweekend on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing soh335/raytracinginoneweekend [INFO] finished frobbing soh335/raytracinginoneweekend [INFO] frobbed toml for soh335/raytracinginoneweekend written to work/ex/clippy-test-run/sources/stable/gh/soh335/raytracinginoneweekend/Cargo.toml [INFO] started frobbing soh335/raytracinginoneweekend [INFO] finished frobbing soh335/raytracinginoneweekend [INFO] frobbed toml for soh335/raytracinginoneweekend written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/soh335/raytracinginoneweekend/Cargo.toml [INFO] crate soh335/raytracinginoneweekend has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting soh335/raytracinginoneweekend against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/soh335/raytracinginoneweekend:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 30d062d42b91dcacd71a037f34389116e04aedea37efee21f22ed539678957ee [INFO] running `"docker" "start" "-a" "30d062d42b91dcacd71a037f34389116e04aedea37efee21f22ed539678957ee"` [INFO] [stderr] Checking raytracinginoneweekend v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | lower_left_corner: lower_left_corner, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lower_left_corner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | horizontal: horizontal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `horizontal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | vertical: vertical, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertical` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | lens_radius: lens_radius, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lens_radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | u: u, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `u` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | v: v, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | w: w, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | lower_left_corner: lower_left_corner, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lower_left_corner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | horizontal: horizontal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `horizontal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | vertical: vertical, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `vertical` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | origin: origin, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:46:13 [INFO] [stderr] | [INFO] [stderr] 46 | lens_radius: lens_radius, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lens_radius` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | u: u, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `u` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | v: v, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/camera.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | w: w, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sphere.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sphere.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: field is never used: `w` [INFO] [stderr] --> src/camera.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | w: Vec3, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/hitable.rs:13:74 [INFO] [stderr] | [INFO] [stderr] 13 | fn hit(&self, r: &Ray, t_min: f32, t_max: f32) -> Option<(HitRecord, &Box)>; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Material` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `hitable_list::HitableList` [INFO] [stderr] --> src/hitable_list.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Self { [INFO] [stderr] 11 | | HitableList{list: Vec::new()} [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: field is never used: `w` [INFO] [stderr] --> src/camera.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | w: Vec3, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/hitable.rs:13:74 [INFO] [stderr] | [INFO] [stderr] 13 | fn hit(&self, r: &Ray, t_min: f32, t_max: f32) -> Option<(HitRecord, &Box)>; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `&Material` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `hitable_list::HitableList` [INFO] [stderr] --> src/hitable_list.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> Self { [INFO] [stderr] 11 | | HitableList{list: Vec::new()} [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:46:48 [INFO] [stderr] | [INFO] [stderr] 46 | world.push(Box::new(Sphere{center: center, radius: 0.2, material: Box::new(Lambertian{albed: Vec3(f(),f(),f())})})); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:50:48 [INFO] [stderr] | [INFO] [stderr] 50 | world.push(Box::new(Sphere{center: center, radius: 0.2, material: Box::new(Metal{fuzz: fuzz, albed: Vec3(f(), f(), f())})})); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:50:102 [INFO] [stderr] | [INFO] [stderr] 50 | world.push(Box::new(Sphere{center: center, radius: 0.2, material: Box::new(Metal{fuzz: fuzz, albed: Vec3(f(), f(), f())})})); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `fuzz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:52:48 [INFO] [stderr] | [INFO] [stderr] 52 | world.push(Box::new(Sphere{center: center, radius: 0.2, material: Box::new(Dielectric{ref_idx: 1.5})})); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | print!("{} {} {}\n", ir, ig, ib); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:46:48 [INFO] [stderr] | [INFO] [stderr] 46 | world.push(Box::new(Sphere{center: center, radius: 0.2, material: Box::new(Lambertian{albed: Vec3(f(),f(),f())})})); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:50:48 [INFO] [stderr] | [INFO] [stderr] 50 | world.push(Box::new(Sphere{center: center, radius: 0.2, material: Box::new(Metal{fuzz: fuzz, albed: Vec3(f(), f(), f())})})); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:50:102 [INFO] [stderr] | [INFO] [stderr] 50 | world.push(Box::new(Sphere{center: center, radius: 0.2, material: Box::new(Metal{fuzz: fuzz, albed: Vec3(f(), f(), f())})})); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `fuzz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:52:48 [INFO] [stderr] | [INFO] [stderr] 52 | world.push(Box::new(Sphere{center: center, radius: 0.2, material: Box::new(Dielectric{ref_idx: 1.5})})); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | print!("{} {} {}\n", ir, ig, ib); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.55s [INFO] running `"docker" "inspect" "30d062d42b91dcacd71a037f34389116e04aedea37efee21f22ed539678957ee"` [INFO] running `"docker" "rm" "-f" "30d062d42b91dcacd71a037f34389116e04aedea37efee21f22ed539678957ee"` [INFO] [stdout] 30d062d42b91dcacd71a037f34389116e04aedea37efee21f22ed539678957ee