[INFO] updating cached repository softprops/git-codeowners [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/softprops/git-codeowners [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/softprops/git-codeowners" "work/ex/clippy-test-run/sources/stable/gh/softprops/git-codeowners"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/softprops/git-codeowners'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/softprops/git-codeowners" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/softprops/git-codeowners"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/softprops/git-codeowners'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] af64002d6a0932a1759296b70a3348519932c306 [INFO] sha for GitHub repo softprops/git-codeowners: af64002d6a0932a1759296b70a3348519932c306 [INFO] validating manifest of softprops/git-codeowners on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of softprops/git-codeowners on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing softprops/git-codeowners [INFO] finished frobbing softprops/git-codeowners [INFO] frobbed toml for softprops/git-codeowners written to work/ex/clippy-test-run/sources/stable/gh/softprops/git-codeowners/Cargo.toml [INFO] started frobbing softprops/git-codeowners [INFO] finished frobbing softprops/git-codeowners [INFO] frobbed toml for softprops/git-codeowners written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/softprops/git-codeowners/Cargo.toml [INFO] crate softprops/git-codeowners has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting softprops/git-codeowners against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/softprops/git-codeowners:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5ddf56d2ed3fb7e95514f73a9d76376806f699a6d0b8d6daaae1c453bae88137 [INFO] running `"docker" "start" "-a" "5ddf56d2ed3fb7e95514f73a9d76376806f699a6d0b8d6daaae1c453bae88137"` [INFO] [stderr] Checking thread_local v0.3.4 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking codeowners v0.1.3 [INFO] [stderr] Checking git-codeowners v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:82:33 [INFO] [stderr] | [INFO] [stderr] 82 | / match owner { [INFO] [stderr] 83 | | &Owner::Team(ref inner) => Some(inner.clone()), [INFO] [stderr] 84 | | _ => None, [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 82 | match *owner { [INFO] [stderr] 83 | Owner::Team(ref inner) => Some(inner.clone()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:87:33 [INFO] [stderr] | [INFO] [stderr] 87 | / match owner { [INFO] [stderr] 88 | | &Owner::Username(ref inner) => Some(inner.clone()), [INFO] [stderr] 89 | | _ => None, [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 87 | match *owner { [INFO] [stderr] 88 | Owner::Username(ref inner) => Some(inner.clone()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:92:33 [INFO] [stderr] | [INFO] [stderr] 92 | / match owner { [INFO] [stderr] 93 | | &Owner::Email(ref inner) => Some(inner.clone()), [INFO] [stderr] 94 | | _ => None, [INFO] [stderr] 95 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 92 | match *owner { [INFO] [stderr] 93 | Owner::Email(ref inner) => Some(inner.clone()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/main.rs:108:19 [INFO] [stderr] | [INFO] [stderr] 108 | match matches.value_of("path").unwrap().as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `matches.value_of("path").unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:82:33 [INFO] [stderr] | [INFO] [stderr] 82 | / match owner { [INFO] [stderr] 83 | | &Owner::Team(ref inner) => Some(inner.clone()), [INFO] [stderr] 84 | | _ => None, [INFO] [stderr] 85 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 82 | match *owner { [INFO] [stderr] 83 | Owner::Team(ref inner) => Some(inner.clone()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:87:33 [INFO] [stderr] | [INFO] [stderr] 87 | / match owner { [INFO] [stderr] 88 | | &Owner::Username(ref inner) => Some(inner.clone()), [INFO] [stderr] 89 | | _ => None, [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 87 | match *owner { [INFO] [stderr] 88 | Owner::Username(ref inner) => Some(inner.clone()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:92:33 [INFO] [stderr] | [INFO] [stderr] 92 | / match owner { [INFO] [stderr] 93 | | &Owner::Email(ref inner) => Some(inner.clone()), [INFO] [stderr] 94 | | _ => None, [INFO] [stderr] 95 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 92 | match *owner { [INFO] [stderr] 93 | Owner::Email(ref inner) => Some(inner.clone()), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/main.rs:108:19 [INFO] [stderr] | [INFO] [stderr] 108 | match matches.value_of("path").unwrap().as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `matches.value_of("path").unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.93s [INFO] running `"docker" "inspect" "5ddf56d2ed3fb7e95514f73a9d76376806f699a6d0b8d6daaae1c453bae88137"` [INFO] running `"docker" "rm" "-f" "5ddf56d2ed3fb7e95514f73a9d76376806f699a6d0b8d6daaae1c453bae88137"` [INFO] [stdout] 5ddf56d2ed3fb7e95514f73a9d76376806f699a6d0b8d6daaae1c453bae88137