[INFO] updating cached repository soenkehahn/rust-macro-playground [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/soenkehahn/rust-macro-playground [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/soenkehahn/rust-macro-playground" "work/ex/clippy-test-run/sources/stable/gh/soenkehahn/rust-macro-playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/soenkehahn/rust-macro-playground'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/soenkehahn/rust-macro-playground" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/soenkehahn/rust-macro-playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/soenkehahn/rust-macro-playground'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d1554c05f7653af7a9abad5319fd469d1aca49cb [INFO] sha for GitHub repo soenkehahn/rust-macro-playground: d1554c05f7653af7a9abad5319fd469d1aca49cb [INFO] validating manifest of soenkehahn/rust-macro-playground on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of soenkehahn/rust-macro-playground on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing soenkehahn/rust-macro-playground [INFO] finished frobbing soenkehahn/rust-macro-playground [INFO] frobbed toml for soenkehahn/rust-macro-playground written to work/ex/clippy-test-run/sources/stable/gh/soenkehahn/rust-macro-playground/Cargo.toml [INFO] started frobbing soenkehahn/rust-macro-playground [INFO] finished frobbing soenkehahn/rust-macro-playground [INFO] frobbed toml for soenkehahn/rust-macro-playground written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/soenkehahn/rust-macro-playground/Cargo.toml [INFO] crate soenkehahn/rust-macro-playground has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting soenkehahn/rust-macro-playground against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/soenkehahn/rust-macro-playground:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9e5e916d19e046674d1557574269505f0bdcc3249805379065b2da77f2f3f170 [INFO] running `"docker" "start" "-a" "9e5e916d19e046674d1557574269505f0bdcc3249805379065b2da77f2f3f170"` [INFO] [stderr] Checking rust-macros v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:40:27 [INFO] [stderr] | [INFO] [stderr] 40 | if s.contains(" ") { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/eval.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | union.map(|x| x.clone()).collect() //change to cloned? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `union.cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:40:27 [INFO] [stderr] | [INFO] [stderr] 40 | if s.contains(" ") { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/eval.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | union.map(|x| x.clone()).collect() //change to cloned? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `union.cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.87s [INFO] running `"docker" "inspect" "9e5e916d19e046674d1557574269505f0bdcc3249805379065b2da77f2f3f170"` [INFO] running `"docker" "rm" "-f" "9e5e916d19e046674d1557574269505f0bdcc3249805379065b2da77f2f3f170"` [INFO] [stdout] 9e5e916d19e046674d1557574269505f0bdcc3249805379065b2da77f2f3f170