[INFO] updating cached repository snorrwe/rust-guessing-game [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/snorrwe/rust-guessing-game [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/snorrwe/rust-guessing-game" "work/ex/clippy-test-run/sources/stable/gh/snorrwe/rust-guessing-game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/snorrwe/rust-guessing-game'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/snorrwe/rust-guessing-game" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/snorrwe/rust-guessing-game"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/snorrwe/rust-guessing-game'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 534798ccdd4ca00f88a75a45cda86d7cfbc96a0c [INFO] sha for GitHub repo snorrwe/rust-guessing-game: 534798ccdd4ca00f88a75a45cda86d7cfbc96a0c [INFO] validating manifest of snorrwe/rust-guessing-game on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of snorrwe/rust-guessing-game on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing snorrwe/rust-guessing-game [INFO] finished frobbing snorrwe/rust-guessing-game [INFO] frobbed toml for snorrwe/rust-guessing-game written to work/ex/clippy-test-run/sources/stable/gh/snorrwe/rust-guessing-game/Cargo.toml [INFO] started frobbing snorrwe/rust-guessing-game [INFO] finished frobbing snorrwe/rust-guessing-game [INFO] frobbed toml for snorrwe/rust-guessing-game written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/snorrwe/rust-guessing-game/Cargo.toml [INFO] crate snorrwe/rust-guessing-game has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting snorrwe/rust-guessing-game against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/snorrwe/rust-guessing-game:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 37bc4918f72ff7945c41f68de0e719a3080950998acf80240cdadbf4edee7b34 [INFO] running `"docker" "start" "-a" "37bc4918f72ff7945c41f68de0e719a3080950998acf80240cdadbf4edee7b34"` [INFO] [stderr] Checking rand v0.3.22 [INFO] [stderr] Checking guessing-game v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | min:min, [INFO] [stderr] | ^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | max: max, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | secret:secret [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | min:min, [INFO] [stderr] | ^^^^^^^ help: replace it with: `min` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | max: max, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | secret:secret [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/game.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/game.rs:55:18 [INFO] [stderr] | [INFO] [stderr] 55 | let result = guess.trim().parse::(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/game.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/game.rs:55:18 [INFO] [stderr] | [INFO] [stderr] 55 | let result = guess.trim().parse::(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.00s [INFO] running `"docker" "inspect" "37bc4918f72ff7945c41f68de0e719a3080950998acf80240cdadbf4edee7b34"` [INFO] running `"docker" "rm" "-f" "37bc4918f72ff7945c41f68de0e719a3080950998acf80240cdadbf4edee7b34"` [INFO] [stdout] 37bc4918f72ff7945c41f68de0e719a3080950998acf80240cdadbf4edee7b34