[INFO] updating cached repository smt923/brainfrick [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/smt923/brainfrick [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/smt923/brainfrick" "work/ex/clippy-test-run/sources/stable/gh/smt923/brainfrick"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/smt923/brainfrick'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/smt923/brainfrick" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smt923/brainfrick"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smt923/brainfrick'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c9e1073d52e1b06b21ae2c6b2fc2b46be0ce66e0 [INFO] sha for GitHub repo smt923/brainfrick: c9e1073d52e1b06b21ae2c6b2fc2b46be0ce66e0 [INFO] validating manifest of smt923/brainfrick on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of smt923/brainfrick on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing smt923/brainfrick [INFO] finished frobbing smt923/brainfrick [INFO] frobbed toml for smt923/brainfrick written to work/ex/clippy-test-run/sources/stable/gh/smt923/brainfrick/Cargo.toml [INFO] started frobbing smt923/brainfrick [INFO] finished frobbing smt923/brainfrick [INFO] frobbed toml for smt923/brainfrick written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smt923/brainfrick/Cargo.toml [INFO] crate smt923/brainfrick has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting smt923/brainfrick against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smt923/brainfrick:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 098b6244bcd3852651799b99a29826979131daf0da7c32754d5ce9b99ebe8c54 [INFO] running `"docker" "start" "-a" "098b6244bcd3852651799b99a29826979131daf0da7c32754d5ce9b99ebe8c54"` [INFO] [stderr] Checking brainfrick v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bf.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / match input { [INFO] [stderr] 106 | | Some(value) => self.mem[self.d] = value, [INFO] [stderr] 107 | | None => (), [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(value) = input { self.mem[self.d] = value }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/bf.rs:117:42 [INFO] [stderr] | [INFO] [stderr] 117 | if self.prog[self.pc] == '[' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'[' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/bf.rs:119:49 [INFO] [stderr] | [INFO] [stderr] 119 | } else if self.prog[self.pc] == ']' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b']' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/bf.rs:130:38 [INFO] [stderr] | [INFO] [stderr] 130 | if self.prog[self.pc] == '[' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'[' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/bf.rs:132:45 [INFO] [stderr] | [INFO] [stderr] 132 | } else if self.prog[self.pc] == ']' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b']' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bf.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | / match input { [INFO] [stderr] 106 | | Some(value) => self.mem[self.d] = value, [INFO] [stderr] 107 | | None => (), [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(value) = input { self.mem[self.d] = value }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/bf.rs:117:42 [INFO] [stderr] | [INFO] [stderr] 117 | if self.prog[self.pc] == '[' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'[' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/bf.rs:119:49 [INFO] [stderr] | [INFO] [stderr] 119 | } else if self.prog[self.pc] == ']' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b']' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/bf.rs:130:38 [INFO] [stderr] | [INFO] [stderr] 130 | if self.prog[self.pc] == '[' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'[' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/bf.rs:132:45 [INFO] [stderr] | [INFO] [stderr] 132 | } else if self.prog[self.pc] == ']' as u8 { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b']' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.84s [INFO] running `"docker" "inspect" "098b6244bcd3852651799b99a29826979131daf0da7c32754d5ce9b99ebe8c54"` [INFO] running `"docker" "rm" "-f" "098b6244bcd3852651799b99a29826979131daf0da7c32754d5ce9b99ebe8c54"` [INFO] [stdout] 098b6244bcd3852651799b99a29826979131daf0da7c32754d5ce9b99ebe8c54