[INFO] updating cached repository smoqadam/rtree [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/smoqadam/rtree [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/smoqadam/rtree" "work/ex/clippy-test-run/sources/stable/gh/smoqadam/rtree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/smoqadam/rtree'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/smoqadam/rtree" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smoqadam/rtree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smoqadam/rtree'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 243ebd2b3ba7f7fa4454e27044a2b906e9fa240f [INFO] sha for GitHub repo smoqadam/rtree: 243ebd2b3ba7f7fa4454e27044a2b906e9fa240f [INFO] validating manifest of smoqadam/rtree on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of smoqadam/rtree on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing smoqadam/rtree [INFO] finished frobbing smoqadam/rtree [INFO] frobbed toml for smoqadam/rtree written to work/ex/clippy-test-run/sources/stable/gh/smoqadam/rtree/Cargo.toml [INFO] started frobbing smoqadam/rtree [INFO] finished frobbing smoqadam/rtree [INFO] frobbed toml for smoqadam/rtree written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smoqadam/rtree/Cargo.toml [INFO] crate smoqadam/rtree has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting smoqadam/rtree against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smoqadam/rtree:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9412ed7a98b1213ca65575e6a1a7b275b2670dea8b07e16e2f4e7208ba54b862 [INFO] running `"docker" "start" "-a" "9412ed7a98b1213ca65575e6a1a7b275b2670dea8b07e16e2f4e7208ba54b862"` [INFO] [stderr] Checking rtree v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:28:57 [INFO] [stderr] | [INFO] [stderr] 28 | if get_file_name(&full_path, false).starts_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:28:57 [INFO] [stderr] | [INFO] [stderr] 28 | if get_file_name(&full_path, false).starts_with(".") { [INFO] [stderr] | ^^^ help: try using a char instead: `'.'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:55:62 [INFO] [stderr] | [INFO] [stderr] 55 | let filename = p.file_name().and_then(|n| n.to_str().map(|s| String::from(s))).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | String::from(filename) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:55:62 [INFO] [stderr] | [INFO] [stderr] 55 | let filename = p.file_name().and_then(|n| n.to_str().map(|s| String::from(s))).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | String::from(filename) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.76s [INFO] running `"docker" "inspect" "9412ed7a98b1213ca65575e6a1a7b275b2670dea8b07e16e2f4e7208ba54b862"` [INFO] running `"docker" "rm" "-f" "9412ed7a98b1213ca65575e6a1a7b275b2670dea8b07e16e2f4e7208ba54b862"` [INFO] [stdout] 9412ed7a98b1213ca65575e6a1a7b275b2670dea8b07e16e2f4e7208ba54b862