[INFO] updating cached repository smkell/fanoracle [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/smkell/fanoracle [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/smkell/fanoracle" "work/ex/clippy-test-run/sources/stable/gh/smkell/fanoracle"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/smkell/fanoracle'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/smkell/fanoracle" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smkell/fanoracle"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smkell/fanoracle'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ea9a4a83e85320f800ec4405ff0ec91cceb3a230 [INFO] sha for GitHub repo smkell/fanoracle: ea9a4a83e85320f800ec4405ff0ec91cceb3a230 [INFO] validating manifest of smkell/fanoracle on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of smkell/fanoracle on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing smkell/fanoracle [INFO] finished frobbing smkell/fanoracle [INFO] frobbed toml for smkell/fanoracle written to work/ex/clippy-test-run/sources/stable/gh/smkell/fanoracle/Cargo.toml [INFO] started frobbing smkell/fanoracle [INFO] finished frobbing smkell/fanoracle [INFO] frobbed toml for smkell/fanoracle written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smkell/fanoracle/Cargo.toml [INFO] crate smkell/fanoracle has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting smkell/fanoracle against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smkell/fanoracle:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ba13df46b92786f09ba5e66a8802055fc22d87f92689bb083beee48034f8490e [INFO] running `"docker" "start" "-a" "ba13df46b92786f09ba5e66a8802055fc22d87f92689bb083beee48034f8490e"` [INFO] [stderr] Checking fanoracle v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/http/statuscodes.rs:657:16 [INFO] [stderr] | [INFO] [stderr] 657 | pub fn to_u16(self) -> u16 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/http/statuscodes.rs:657:16 [INFO] [stderr] | [INFO] [stderr] 657 | pub fn to_u16(self) -> u16 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/http/statuscodes.rs:783:12 [INFO] [stderr] | [INFO] [stderr] 783 | for n in vec![0, 10, 600] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0, 10, 600]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.21s [INFO] running `"docker" "inspect" "ba13df46b92786f09ba5e66a8802055fc22d87f92689bb083beee48034f8490e"` [INFO] running `"docker" "rm" "-f" "ba13df46b92786f09ba5e66a8802055fc22d87f92689bb083beee48034f8490e"` [INFO] [stdout] ba13df46b92786f09ba5e66a8802055fc22d87f92689bb083beee48034f8490e