[INFO] updating cached repository smigniot/othellowasm [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/smigniot/othellowasm [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/smigniot/othellowasm" "work/ex/clippy-test-run/sources/stable/gh/smigniot/othellowasm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/smigniot/othellowasm'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/smigniot/othellowasm" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smigniot/othellowasm"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smigniot/othellowasm'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6e386e7af939ed3f698a68395053ae7bb793730e [INFO] sha for GitHub repo smigniot/othellowasm: 6e386e7af939ed3f698a68395053ae7bb793730e [INFO] validating manifest of smigniot/othellowasm on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of smigniot/othellowasm on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing smigniot/othellowasm [INFO] finished frobbing smigniot/othellowasm [INFO] frobbed toml for smigniot/othellowasm written to work/ex/clippy-test-run/sources/stable/gh/smigniot/othellowasm/Cargo.toml [INFO] started frobbing smigniot/othellowasm [INFO] finished frobbing smigniot/othellowasm [INFO] frobbed toml for smigniot/othellowasm written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smigniot/othellowasm/Cargo.toml [INFO] crate smigniot/othellowasm has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting smigniot/othellowasm against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/smigniot/othellowasm:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 083eaa78e744c0380d521ff8103987102c69ae48b0f94ff43defa496bc42b2c6 [INFO] running `"docker" "start" "-a" "083eaa78e744c0380d521ff8103987102c69ae48b0f94ff43defa496bc42b2c6"` [INFO] [stderr] Checking othello_rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | cells:cells, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `cells` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | cells:cells, [INFO] [stderr] | ^^^^^^^^^^^ help: replace it with: `cells` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:171:38 [INFO] [stderr] | [INFO] [stderr] 171 | Cell::Empty => { return false; }, [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:172:46 [INFO] [stderr] | [INFO] [stderr] 172 | Cell::Filled(ref c) => { return opponent == *c; }, // Is a neighbor opponent [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `opponent == *c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:243:9 [INFO] [stderr] | [INFO] [stderr] 243 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:317:9 [INFO] [stderr] | [INFO] [stderr] 317 | return swapped; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `swapped` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:171:38 [INFO] [stderr] | [INFO] [stderr] 171 | Cell::Empty => { return false; }, [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:172:46 [INFO] [stderr] | [INFO] [stderr] 172 | Cell::Filled(ref c) => { return opponent == *c; }, // Is a neighbor opponent [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `opponent == *c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:243:9 [INFO] [stderr] | [INFO] [stderr] 243 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/game.rs:317:9 [INFO] [stderr] | [INFO] [stderr] 317 | return swapped; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `swapped` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:128:31 [INFO] [stderr] | [INFO] [stderr] 128 | fn count_for(&self,player:&Color) -> (i32,i32) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:151:32 [INFO] [stderr] | [INFO] [stderr] 151 | fn moves_for(&self, player:&Color, previous_passed:bool) -> Vec { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | / match neighbor { [INFO] [stderr] 176 | | Some(_) => { [INFO] [stderr] 177 | | // Empty cell has any neighbor opponent [INFO] [stderr] 178 | | if self.is_changed(i,player) { [INFO] [stderr] ... | [INFO] [stderr] 183 | | _ => { }, [INFO] [stderr] 184 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 175 | if let Some(_) = neighbor { [INFO] [stderr] 176 | // Empty cell has any neighbor opponent [INFO] [stderr] 177 | if self.is_changed(i,player) { [INFO] [stderr] 178 | // Would flip pawns so is a valid move [INFO] [stderr] 179 | res.push(i); [INFO] [stderr] 180 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:199:45 [INFO] [stderr] | [INFO] [stderr] 199 | fn is_changed(&self, cell:usize, player:&Color) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | / match self.cells[cell] { [INFO] [stderr] 261 | | Cell::Empty => { [INFO] [stderr] 262 | | let (x0,y0) = (cell%8,cell/8); [INFO] [stderr] 263 | | for &(dx,dy) in NEIGHBORS.iter() { [INFO] [stderr] ... | [INFO] [stderr] 315 | | _ => { } [INFO] [stderr] 316 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 260 | if let Cell::Empty = self.cells[cell] { [INFO] [stderr] 261 | let (x0,y0) = (cell%8,cell/8); [INFO] [stderr] 262 | for &(dx,dy) in NEIGHBORS.iter() { [INFO] [stderr] 263 | toswap.clear(); [INFO] [stderr] 264 | let (mut x,mut y) = ((x0 as i8)+dx,(y0 as i8)+dy); [INFO] [stderr] 265 | if (x < 0) || (x > 7) { continue }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:342:34 [INFO] [stderr] | [INFO] [stderr] 342 | pub fn minimax(&self, player:&Color, depth:i32) -> i32 { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/game.rs:343:30 [INFO] [stderr] | [INFO] [stderr] 343 | let mut copy:Board = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:347:38 [INFO] [stderr] | [INFO] [stderr] 347 | fn mut_minimax(&mut self, player:&Color, depth:i32, maximizing:bool) -> i32 { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/game.rs:356:31 [INFO] [stderr] | [INFO] [stderr] 356 | let playing = self.player.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:128:31 [INFO] [stderr] | [INFO] [stderr] 128 | fn count_for(&self,player:&Color) -> (i32,i32) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:151:32 [INFO] [stderr] | [INFO] [stderr] 151 | fn moves_for(&self, player:&Color, previous_passed:bool) -> Vec { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | / match neighbor { [INFO] [stderr] 176 | | Some(_) => { [INFO] [stderr] 177 | | // Empty cell has any neighbor opponent [INFO] [stderr] 178 | | if self.is_changed(i,player) { [INFO] [stderr] ... | [INFO] [stderr] 183 | | _ => { }, [INFO] [stderr] 184 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 175 | if let Some(_) = neighbor { [INFO] [stderr] 176 | // Empty cell has any neighbor opponent [INFO] [stderr] 177 | if self.is_changed(i,player) { [INFO] [stderr] 178 | // Would flip pawns so is a valid move [INFO] [stderr] 179 | res.push(i); [INFO] [stderr] 180 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:199:45 [INFO] [stderr] | [INFO] [stderr] 199 | fn is_changed(&self, cell:usize, player:&Color) -> bool { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/game.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | / match self.cells[cell] { [INFO] [stderr] 261 | | Cell::Empty => { [INFO] [stderr] 262 | | let (x0,y0) = (cell%8,cell/8); [INFO] [stderr] 263 | | for &(dx,dy) in NEIGHBORS.iter() { [INFO] [stderr] ... | [INFO] [stderr] 315 | | _ => { } [INFO] [stderr] 316 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 260 | if let Cell::Empty = self.cells[cell] { [INFO] [stderr] 261 | let (x0,y0) = (cell%8,cell/8); [INFO] [stderr] 262 | for &(dx,dy) in NEIGHBORS.iter() { [INFO] [stderr] 263 | toswap.clear(); [INFO] [stderr] 264 | let (mut x,mut y) = ((x0 as i8)+dx,(y0 as i8)+dy); [INFO] [stderr] 265 | if (x < 0) || (x > 7) { continue }; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:342:34 [INFO] [stderr] | [INFO] [stderr] 342 | pub fn minimax(&self, player:&Color, depth:i32) -> i32 { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/game.rs:343:30 [INFO] [stderr] | [INFO] [stderr] 343 | let mut copy:Board = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/game.rs:347:38 [INFO] [stderr] | [INFO] [stderr] 347 | fn mut_minimax(&mut self, player:&Color, depth:i32, maximizing:bool) -> i32 { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `Color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/game.rs:356:31 [INFO] [stderr] | [INFO] [stderr] 356 | let playing = self.player.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.96s [INFO] running `"docker" "inspect" "083eaa78e744c0380d521ff8103987102c69ae48b0f94ff43defa496bc42b2c6"` [INFO] running `"docker" "rm" "-f" "083eaa78e744c0380d521ff8103987102c69ae48b0f94ff43defa496bc42b2c6"` [INFO] [stdout] 083eaa78e744c0380d521ff8103987102c69ae48b0f94ff43defa496bc42b2c6