[INFO] updating cached repository slotbaer/chronow [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/slotbaer/chronow [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/slotbaer/chronow" "work/ex/clippy-test-run/sources/stable/gh/slotbaer/chronow"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/slotbaer/chronow'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/slotbaer/chronow" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/slotbaer/chronow"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/slotbaer/chronow'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5b58f195069e14a8b6fee4286c26513102b790bb [INFO] sha for GitHub repo slotbaer/chronow: 5b58f195069e14a8b6fee4286c26513102b790bb [INFO] validating manifest of slotbaer/chronow on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of slotbaer/chronow on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing slotbaer/chronow [INFO] finished frobbing slotbaer/chronow [INFO] frobbed toml for slotbaer/chronow written to work/ex/clippy-test-run/sources/stable/gh/slotbaer/chronow/Cargo.toml [INFO] started frobbing slotbaer/chronow [INFO] finished frobbing slotbaer/chronow [INFO] frobbed toml for slotbaer/chronow written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/slotbaer/chronow/Cargo.toml [INFO] crate slotbaer/chronow has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting slotbaer/chronow against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/slotbaer/chronow:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 82f32fe1665b5938dea152eced664286bdb1ae0e9a82471cb59d4ece42ac83ed [INFO] running `"docker" "start" "-a" "82f32fe1665b5938dea152eced664286bdb1ae0e9a82471cb59d4ece42ac83ed"` [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Checking num-iter v0.1.34 [INFO] [stderr] Checking num v0.1.40 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking chronow v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | is_it_on: is_it_on [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_it_on` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/state.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | is_it_on: is_it_on [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `is_it_on` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/groups.rs:53:49 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn add_it_is(mut set: & mut HashSet) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/groups.rs:58:48 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn remove_it_is(set: & mut HashSet) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/time_to_groups.rs:47:56 [INFO] [stderr] | [INFO] [stderr] 47 | 30 ... 34 => { r.insert(groups::MINUTES_HALF); ()}, [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/time_to_groups.rs:73:76 [INFO] [stderr] | [INFO] [stderr] 73 | fn minute_before_after(mut set: & mut HashSet, m: Group, ba: Group) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/time_to_groups.rs:79:59 [INFO] [stderr] | [INFO] [stderr] 79 | fn minute_before(mut set: & mut HashSet, m: Group) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/time_to_groups.rs:84:58 [INFO] [stderr] | [INFO] [stderr] 84 | fn minute_after(mut set: & mut HashSet, m: Group) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/time_to_groups.rs:89:61 [INFO] [stderr] | [INFO] [stderr] 89 | fn minute_ba_half(mut set: & mut HashSet, ba: Group) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/state.rs:52:48 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn set_it_is(mut self, is_it_on: bool) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/groups.rs:53:49 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn add_it_is(mut set: & mut HashSet) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/groups.rs:58:48 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn remove_it_is(set: & mut HashSet) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/time_to_groups.rs:47:56 [INFO] [stderr] | [INFO] [stderr] 47 | 30 ... 34 => { r.insert(groups::MINUTES_HALF); ()}, [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/time_to_groups.rs:73:76 [INFO] [stderr] | [INFO] [stderr] 73 | fn minute_before_after(mut set: & mut HashSet, m: Group, ba: Group) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/time_to_groups.rs:79:59 [INFO] [stderr] | [INFO] [stderr] 79 | fn minute_before(mut set: & mut HashSet, m: Group) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/time_to_groups.rs:84:58 [INFO] [stderr] | [INFO] [stderr] 84 | fn minute_after(mut set: & mut HashSet, m: Group) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/time_to_groups.rs:89:61 [INFO] [stderr] | [INFO] [stderr] 89 | fn minute_ba_half(mut set: & mut HashSet, ba: Group) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/state.rs:52:48 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn set_it_is(mut self, is_it_on: bool) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/groups.rs:53:18 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn add_it_is(mut set: & mut HashSet) -> () { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/time_to_groups.rs:73:24 [INFO] [stderr] | [INFO] [stderr] 73 | fn minute_before_after(mut set: & mut HashSet, m: Group, ba: Group) -> () { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/time_to_groups.rs:79:18 [INFO] [stderr] | [INFO] [stderr] 79 | fn minute_before(mut set: & mut HashSet, m: Group) -> () { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/time_to_groups.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | fn minute_after(mut set: & mut HashSet, m: Group) -> () { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/time_to_groups.rs:89:19 [INFO] [stderr] | [INFO] [stderr] 89 | fn minute_ba_half(mut set: & mut HashSet, ba: Group) -> () { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MINUTES_THREEQUARTER` [INFO] [stderr] --> src/groups.rs:30:1 [INFO] [stderr] | [INFO] [stderr] 30 | pub const MINUTES_THREEQUARTER: Group = Group { base: 22, length: 11}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_it_is` [INFO] [stderr] --> src/groups.rs:48:1 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn get_it_is() -> HashSet { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `remove_it_is` [INFO] [stderr] --> src/groups.rs:58:1 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn remove_it_is(set: & mut HashSet) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_it_is` [INFO] [stderr] --> src/state.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn set_it_is(mut self, is_it_on: bool) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/groups.rs:53:18 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn add_it_is(mut set: & mut HashSet) -> () { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/time_to_groups.rs:73:24 [INFO] [stderr] | [INFO] [stderr] 73 | fn minute_before_after(mut set: & mut HashSet, m: Group, ba: Group) -> () { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/time_to_groups.rs:79:18 [INFO] [stderr] | [INFO] [stderr] 79 | fn minute_before(mut set: & mut HashSet, m: Group) -> () { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/time_to_groups.rs:84:17 [INFO] [stderr] | [INFO] [stderr] 84 | fn minute_after(mut set: & mut HashSet, m: Group) -> () { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/time_to_groups.rs:89:19 [INFO] [stderr] | [INFO] [stderr] 89 | fn minute_ba_half(mut set: & mut HashSet, ba: Group) -> () { [INFO] [stderr] | ----^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MINUTES_THREEQUARTER` [INFO] [stderr] --> src/groups.rs:30:1 [INFO] [stderr] | [INFO] [stderr] 30 | pub const MINUTES_THREEQUARTER: Group = Group { base: 22, length: 11}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_it_is` [INFO] [stderr] --> src/groups.rs:48:1 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn get_it_is() -> HashSet { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `remove_it_is` [INFO] [stderr] --> src/groups.rs:58:1 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn remove_it_is(set: & mut HashSet) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set_it_is` [INFO] [stderr] --> src/state.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn set_it_is(mut self, is_it_on: bool) -> () { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.02s [INFO] running `"docker" "inspect" "82f32fe1665b5938dea152eced664286bdb1ae0e9a82471cb59d4ece42ac83ed"` [INFO] running `"docker" "rm" "-f" "82f32fe1665b5938dea152eced664286bdb1ae0e9a82471cb59d4ece42ac83ed"` [INFO] [stdout] 82f32fe1665b5938dea152eced664286bdb1ae0e9a82471cb59d4ece42ac83ed