[INFO] updating cached repository skodt/interpreter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/skodt/interpreter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/skodt/interpreter" "work/ex/clippy-test-run/sources/stable/gh/skodt/interpreter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/skodt/interpreter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/skodt/interpreter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/skodt/interpreter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/skodt/interpreter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cade2f2557fc11ceb2437f4972b054729cddf800 [INFO] sha for GitHub repo skodt/interpreter: cade2f2557fc11ceb2437f4972b054729cddf800 [INFO] validating manifest of skodt/interpreter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of skodt/interpreter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing skodt/interpreter [INFO] finished frobbing skodt/interpreter [INFO] frobbed toml for skodt/interpreter written to work/ex/clippy-test-run/sources/stable/gh/skodt/interpreter/Cargo.toml [INFO] started frobbing skodt/interpreter [INFO] finished frobbing skodt/interpreter [INFO] frobbed toml for skodt/interpreter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/skodt/interpreter/Cargo.toml [INFO] crate skodt/interpreter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting skodt/interpreter against stable+rustflags=-Dclippy::into_iter_on_array for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/skodt/interpreter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dclippy::into_iter_on_array" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9073250403a921fad900e0e262470c1e1583439deb439f3c15b86f2022c4e234 [INFO] running `"docker" "start" "-a" "9073250403a921fad900e0e262470c1e1583439deb439f3c15b86f2022c4e234"` [INFO] [stderr] Checking interpreter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:28:19 [INFO] [stderr] | [INFO] [stderr] 28 | Integer { value: value } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:31:22 [INFO] [stderr] | [INFO] [stderr] 31 | Identifier { name: name } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | LetIn { name: name, value: Box::new(value), body: Box::new(body) } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:28:19 [INFO] [stderr] | [INFO] [stderr] 28 | Integer { value: value } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:31:22 [INFO] [stderr] | [INFO] [stderr] 31 | Identifier { name: name } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | LetIn { name: name, value: Box::new(value), body: Box::new(body) } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Read` [INFO] [stderr] --> src/lexer.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | / enum LexerState [INFO] [stderr] 24 | | { [INFO] [stderr] 25 | | ReadInt, [INFO] [stderr] 26 | | ReadIdentifier, [INFO] [stderr] ... | [INFO] [stderr] 34 | | ReadEq, [INFO] [stderr] 35 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Read` [INFO] [stderr] --> src/lexer.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | / enum LexerState [INFO] [stderr] 24 | | { [INFO] [stderr] 25 | | ReadInt, [INFO] [stderr] 26 | | ReadIdentifier, [INFO] [stderr] ... | [INFO] [stderr] 34 | | ReadEq, [INFO] [stderr] 35 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lexer.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | / pub fn new<'b>(input: std::str::Chars<'b>) -> Lexer<'b> [INFO] [stderr] 74 | | { [INFO] [stderr] 75 | | Lexer { [INFO] [stderr] 76 | | value: String::new(), [INFO] [stderr] ... | [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lexer.rs:119:34 [INFO] [stderr] | [INFO] [stderr] 119 | if self.value == "let".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"let"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lexer.rs:121:41 [INFO] [stderr] | [INFO] [stderr] 121 | } else if self.value == "in".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `"in"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lexer.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | / loop [INFO] [stderr] 215 | | { [INFO] [stderr] 216 | | match self.input.next() { [INFO] [stderr] 217 | | Some (c) => [INFO] [stderr] ... | [INFO] [stderr] 223 | | } [INFO] [stderr] 224 | | } [INFO] [stderr] | |_________^ help: try: `while let Some (c) = self.input.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lexer.rs:218:21 [INFO] [stderr] | [INFO] [stderr] 218 | / match self.consume(c) { [INFO] [stderr] 219 | | Some(token) => return Some(token), [INFO] [stderr] 220 | | None => () [INFO] [stderr] 221 | | }, [INFO] [stderr] | |_____________________^ help: try this: `if let Some(token) = self.consume(c) { return Some(token) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lexer.rs:252:9 [INFO] [stderr] | [INFO] [stderr] 252 | / match self [INFO] [stderr] 253 | | { [INFO] [stderr] 254 | | &Integer(n) => write!(f, "INT({})", n), [INFO] [stderr] 255 | | &Identifier(ref s) => write!(f, "ID({})", s), [INFO] [stderr] ... | [INFO] [stderr] 264 | | &In => write!(f,"'in'"), [INFO] [stderr] 265 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 252 | match *self [INFO] [stderr] 253 | { [INFO] [stderr] 254 | Integer(n) => write!(f, "INT({})", n), [INFO] [stderr] 255 | Identifier(ref s) => write!(f, "ID({})", s), [INFO] [stderr] 256 | Add => write!(f, "ADD"), [INFO] [stderr] 257 | Sub => write!(f, "SUB"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the `token @ _` pattern can be written as just `token` [INFO] [stderr] --> src/parser.rs:57:18 [INFO] [stderr] | [INFO] [stderr] 57 | Some(ref token @ _) if token == expected => (), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `token @ _` pattern can be written as just `token` [INFO] [stderr] --> src/parser.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | Some(token @ _) => [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ast.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / match self [INFO] [stderr] 55 | | { [INFO] [stderr] 56 | | &Add => write!(f, "+"), [INFO] [stderr] 57 | | &Sub => write!(f, "-"), [INFO] [stderr] 58 | | &Mul => write!(f, "*"), [INFO] [stderr] 59 | | &Div => write!(f, "/"), [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 54 | match *self [INFO] [stderr] 55 | { [INFO] [stderr] 56 | Add => write!(f, "+"), [INFO] [stderr] 57 | Sub => write!(f, "-"), [INFO] [stderr] 58 | Mul => write!(f, "*"), [INFO] [stderr] 59 | Div => write!(f, "/"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ast.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | / match self [INFO] [stderr] 69 | | { [INFO] [stderr] 70 | | &Integer { value: n } => write!(f, "{}", n), [INFO] [stderr] 71 | | &Identifier { name: ref s } => write!(f, "{}", s), [INFO] [stderr] ... | [INFO] [stderr] 75 | | write!(f, "let {} = {} in {}", name, value, body), [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 68 | match *self [INFO] [stderr] 69 | { [INFO] [stderr] 70 | Integer { value: n } => write!(f, "{}", n), [INFO] [stderr] 71 | Identifier { name: ref s } => write!(f, "{}", s), [INFO] [stderr] 72 | Binop { ref operator, ref left, ref right } => [INFO] [stderr] 73 | write!(f, "({} {} {})", left, operator, right), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match expr [INFO] [stderr] 22 | | { [INFO] [stderr] 23 | | &Integer { value } => value, [INFO] [stderr] 24 | | &Identifier { ref name } => [INFO] [stderr] ... | [INFO] [stderr] 42 | | }, [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *expr [INFO] [stderr] 22 | { [INFO] [stderr] 23 | Integer { value } => value, [INFO] [stderr] 24 | Identifier { ref name } => [INFO] [stderr] 25 | match self.environment.get(name) [INFO] [stderr] 26 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lexer.rs:73:5 [INFO] [stderr] | [INFO] [stderr] 73 | / pub fn new<'b>(input: std::str::Chars<'b>) -> Lexer<'b> [INFO] [stderr] 74 | | { [INFO] [stderr] 75 | | Lexer { [INFO] [stderr] 76 | | value: String::new(), [INFO] [stderr] ... | [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lexer.rs:119:34 [INFO] [stderr] | [INFO] [stderr] 119 | if self.value == "let".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `"let"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lexer.rs:121:41 [INFO] [stderr] | [INFO] [stderr] 121 | } else if self.value == "in".to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `"in"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lexer.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | / loop [INFO] [stderr] 215 | | { [INFO] [stderr] 216 | | match self.input.next() { [INFO] [stderr] 217 | | Some (c) => [INFO] [stderr] ... | [INFO] [stderr] 223 | | } [INFO] [stderr] 224 | | } [INFO] [stderr] | |_________^ help: try: `while let Some (c) = self.input.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lexer.rs:218:21 [INFO] [stderr] | [INFO] [stderr] 218 | / match self.consume(c) { [INFO] [stderr] 219 | | Some(token) => return Some(token), [INFO] [stderr] 220 | | None => () [INFO] [stderr] 221 | | }, [INFO] [stderr] | |_____________________^ help: try this: `if let Some(token) = self.consume(c) { return Some(token) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lexer.rs:252:9 [INFO] [stderr] | [INFO] [stderr] 252 | / match self [INFO] [stderr] 253 | | { [INFO] [stderr] 254 | | &Integer(n) => write!(f, "INT({})", n), [INFO] [stderr] 255 | | &Identifier(ref s) => write!(f, "ID({})", s), [INFO] [stderr] ... | [INFO] [stderr] 264 | | &In => write!(f,"'in'"), [INFO] [stderr] 265 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 252 | match *self [INFO] [stderr] 253 | { [INFO] [stderr] 254 | Integer(n) => write!(f, "INT({})", n), [INFO] [stderr] 255 | Identifier(ref s) => write!(f, "ID({})", s), [INFO] [stderr] 256 | Add => write!(f, "ADD"), [INFO] [stderr] 257 | Sub => write!(f, "SUB"), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the `token @ _` pattern can be written as just `token` [INFO] [stderr] --> src/parser.rs:57:18 [INFO] [stderr] | [INFO] [stderr] 57 | Some(ref token @ _) if token == expected => (), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `token @ _` pattern can be written as just `token` [INFO] [stderr] --> src/parser.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | Some(token @ _) => [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ast.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | / match self [INFO] [stderr] 55 | | { [INFO] [stderr] 56 | | &Add => write!(f, "+"), [INFO] [stderr] 57 | | &Sub => write!(f, "-"), [INFO] [stderr] 58 | | &Mul => write!(f, "*"), [INFO] [stderr] 59 | | &Div => write!(f, "/"), [INFO] [stderr] 60 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 54 | match *self [INFO] [stderr] 55 | { [INFO] [stderr] 56 | Add => write!(f, "+"), [INFO] [stderr] 57 | Sub => write!(f, "-"), [INFO] [stderr] 58 | Mul => write!(f, "*"), [INFO] [stderr] 59 | Div => write!(f, "/"), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ast.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | / match self [INFO] [stderr] 69 | | { [INFO] [stderr] 70 | | &Integer { value: n } => write!(f, "{}", n), [INFO] [stderr] 71 | | &Identifier { name: ref s } => write!(f, "{}", s), [INFO] [stderr] ... | [INFO] [stderr] 75 | | write!(f, "let {} = {} in {}", name, value, body), [INFO] [stderr] 76 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 68 | match *self [INFO] [stderr] 69 | { [INFO] [stderr] 70 | Integer { value: n } => write!(f, "{}", n), [INFO] [stderr] 71 | Identifier { name: ref s } => write!(f, "{}", s), [INFO] [stderr] 72 | Binop { ref operator, ref left, ref right } => [INFO] [stderr] 73 | write!(f, "({} {} {})", left, operator, right), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/interpreter.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / match expr [INFO] [stderr] 22 | | { [INFO] [stderr] 23 | | &Integer { value } => value, [INFO] [stderr] 24 | | &Identifier { ref name } => [INFO] [stderr] ... | [INFO] [stderr] 42 | | }, [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 21 | match *expr [INFO] [stderr] 22 | { [INFO] [stderr] 23 | Integer { value } => value, [INFO] [stderr] 24 | Identifier { ref name } => [INFO] [stderr] 25 | match self.environment.get(name) [INFO] [stderr] 26 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.89s [INFO] running `"docker" "inspect" "9073250403a921fad900e0e262470c1e1583439deb439f3c15b86f2022c4e234"` [INFO] running `"docker" "rm" "-f" "9073250403a921fad900e0e262470c1e1583439deb439f3c15b86f2022c4e234"` [INFO] [stdout] 9073250403a921fad900e0e262470c1e1583439deb439f3c15b86f2022c4e234